blender/blender

Cycles: support popup widget metadata for OSL shaders #106508

New Issue

Open

opened 2023-04-03 21:02:18 +02:00 by sanek122005 · 7 comments

sanek122005 commented

2023-04-03 21:02:18 +02:00

System Information
Operating system: Ubuntu 20.04
Graphics card: Geforce MX230

Blender Version
Broken: 3.5

Short description of error
setting the widget parameter as "popup" in the shader metadata should create a drop-down list in the node UI. This works in Houdini, but in blender instead it's a regular slider

Worked:

Don`t Worked:

a place in the shader code that sets the widget to look like this:

Exact steps for others to reproduce the error

Take the OSL shader in the attached files
Load it
See on node GUI

**System Information** Operating system: Ubuntu 20.04 Graphics card: Geforce MX230 **Blender Version** Broken: 3.5 **Short description of error** setting the widget parameter as "popup" in the shader metadata should create a drop-down list in the node UI. This works in Houdini, but in blender instead it's a regular slider Worked: ![ANKnCy3_ICA.jpg](/attachments/ff264d20-707a-4caa-a836-5421dce69bb5) Don`t Worked: ![Screenshot_20230403_215854.png](/attachments/3cbee8ad-4817-4fdc-9947-3142891c9835) a place in the shader code that sets the widget to look like this: ![Screenshot_20230403_215242.png](/attachments/363aa794-16b4-4fdb-8e4b-443452f32897) **Exact steps for others to reproduce the error** 1. Take the OSL shader in the attached files 2. Load it 3. See on node GUI

Screenshot_20230403_215242.png

36 KiB

ANKnCy3_ICA.jpg

50 KiB

UberScalarMath.osl

5.8 KiB

Screenshot_20230403_215854.png

15 KiB

sanek122005 added the

labels 2023-04-03 21:02:19 +02:00

Iliya Katushenock commented

2023-04-03 21:08:45 +02:00

Member

I'm not sure if something like this should work when we don't have an enum socket.

I'm not sure if something like this should work when we don't have an enum socket.

Iliya Katushenock added the

Nodes & Physics

Render & Cycles

labels 2023-04-03 21:09:04 +02:00

sanek122005 commented

2023-04-03 21:13:14 +02:00

Author

yes, but we have the usual drop-down lists. While there are no enum sockets, why not temporarily replace them with just a GUI element without a socket?

yes, but we have the usual drop-down lists. While there are no enum sockets, why not temporarily replace them with just a GUI element without a socket? ![Screenshot_20230403_215252.png](/attachments/cc7d0cfd-ae37-4cb8-aca9-b2fb70de56dc)

Screenshot_20230403_215252.png

3.7 KiB

Iliya Katushenock commented

2023-04-03 21:26:37 +02:00

Member

Because it would be a new feature, rather unusual. And it would cease to be a socket.

Because it would be a new feature, rather unusual. And it would cease to be a socket.

Philipp Oeser commented

2023-04-04 12:01:04 +02:00

Member

Because it would be a new feature, rather unusual. And it would cease to be a socket.

These enums are still (int) sockets which are not linkable (see usages of SOCKET_ENUM and friends).

This all could be done I think, e.g. OSLNode::add_input would need to be extended to support passing enum values to NodeType::register_input that it needs to get from the metadata "options".

For now though, this is just not implemented and looks like a feature request (rather than a bug).

Would be nice to add this as limitation to the manual though:
https://docs.blender.org/manual/en/3.6/render/shader_nodes/osl.html

@brecht : totally unsure what kind of priority this has (as compared to e.g. adding AOV support to OSL), would raise my hand to volunteer looking into this further if this is to be kept as TODO.

Otherwise, we would have to close this as a feature request though due to the following policy:

Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors.

For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests

For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

> Because it would be a new feature, rather unusual. And it would cease to be a socket. These enums are still (int) sockets which are not linkable (see usages of `SOCKET_ENUM` and friends). ----- This all could be done I think, e.g. `OSLNode::add_input` would need to be extended to support passing enum values to `NodeType::register_input` that it needs to get from the metadata "options". For now though, this is just not implemented and looks like a feature request (rather than a bug). Would be nice to add this as limitation to the manual though: https://docs.blender.org/manual/en/3.6/render/shader_nodes/osl.html @brecht : totally unsure what kind of priority this has (as compared to e.g. adding AOV support to OSL), would raise my hand to volunteer looking into this further if this is to be kept as TODO. Otherwise, we would have to close this as a feature request though due to the following policy: ``` Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors. For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug ```

Philipp Oeser added

Render & Cycles

Needs Info from Developers

and removed

Render & Cycles

labels 2023-04-04 12:01:40 +02:00

Iliya Katushenock commented

2023-04-04 13:50:35 +02:00

Member

@lichtwerk Enum sockets are not currently supported, this is a big topic for the node module and is not being developed yet. I'm not sure it would be easy to add this.
And if just make it a property of the node, which is much simpler, then it would not be a socket to which you can connect something.

@lichtwerk Enum sockets are not currently supported, this is a big topic for the node module and is not being developed yet. I'm not sure it would be easy to add this. And if just make it a property of the node, which is much simpler, then it would not be a socket to which you can connect something.

Philipp Oeser commented

2023-04-04 14:30:03 +02:00

Member

@lichtwerk Enum sockets are not currently supported, this is a big topic for the node module and is not being developed yet. I'm not sure it would be easy to add this.

Well, it might not be supported as-in exposed to geonodes, but internally SOCKET_ENUM is used to let NodeType::register_input know about a dropdown (in Cycles), there is also NODE_SOCKET_API to have a look at and see how this actually ends up in blender - if we decide to pursue this further. But since this is about Cycles, there is a good chance this could be supported after the script node was compiled and metadata is accessible. To really now, I'd have to spend more time on this though [which I wont do unless there is green light from the module].

> @lichtwerk Enum sockets are not currently supported, this is a big topic for the node module and is not being developed yet. I'm not sure it would be easy to add this. Well, it might not be supported as-in exposed to geonodes, but internally `SOCKET_ENUM` is used to let `NodeType::register_input` know about a dropdown (in Cycles), there is also `NODE_SOCKET_API` to have a look at and see how this actually ends up in blender - if we decide to pursue this further. But since this is about Cycles, there is a good chance this could be supported after the script node was compiled and metadata is accessible. To **really now**, I'd have to spend more time on this though [which I wont do unless there is green light from the module].

Brecht Van Lommel added

and removed

Needs Info from Developers

labels 2023-04-04 20:48:41 +02:00

Brecht Van Lommel changed title from ~~"popup" widget in OSL as ignored~~ to Cycles: support "popup" widget in OSL

2023-04-04 20:48:56 +02:00

Brecht Van Lommel added this to the Render & Cycles project 2023-04-04 20:49:15 +02:00

Brecht Van Lommel commented

2023-04-04 20:49:54 +02:00

Owner

I've marked this as a To Do now. But this is indeed blocked by proper support for enum sockets on the Blender side.

I've marked this as a To Do now. But this is indeed blocked by proper support for enum sockets on the Blender side.

Brecht Van Lommel changed title from ~~Cycles: support "popup" widget in OSL~~ to Cycles: support popup widget metadata for OSL shaders

2023-04-04 20:50:16 +02:00

Philipp Oeser referenced this issue

2023-04-13 09:07:43 +02:00

OSL CheckBox socket not working in NodeGroup #106760

Sign in to join this conversation.

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Code Documentation

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106508

No description provided.