Cannot undo python opeartor that writes to curve attribute - if #114173

New Issue

Jose Conseco · 2023-10-26T17:02:59+02:00

Jose Conseco commented

2023-10-26 17:02:59 +02:00

System Information
Operating system: Linux-6.1.55-1-MANJARO-x86_64-with-glibc2.38 64 Bits, X11 UI
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 535.113.01

Blender Version
Broken: version: 3.6.5, branch: blender-v3.6-release, commit date: 2023-10-16 14:30, hash: cf1e1ed46b7e
Worked: It works in Blender 4:
version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-10-12 18:54, hash: 1c4b2ad17f, type: release
build date: 2023-10-13, 00:23:59

Short description of error
Running simple operator, that increases radius attribute for curve (rad += 1), cannot be undone - if executed in curve edit mode.
Issue is fixed in Blender 4.0 so, maybe the fix can be ported to LTS 3.6?

Exact steps for others to reproduce the error

Run script from text editor
Select curve and go curve edit mode.
search for 'Simple operator' under search menu in 3d view - it will increase radius +1
Undo - see no effect

**System Information** Operating system: Linux-6.1.55-1-MANJARO-x86_64-with-glibc2.38 64 Bits, X11 UI Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 535.113.01 **Blender Version** Broken: version: 3.6.5, branch: blender-v3.6-release, commit date: 2023-10-16 14:30, hash: `cf1e1ed46b7e` Worked: It works in Blender 4: version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-10-12 18:54, hash: 1c4b2ad17f5f, type: release build date: 2023-10-13, 00:23:59 **Short description of error** Running simple operator, that increases radius attribute for curve (rad += 1), cannot be undone - if executed in curve edit mode. Issue is fixed in Blender 4.0 so, maybe the fix can be ported to LTS 3.6? **Exact steps for others to reproduce the error** 1. Run script from text editor 2. Select curve and go curve edit mode. 3. search for 'Simple operator' under search menu in 3d view - it will increase radius +1 4. Undo - see no effect

curve_attrib_write_undo_wrong_b365.blend

135 KiB

Jose Conseco added the

labels 2023-10-26 17:03:00 +02:00

Richard Antalik commented

2023-10-26 17:30:06 +02:00

Seems you have posted URI to the file not uploaded it.

Richard Antalik added

Status

Needs Information from User

and removed

Status

Needs Triage

labels 2023-10-26 17:30:13 +02:00

Jose Conseco commented

2023-10-26 18:51:05 +02:00

My bad. if fixed the upload.

Richard Antalik commented

2023-10-27 15:54:23 +02:00

Sorry just now I read, that you request backport. Not sure what commit did fix this though. Will have to bisect, but then AFAIK 4.0 is quite a bit different to 3.6, so it may not be applicable.

Richard Antalik commented

2023-11-08 18:41:24 +01:00

I had trouble building 3.6 version so I can bisect. @HooglyBoogly do you know whether this could be fixed in 3.6? I can try windows machine, pretty sure I can build there .

Hans Goudey commented

2023-11-09 00:27:58 +01:00

My guess is 34b4487844. That's already mentioned in the LTS maintenance task #109399, since it may be required for some other fix. Not sure exactly what will happen there.

My guess is 34b44878449d67a56fd2a2b850cb04af5a23ca56. That's already mentioned in the LTS maintenance task #109399, since it may be required for some other fix. Not sure exactly what will happen there.

👍 1

Jose Conseco commented

2024-01-22 19:56:12 +01:00

This task has label 'need info from user' but I think all required info is already there?

Richard Antalik commented

2024-01-23 16:20:38 +01:00

Sorry I must have missed update, will re-check

Richard Antalik added

Status

Needs Triage

and removed

Status

Needs Information from User

labels 2024-01-23 16:20:48 +01:00

Pratik Borhade commented

2024-02-06 11:15:49 +01:00

34b4487844 indeed fixed the "undo" problem in 4.1/main.
Commit is not listed for backporting, AFAICS 😅

34b44878449d67a56fd2a2b850cb04af5a23ca56 indeed fixed the "undo" problem in 4.1/main. Commit is not listed for backporting, AFAICS 😅

Pratik Borhade added

and removed

labels 2024-02-06 11:16:01 +01:00

Pratik Borhade added this to the 3.6 LTS milestone 2024-02-06 11:16:06 +01:00

Pratik Borhade referenced this issue

2024-02-06 11:21:37 +01:00

Blender LTS: Maintenance Task 3.6 #109399

Pratik Borhade commented

2024-02-06 12:11:43 +01:00

#109399 (comment) : While 34b4487844 would be nice, it's less of a nobrainer, because some people were relying on the buggy behavior. See #113621. It's probably safer not to fix this particular thing in 3.6.

Backporting this fix is not safe enough, closing.

> https://projects.blender.org/blender/blender/issues/109399#issuecomment-1116703 : While 34b4487844 would be nice, it's less of a nobrainer, because some people were relying on the buggy behavior. See #113621. It's probably safer not to fix this particular thing in 3.6. Backporting this fix is not safe enough, closing.

👍 1 😕 1

Pratik Borhade closed this issue

2024-02-06 12:11:46 +01:00

Blender Bot added

and removed

labels 2024-02-06 12:16:23 +01:00

Philipp Oeser referenced a pull request that will close this issue

2024-02-14 13:05:08 +01:00