API gpu.state.scissor_test_set(False) not working #113310

New Issue

Y.T-LAW · 2023-10-05T23:25:11+02:00

Y.T-LAW commented

2023-10-05 23:25:11 +02:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.34

Blender Version
Broken: version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-10-04 23:50, hash: 2f71d9f80795
Broken: 3.5, 3.6, 4.0
Worked:

Short description of error
Unable to disable scissor test.

Exact steps for others to reproduce the error
Consider this script works fine in v3.6

import bpy, gpu, blf, bgl
from gpu_extras.batch import batch_for_shader

vertices = (
    (100, 100), (300, 100),
    (100, 200), (300, 200))

indices = (
    (0, 1, 2), (2, 1, 3))

shader = gpu.shader.from_builtin('UNIFORM_COLOR')
batch = batch_for_shader(shader, 'TRIS', {"pos": vertices}, indices=indices)


def draw():
    bgl.glEnable(bgl.GL_SCISSOR_TEST)
    bgl.glScissor(100, 100, 200, 50)
    shader.uniform_float("color", (0, 0.5, 0.5, 1.0))
    batch.draw(shader)
    bgl.glDisable(bgl.GL_SCISSOR_TEST)
    blf.position(0, 100, 150, 0)
    blf.size(0, 50.0)
    blf.draw(0, "Cut the Box only")

bpy.types.SpaceView3D.draw_handler_add(draw, (), 'WINDOW', 'POST_PIXEL')

Got unexpected results in v4.0

import bpy, gpu, blf
from gpu_extras.batch import batch_for_shader

vertices = (
    (100, 100), (300, 100),
    (100, 200), (300, 200))

indices = (
    (0, 1, 2), (2, 1, 3))

shader = gpu.shader.from_builtin('UNIFORM_COLOR')
batch = batch_for_shader(shader, 'TRIS', {"pos": vertices}, indices=indices)


def draw():
    gpu.state.scissor_test_set(True) # <---------------
    gpu.state.scissor_set(100, 100, 200, 50) # <-------
    shader.uniform_float("color", (0, 0.5, 0.5, 1.0))
    batch.draw(shader)
    gpu.state.scissor_test_set(False) # <---------------
    blf.position(0, 100, 150, 0)
    blf.size(0, 50.0)
    blf.draw(0, "Cut the Box only")

bpy.types.SpaceView3D.draw_handler_add(draw, (), 'WINDOW', 'POST_PIXEL')

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.34 **Blender Version** Broken: version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-10-04 23:50, hash: `2f71d9f80795` Broken: 3.5, 3.6, 4.0 Worked: **Short description of error** Unable to disable scissor test. **Exact steps for others to reproduce the error** Consider this script works fine in v3.6 ``` import bpy, gpu, blf, bgl from gpu_extras.batch import batch_for_shader vertices = ( (100, 100), (300, 100), (100, 200), (300, 200)) indices = ( (0, 1, 2), (2, 1, 3)) shader = gpu.shader.from_builtin('UNIFORM_COLOR') batch = batch_for_shader(shader, 'TRIS', {"pos": vertices}, indices=indices) def draw(): bgl.glEnable(bgl.GL_SCISSOR_TEST) bgl.glScissor(100, 100, 200, 50) shader.uniform_float("color", (0, 0.5, 0.5, 1.0)) batch.draw(shader) bgl.glDisable(bgl.GL_SCISSOR_TEST) blf.position(0, 100, 150, 0) blf.size(0, 50.0) blf.draw(0, "Cut the Box only") bpy.types.SpaceView3D.draw_handler_add(draw, (), 'WINDOW', 'POST_PIXEL') ``` ![image](/attachments/fdf8a868-ff9c-4710-ae0e-4dc2de08a3f3) ------------------------------------------------------------------------------------------------------------------------------ **Got unexpected results in v4.0** ``` import bpy, gpu, blf from gpu_extras.batch import batch_for_shader vertices = ( (100, 100), (300, 100), (100, 200), (300, 200)) indices = ( (0, 1, 2), (2, 1, 3)) shader = gpu.shader.from_builtin('UNIFORM_COLOR') batch = batch_for_shader(shader, 'TRIS', {"pos": vertices}, indices=indices) def draw(): gpu.state.scissor_test_set(True) # <--------------- gpu.state.scissor_set(100, 100, 200, 50) # <------- shader.uniform_float("color", (0, 0.5, 0.5, 1.0)) batch.draw(shader) gpu.state.scissor_test_set(False) # <--------------- blf.position(0, 100, 150, 0) blf.size(0, 50.0) blf.draw(0, "Cut the Box only") bpy.types.SpaceView3D.draw_handler_add(draw, (), 'WINDOW', 'POST_PIXEL') ``` ![image](/attachments/f72e83d6-8def-4d55-b91e-9ac88defdc96)

image.png

21 KiB

image.png

21 KiB

Y.T-LAW added the

labels 2023-10-05 23:25:11 +02:00

Pratik Borhade commented

2023-10-06 08:29:20 +02:00

Thanks for the report. I can confirm

Pratik Borhade added

and removed

labels 2023-10-06 08:29:45 +02:00

Y.T-LAW commented

2023-10-12 19:41:24 +02:00

Let me know if it's fixed for v4.0/4.1 since I'm catching up a add-on, thanks.

Pratik Borhade commented

2023-10-13 04:28:31 +02:00

cc @Jeroen-Bakker

Jeroen Bakker commented

2023-10-13 06:11:46 +02:00

Although the top script gives expected results it is not advices to mingle bgl and gpu calls as it messes up the internal state bgl calls go directly to OpenGL driver and changes the state that blender isn’t aware of. So might be expected, but is asking for problems.

For second script I need to check renderdoc state updates are normally updated during the next drawing command.

Although the top script gives expected results it is not advices to mingle bgl and gpu calls as it messes up the internal state bgl calls go directly to OpenGL driver and changes the state that blender isn’t aware of. So might be expected, but is asking for problems. For second script I need to check renderdoc state updates are normally updated during the next drawing command.

Jeroen Bakker commented

2023-10-13 07:21:58 +02:00

With disabling the scissor test

After commenting out scissor_test_set(False)

So I confirm that something isn't working as expected.

My idea is that the state is altered to quick and not all events are translated to gl commands. This can be seen as setting the scissor command isn't sent to the driver.

With disabling the scissor test ![image](/attachments/98bb3467-4d04-4a5a-8298-5a5abd534cf4) After commenting out `scissor_test_set(False)` ![image](/attachments/27c1b6e9-759e-474b-b586-4e6cb5048603) So I confirm that something isn't working as expected. My idea is that the state is altered to quick and not all events are translated to gl commands. This can be seen as setting the scissor command isn't sent to the driver.

image.png

359 KiB

image.png

364 KiB

Jeroen Bakker commented

2023-10-13 07:42:14 +02:00

Found the issue, when setting the scissor enablement, the framebuffer isn't tagged as being dirty.
I will add a patch to 3.3, 3.6 and 4.0

Thanks for reporting!

Found the issue, when setting the scissor enablement, the framebuffer isn't tagged as being dirty. I will add a patch to 3.3, 3.6 and 4.0 Thanks for reporting!

Jeroen Bakker referenced a pull request that will close this issue

2023-10-13 07:43:33 +02:00

Fix #113310: Python gpu.state.scissor_test_set Not Updating State #113642

Jeroen Bakker referenced this issue from a commit

2023-10-13 07:44:20 +02:00

Fix #113310: Python gpu.state.scissor_test_set Not Updating State

Jeroen Bakker closed this issue

2023-10-13 07:44:23 +02:00

Blender Bot added

Status

Resolved

and removed