Append: in localize All
case, LibOverrides does not behave properly and will leave Main data in invalid state.
#109004
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#109004
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
in
Localize All
case, append process does not handle LibOverride data properly currently: LibOverrides are kept as-is, but (some of) their dependencies may be made local directly. This leads to local liboverrides with local ID references, and/or linked data using local IDs...Current append code relies on the premises that all newly linked data is made local. This is no longer applicable when linking liboverrides, since their linked references should never be made local (regardless of whether liboverrides themselves should be kept as liboverrides, or also be made fully local data).
Solving this issue is not trivial, and will require some careful thinking and design.
Solution Ideas
There are two possible ways to handle liboverrides when appending:
Currently, Blender tries to implement behavior
2
. However, from a consistency and logical PoV, it would likely make more sense to rather go for behavior1
?Regardless of the final outcome, Append process needs to be modified to take into account LibOverride data usages:
2
is kept, there is the complex topic of what to do with 'regular linked data` from appended liboverrides (e.g. a liboverride Object usually still uses a simple linked obdata ID, not a liboverride of its reference obdata)?1
. Achieving proper consistency in behavior2
feels simply impossible, even from a theoretical PoV.Original Report
System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94
Blender Version
Broken: version: 3.6.0 Beta, branch: blender-v3.6-release, commit date: 2023-06-13 23:42, hash:
962331c256b0
Worked: (newest version of Blender that worked as expected)
Short description of error
Based on my experiments for #108967 I found a new crash in 3.6. Drag and dropping a specific collection asset from the asset browser in Append mode will cause a crash if this same collection asset was previously imported.
(duplicating the collection works fine, and link mode 'twice' does nothing but change the position of the previously imported collection).
Context about attached files:
The collection asset in "VP_Simulator" was dropped in "WUX450ST.blend" in linked mode, with Instance collection unckecked. Then I parented the "projector" to the object "wux450st" and put the asset collection in another collection which I made an asset.
Exact steps for others to reproduce the error
WUX450ST
collection to the scene (uncheckinstance
from redo panel)No crash if I import the asset collection
projector_sim
in append modeThanks for the report. I can confirm the crash.
I am able to replicate the crash with following steps:
Append
assetProjector_Sim
into the scene twiceEdit:
Can't replicate the crash in debugger...
BlendfileLinkAppendContextItem
id.lib
is NULL in this case, butlib.filepath
is accessed (same asBlendfileLinkAppendContextItem
source_library
)@mont29 will know best here
I cannot reproduce any crash currently, neither with 3.6 not 4.0?
@mont29 : I can still repro in both 4.0 and 3.6 with the steps in the report description
Aaaaah ok it works with 'append and reuse' (my default), but not just 'append'.
Assets : Crash when drag and dropping a collection asset in Append mode twiceto Append: Appending LibOverrides does not behave properly and will leave Main data in invalid state.Updated description with actual problem and how it could be solved. This won't be trivial.
TL;DR: do not try to append LibOverride data until this issue is addressed.
Append: Appending LibOverrides does not behave properly and will leave Main data in invalid state.to Append: in `localize All` case, LibOverrides does not behave properly and will leave Main data in invalid state.