Fix #105045: Error importing FBX custom properties on placeholder PoseBones #105052

Thomas Barlow · 2023-12-09T03:14:10+01:00

Thomas Barlow commented

2023-12-09 03:14:10 +01:00

Caused by not understanding an uncommon import case in 716702b97e where
a bone can be created without an FBX Node to import custom properties
from.

A bone in Blender is always created from an FBX Node, so it seemed like
all bones should have an FBX Node that custom properties can be imported
from. However, FBX allows bone and non-bone Nodes to be parented to one
another, which Blender cannot represent exactly due to Armatures only
containing bones. In such cases, the non-bone Node is imported as an
Object, but a bone with the same name is also created (which the Object
is parented to). The newly created bone doesn't have a Node to import
custom properties from because the Node belongs to the imported Object
instead.

This is a request to backport f21b90cbab for Blender 3.6 with the conflicts in bl_info resolved.

Caused by not understanding an uncommon import case in 716702b97e where a bone can be created without an FBX Node to import custom properties from. A bone in Blender is always created from an FBX Node, so it seemed like all bones should have an FBX Node that custom properties can be imported from. However, FBX allows bone and non-bone Nodes to be parented to one another, which Blender cannot represent exactly due to Armatures only containing bones. In such cases, the non-bone Node is imported as an Object, but a bone with the same name is also created (which the Object is parented to). The newly created bone doesn't have a Node to import custom properties from because the Node belongs to the imported Object instead. --- This is a request to backport f21b90cbab for Blender 3.6 with the conflicts in `bl_info` resolved.

Thomas Barlow added 1 commit 2023-12-09 03:14:12 +01:00

0db38ad102 Fix #105045 : Error importing FBX custom properties on placeholder PoseBones

Caused by not understanding an uncommon import case in 716702b97e where
a bone can be created without an FBX Node to import custom properties
from.

A bone in Blender is always created from an FBX Node, so it seemed like
all bones should have an FBX Node that custom properties can be imported
from. However, FBX allows bone and non-bone Nodes to be parented to one
another, which Blender cannot represent exactly due to Armatures only
containing bones. In such cases, the non-bone Node is imported as an
Object, but a bone with the same name is also created (which the Object
is parented to). The newly created bone doesn't have a Node to import
custom properties from because the Node belongs to the imported Object
instead.

Thomas Barlow requested review from Bastien Montagne 2023-12-09 03:30:41 +01:00

Bastien Montagne approved these changes 2023-12-19 12:05:35 +01:00

Bastien Montagne referenced this pull request from blender/blender

2023-12-19 12:09:06 +01:00

Blender LTS: Maintenance Task 3.6 #109399

Pratik Borhade commented

2024-01-05 11:58:52 +01:00

@Mysteryem PR is ready to merge :)

Thomas Barlow commented

2024-01-05 16:12:03 +01:00

Because this is a backport, I think someone on the team that handles backports needs to be the one to merge this. I can't update the backports list anyway.

Pratik Borhade commented

2024-01-06 06:32:39 +01:00

@lichtwerk @ThomasDinges does the backporting. AFAIK they cherry pick the commit from main branch to LTS in other cases.
Since PR is created on 3.6 branch, it can be merged directly. Anyways, let's wait for Philipp's/Thomas's reply 🙂

@lichtwerk @ThomasDinges does the backporting. AFAIK they cherry pick the commit from main branch to LTS in other cases. Since PR is created on 3.6 branch, it can be merged directly. Anyways, let's wait for Philipp's/Thomas's reply 🙂

Philipp Oeser merged commit bd37c9b0fd into blender-v3.6-release

2024-01-10 09:23:23 +01:00

Philipp Oeser referenced this issue from a commit

2024-01-10 09:23:24 +01:00

Fix #105045: Error importing FBX custom properties on placeholder PoseBones

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #105045: Error importing FBX custom properties on placeholder PoseBones #105052