blender/blender-addons
19
43
Fork 96
Code Issues 628 Pull Requests 27 Projects 1 Releases Wiki Activity

Fix #105045: Error importing FBX custom properties on placeholder PoseBones #105052

Merged
Philipp Oeser merged 1 commits from Mysteryem/blender-addons:fbx_3_6_placeholder_custom_prop_backport into blender-v3.6-release 2024-01-10 09:23:23 +01:00
Conversation 3 Commits 1 Files Changed 2 +8 -2
Thomas Barlow commented 2023-12-09 03:14:10 +01:00
Member
Copy Link

Caused by not understanding an uncommon import case in 716702b97e where
a bone can be created without an FBX Node to import custom properties
from.

A bone in Blender is always created from an FBX Node, so it seemed like
all bones should have an FBX Node that custom properties can be imported
from. However, FBX allows bone and non-bone Nodes to be parented to one
another, which Blender cannot represent exactly due to Armatures only
containing bones. In such cases, the non-bone Node is imported as an
Object, but a bone with the same name is also created (which the Object
is parented to). The newly created bone doesn't have a Node to import
custom properties from because the Node belongs to the imported Object
instead.

This is a request to backport f21b90cbab for Blender 3.6 with the conflicts in bl_info resolved.

Caused by not understanding an uncommon import case in 716702b97e where a bone can be created without an FBX Node to import custom properties from. A bone in Blender is always created from an FBX Node, so it seemed like all bones should have an FBX Node that custom properties can be imported from. However, FBX allows bone and non-bone Nodes to be parented to one another, which Blender cannot represent exactly due to Armatures only containing bones. In such cases, the non-bone Node is imported as an Object, but a bone with the same name is also created (which the Object is parented to). The newly created bone doesn't have a Node to import custom properties from because the Node belongs to the imported Object instead. --- This is a request to backport f21b90cbab for Blender 3.6 with the conflicts in `bl_info` resolved.
Thomas Barlow added 1 commit 2023-12-09 03:14:12 +01:00 
Caused by not understanding an uncommon import case in 716702b97e where
a bone can be created without an FBX Node to import custom properties
from.

A bone in Blender is always created from an FBX Node, so it seemed like
all bones should have an FBX Node that custom properties can be imported
from. However, FBX allows bone and non-bone Nodes to be parented to one
another, which Blender cannot represent exactly due to Armatures only
containing bones. In such cases, the non-bone Node is imported as an
Object, but a bone with the same name is also created (which the Object
is parented to). The newly created bone doesn't have a Node to import
custom properties from because the Node belongs to the imported Object
instead.
Thomas Barlow requested review from Bastien Montagne 2023-12-09 03:30:41 +01:00
Bastien Montagne approved these changes 2023-12-19 12:05:35 +01:00
Pratik Borhade commented 2024-01-05 11:58:52 +01:00
Member
Copy Link

@Mysteryem PR is ready to merge :)

@Mysteryem PR is ready to merge :)
Thomas Barlow commented 2024-01-05 16:12:03 +01:00
Author
Member
Copy Link

Because this is a backport, I think someone on the team that handles backports needs to be the one to merge this. I can't update the backports list anyway.

Because this is a backport, I think someone on the team that handles backports needs to be the one to merge this. I can't update the backports list anyway.
Pratik Borhade commented 2024-01-06 06:32:39 +01:00
Member
Copy Link

@lichtwerk @ThomasDinges does the backporting. AFAIK they cherry pick the commit from main branch to LTS in other cases.
Since PR is created on 3.6 branch, it can be merged directly. Anyways, let's wait for Philipp's/Thomas's reply 🙂

@lichtwerk @ThomasDinges does the backporting. AFAIK they cherry pick the commit from main branch to LTS in other cases. Since PR is created on 3.6 branch, it can be merged directly. Anyways, let's wait for Philipp's/Thomas's reply 🙂
Philipp Oeser merged commit bd37c9b0fd into blender-v3.6-release 2024-01-10 09:23:23 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Bastien Montagne
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#105052
No description provided.
Delete Branch "Mysteryem/blender-addons:fbx_3_6_placeholder_custom_prop_backport"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?