Possible crash with Motion Blur with changing curves count #117485

New Issue

Closed

opened 2024-01-24 18:48:21 +01:00 by Steffen Dünner · 4 comments

Steffen Dünner commented

2024-01-24 18:48:21 +01:00

System Information
Operating system: Linux-6.5.0-14-generic-x86_64-with-glibc2.35 64 Bits, X11 UI
Graphics card: NVIDIA GeForce RTX 2070 Super/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 535.154.05

Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2024-01-24 17:30, hash: ae27daf8340a

Short description of error
Rendering will very likely crash when rendering changing topology, in this case curves.
I was building a quick and simple test scene with Geometry Nodes and it started crashing on the farm.

Exact steps for others to reproduce the error

Open the attached blend file: Shortest_Edge_Path_v04.blend
Start a "Render Animation" or press CTRL + F12
Wait a few frames -> crash

The crash won't happen if "Motion Blur" is disabled.

**System Information** Operating system: Linux-6.5.0-14-generic-x86_64-with-glibc2.35 64 Bits, X11 UI Graphics card: NVIDIA GeForce RTX 2070 Super/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 535.154.05 **Blender Version** Broken: version: 4.1.0 Alpha, branch: main, commit date: 2024-01-24 17:30, hash: `ae27daf8340a` **Short description of error** Rendering will very likely crash when rendering changing topology, in this case curves. I was building a quick and simple test scene with Geometry Nodes and it started crashing on the farm. **Exact steps for others to reproduce the error** - Open the attached blend file: [Shortest_Edge_Path_v04.blend](/attachments/08a7d10c-45df-46be-a473-ef26fc59aa52) - Start a "Render Animation" or press CTRL + F12 - Wait a few frames -> crash The crash won't happen if "Motion Blur" is disabled.

Shortest_Edge_Path_v04.blend

175 KiB

Steffen Dünner added the

labels 2024-01-24 18:48:22 +01:00

Pratik Borhade commented

2024-01-25 06:08:03 +01:00

Member

Thanks for the report. Can confirm the crash.

Thanks for the report. Can confirm the crash.

Pratik Borhade added

Render & Cycles

and removed

labels 2024-01-25 06:08:26 +01:00

Pratik Borhade commented

2024-01-25 06:15:38 +01:00

Member

Call stack was empty so hard to guess the reason here. Seems to happen when iterating repeat zone 5 times

Call stack was empty so hard to guess the reason here. Seems to happen when iterating repeat zone 5 times

Philipp Oeser commented

2024-01-25 12:45:59 +01:00

Member

Reads out of bounds of curve_first_key and asserts here

6  ccl::array<int, 16ul>::operator[]  array.h    205  0x10e4b942 
7  ccl::Hair::get_curve               hair.h     114  0x10e4a1ce 
8  ccl::export_hair_curves_motion     curves.cpp 948  0x10e34b73 
9  ccl::BlenderSync::sync_hair        curves.cpp 1004 0x10e362b2 
10 ccl::BlenderSync::sync_hair_motion curves.cpp 1075 0x10e37cfb

POC bandaid hack (but there are other places reading from curve_first_key, so might not be safe at all)

diff --git a/intern/cycles/blender/curves.cpp b/intern/cycles/blender/curves.cpp
index 626fa4bbe95..57c41a02dbc 100644
--- a/intern/cycles/blender/curves.cpp
+++ b/intern/cycles/blender/curves.cpp
@@ -945,6 +945,12 @@ static void export_hair_curves_motion(Hair *hair,
   for (const int i : points_by_curve.index_range()) {
     const blender::IndexRange points = points_by_curve[i];
 
+    if (curve_index >= hair->get_curve_first_key().size()) {
+      have_motion = false;
+      curve_index++;
+      continue;
+    }
+
     Hair::Curve curve = hair->get_curve(curve_index);
     curve_index++;

Reads out of bounds of `curve_first_key` and asserts here ``` 6 ccl::array<int, 16ul>::operator[] array.h 205 0x10e4b942 7 ccl::Hair::get_curve hair.h 114 0x10e4a1ce 8 ccl::export_hair_curves_motion curves.cpp 948 0x10e34b73 9 ccl::BlenderSync::sync_hair curves.cpp 1004 0x10e362b2 10 ccl::BlenderSync::sync_hair_motion curves.cpp 1075 0x10e37cfb ``` POC bandaid hack (but there are other places reading from `curve_first_key`, so might not be safe at all) ```diff diff --git a/intern/cycles/blender/curves.cpp b/intern/cycles/blender/curves.cpp index 626fa4bbe95..57c41a02dbc 100644 --- a/intern/cycles/blender/curves.cpp +++ b/intern/cycles/blender/curves.cpp @@ -945,6 +945,12 @@ static void export_hair_curves_motion(Hair *hair, for (const int i : points_by_curve.index_range()) { const blender::IndexRange points = points_by_curve[i]; + if (curve_index >= hair->get_curve_first_key().size()) { + have_motion = false; + curve_index++; + continue; + } + Hair::Curve curve = hair->get_curve(curve_index); curve_index++; ```

Philipp Oeser changed title from ~~Possible crash with Motion Blur~~ to Possible crash with Motion Blur with changing curves count

2024-01-25 12:46:43 +01:00

Philipp Oeser commented

2024-02-12 13:23:44 +01:00

Member

Will raise the priority since this is a crasher (and not totally unlikely to run into)

Will raise the priority since this is a crasher (and not totally unlikely to run into)

Philipp Oeser added

and removed

labels 2024-02-12 13:23:54 +01:00

Brecht Van Lommel referenced a pull request that will close this issue

2024-02-28 17:20:25 +01:00

Fix #117485: Crash rendering motion blur with changing curve count #118859

Brecht Van Lommel referenced this issue from a commit

2024-02-29 13:50:02 +01:00

Fix #117485: Crash rendering motion blur with changing curve count

Brecht Van Lommel closed this issue

2024-02-29 13:50:05 +01:00

Blender Bot added

and removed

labels 2024-02-29 13:50:07 +01:00

Brecht Van Lommel referenced this issue

2024-02-29 13:54:33 +01:00

Blender LTS: Maintenance Task 3.6 #109399

Brecht Van Lommel referenced this issue

2024-02-29 13:55:02 +01:00

Blender LTS: Maintenance Task 3.3 #100749

Brecht Van Lommel referenced this issue from a commit

2024-03-12 14:18:05 +01:00

Fix #117485: Crash rendering motion blur with changing curve count

Brecht Van Lommel referenced this issue from a commit

2024-03-12 14:18:31 +01:00

Fix #117485: Crash rendering motion blur with changing curve count

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117485

No description provided.