Fix #112123: only some vertex weights editable (Blender 3.6) #112360

Merged
Philipp Oeser merged 1 commits from JacquesLucke/blender:not-all-vertex-weights-editable into blender-v3.6-release 2023-09-15 15:03:47 +02:00
Member

I couldn't reproduce the issue myself, but my guess is that this happened to work for me because freeing the pointer and then immediately allocating the same size again yielded the same pointer. This is allocator dependent behavior which depends on the platform.

A stable pointer is necessary so that uiButs of different frames can be identified to correspond to each other.

In main that works already, because Vector.resize does not change the pointer if the size does not change.

I couldn't reproduce the issue myself, but my guess is that this happened to work for me because freeing the pointer and then immediately allocating the same size again yielded the same pointer. This is allocator dependent behavior which depends on the platform. A stable pointer is necessary so that `uiBut`s of different frames can be identified to correspond to each other. In `main` that works already, because `Vector.resize` does not change the pointer if the size does not change.
Jacques Lucke added 1 commit 2023-09-14 09:36:26 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
34594860aa
fix
Author
Member

@blender-bot build

@blender-bot build
Jacques Lucke requested review from Philipp Oeser 2023-09-14 09:36:54 +02:00
Jacques Lucke requested review from Germano Cavalcante 2023-09-14 09:36:54 +02:00
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR112360) when ready.
Member

I wont be able the approve the PR (since I cannot repro the original issue)

I wont be able the approve the PR (since I cannot repro the original issue)
Member

CC @zanqdo
CC @reed2000

would be nice to test the builds (once they are ready)

CC @zanqdo CC @reed2000 would be nice to test the builds (once they are ready)
Germano Cavalcante approved these changes 2023-09-14 16:22:14 +02:00
Germano Cavalcante left a comment
Member

I can confirm that this resolved the issue.

I can confirm that this resolved the issue.
Member

@blender-bot build

@blender-bot build
Member

@blender-bot build

@blender-bot build
Member

As agreed in chat, we dare ignoring the failing bots (these seem to be random timeout failures), each platform has succeeded at least once (if we assume @mano-wii was testing on windows), will merge then

As agreed in chat, we dare ignoring the failing bots (these seem to be random timeout failures), each platform has succeeded at least once (if we assume @mano-wii was testing on windows), will merge then
Philipp Oeser merged commit 048d4638af into blender-v3.6-release 2023-09-15 15:03:47 +02:00
Philipp Oeser deleted branch not-all-vertex-weights-editable 2023-09-15 15:03:52 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112360
No description provided.