API Unexpected timer event after clicking the Modifier sort area in UI #113697

New Issue

Y.T-LAW · 2023-10-13T21:26:58+02:00

Y.T-LAW commented

2023-10-13 21:26:58 +02:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 537.34

Blender Version
Broken: version: 3.6.1, branch: blender-v3.6-release, commit date: 2023-07-17 12:50, hash: 8bda729ef4dc
Worked:

Short description of error
Unexpected timer event after clicking the Modifier sort area in the User Interface.

Exact steps for others to reproduce the error
Consider this script works fine and nothing printed in console when run the script.

Open Blender with factory settings and run the script.

import bpy

class ModalOperator(bpy.types.Operator):
    bl_idname = "object.test_operator"
    bl_label = "Test Modal Operator"

    def modal(self, context, event):
        if event.type == "ESC":
            return {'FINISHED'}

        if event.type == "TIMER":
            print('Unexpected timer event...')

        return {'RUNNING_MODAL'}

    def invoke(self, context, event):
        context.window_manager.modal_handler_add(self)
        return {'RUNNING_MODAL'}


def register():
    bpy.utils.register_class(ModalOperator)

def unregister():
    bpy.utils.unregister_class(ModalOperator)

if __name__ == "__main__":
    register()

    # test call
    bpy.ops.object.test_operator('INVOKE_DEFAULT')

Now, Open Blender with factory settings and add a modifier to the Cube.

Clicking the Sort Area.
Run script
Console prints a lot of unexpected messages.

It messes up the operator in my project when user clicking on the Sort Area since I'm using a timer event in the operator to calculate something.

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 537.34 **Blender Version** Broken: version: 3.6.1, branch: blender-v3.6-release, commit date: 2023-07-17 12:50, hash: `8bda729ef4dc` Worked: **Short description of error** Unexpected timer event after clicking the Modifier sort area in the User Interface. **Exact steps for others to reproduce the error** Consider this script works fine and nothing printed in console when run the script. 1. Open Blender with factory settings and run the script. ``` Python import bpy class ModalOperator(bpy.types.Operator): bl_idname = "object.test_operator" bl_label = "Test Modal Operator" def modal(self, context, event): if event.type == "ESC": return {'FINISHED'} if event.type == "TIMER": print('Unexpected timer event...') return {'RUNNING_MODAL'} def invoke(self, context, event): context.window_manager.modal_handler_add(self) return {'RUNNING_MODAL'} def register(): bpy.utils.register_class(ModalOperator) def unregister(): bpy.utils.unregister_class(ModalOperator) if __name__ == "__main__": register() # test call bpy.ops.object.test_operator('INVOKE_DEFAULT') ``` Now, Open Blender with factory settings and add a modifier to the _Cube_. 1. Clicking the _Sort Area_. ![image](/attachments/bf6bae6d-880a-4056-bced-b0aeaaf3b986) 2. Run script 3. Console prints a lot of unexpected messages. It messes up the operator in my project when user clicking on the _Sort Area_ since I'm using a timer event in the operator to calculate something.

image.png

4.8 KiB

Y.T-LAW added the

labels 2023-10-13 21:26:58 +02:00

Jesse Yurkovich commented

2023-10-13 23:51:23 +02:00

Confirmed, and this occurs for any Panel being reordered by dragging etc. (not just the modifier panels)

Panel drag reorder operations are leaking a timer instance, and have been for the past several versions at least.

Confirmed, and this occurs for any Panel being reordered by dragging etc. (not just the modifier panels) Panel drag reorder operations are leaking a timer instance, and have been for the past several versions at least.

Jesse Yurkovich added

and removed

labels 2023-10-13 23:51:36 +02:00

Jesse Yurkovich referenced a pull request that will close this issue

2023-10-14 05:09:37 +02:00

Fix #113697: Fix timer leak from panel drag/animate processing #113711