[Sun position] Fix missing parameter (patch available) #117397

New Issue

SL-1 · 2024-01-22T09:23:05+01:00

SL-1 commented

2024-01-22 09:23:05 +01:00

System Information
Operating system: Linux-6.5.0-5-amd64-x86_64-with-glibc2.37 64 Bits, X11 UI
Graphics card: Mesa Intel(R) Graphics (ADL-N) Intel 4.6 (Core Profile) Mesa 23.2.1-1

Blender Version
Broken: version: 4.0.2, branch: Unknown, commit date: Unknown Unknown, hash: Unknown
Worked: can't tell, but regression appeared in 7f5f13cbb0

Short description of error
A parameter was lost after an API update

Exact steps for others to reproduce the error
I was playing around with the Sun Position addon and noticed an error regarding a missing parameter. The fix is simple, so instead of a scenario, I am providing a patch.

**System Information** Operating system: Linux-6.5.0-5-amd64-x86_64-with-glibc2.37 64 Bits, X11 UI Graphics card: Mesa Intel(R) Graphics (ADL-N) Intel 4.6 (Core Profile) Mesa 23.2.1-1 **Blender Version** Broken: version: 4.0.2, branch: Unknown, commit date: Unknown Unknown, hash: `Unknown` Worked: can't tell, but regression appeared in 7f5f13cbb0 **Short description of error** A parameter was lost after an API update **Exact steps for others to reproduce the error** I was playing around with the Sun Position addon and noticed an error regarding a missing parameter. The fix is simple, so instead of a scenario, I am providing a patch.

sun_calc.py.patch

620 B

👍 1

SL-1 added the

labels 2024-01-22 09:23:06 +01:00

Germano Cavalcante commented

2024-01-22 18:02:00 +01:00

Hi @SL-1, thank you for the report. However, it has some issues:

It should have been reported in the blender-addons repository instead of the blender repository. The addon authors monitor and fix the code there, so it's the appropriate place for addon-related issues.
The description of the issue is not clear, and it's important to provide more information for us to understand and reproduce the problem. Without a clear understanding of the issue, we cannot blindly accept and apply patches.
If you have a patch to fix the issue, it is recommended to create a Pull Request (PR) following our contribution guidelines. You can find the guidelines at: https://developer.blender.org/docs/handbook/contributing/

Please make the necessary adjustments and provide more information about the issue.

(cc @pioverfour)

Hi @SL-1, thank you for the report. However, it has some issues: 1. It should have been reported in the [blender-addons](https://projects.blender.org/blender/blender-addons) repository instead of the [blender](https://projects.blender.org/blender/blender) repository. The addon authors monitor and fix the code there, so it's the appropriate place for addon-related issues. 2. The description of the issue is not clear, and it's important to provide more information for us to understand and reproduce the problem. Without a clear understanding of the issue, we cannot blindly accept and apply patches. 3. If you have a patch to fix the issue, it is recommended to create a Pull Request (PR) following our contribution guidelines. You can find the guidelines at: https://developer.blender.org/docs/handbook/contributing/ Please make the necessary adjustments and provide more information about the issue. (cc @pioverfour)

Germano Cavalcante closed this issue

2024-01-22 18:02:03 +01:00

Blender Bot added

and removed

labels 2024-01-22 18:02:06 +01:00

Damien Picard referenced this issue from a commit

2024-01-22 19:28:22 +01:00

Sun Position: fix error with Diurnal mode of Sun collection

Damien Picard referenced this issue

2024-01-22 19:34:31 +01:00

Blender LTS: Maintenance Task 3.6 #109399

Damien Picard commented

2024-01-22 19:39:37 +01:00

@SL-1 Germano is right, but thanks for the report and patch. The issue will be fixed in 4.1 as well as the next 3.6 release.

SL-1 commented

2024-01-22 20:15:20 +01:00

Hi @SL-1, thank you for the report. However, it has some issues:

It should have been reported in the blender-addons repository instead of the blender repository. The addon authors monitor and fix the code there, so it's the appropriate place for addon-related issues.

Agreed, but I also followed some instructions which asked me to click in some menu to fill in automatically some setup info, and guess what, it opens the issue on blender rather than blender-addons.

The description of the issue is not clear, and it's important to provide more information for us to understand
and reproduce the problem. Without a clear understanding of the issue, we cannot blindly accept and apply patches.

Agreed, I should have tracked how I triggered it and provided a MWE. But you know how life is, it's 2AM, you fix a minor thing and move on, the patch is obviously fixing an issue.

If you have a patch to fix the issue, it is recommended to create a Pull Request (PR) following our contribution guidelines.
You can find the guidelines at: https://developer.blender.org/docs/handbook/contributing/

Too much fuss for a one-liner, sorry.

I find an issue that has been there for 9 months, I fix it, open a ticket, provide a patch, I think I have done my share of the work. I am quite sure in the past I created a patch through some github interface which transparently created a PR, maybe that would fill a gap for simple fixes like this one. You would be happier, I would save some time. Maybe I missed it, though.

Anyway, thanks for Blender, I started playing with it a few days ago for one specific need (shadow projections), it has done the job wonderfully.

> Hi @SL-1, thank you for the report. However, it has some issues: > > 1. It should have been reported in the [blender-addons](https://projects.blender.org/blender/blender-addons) repository instead of the [blender](https://projects.blender.org/blender/blender) repository. The addon authors monitor and fix the code there, so it's the appropriate place for addon-related issues. Agreed, but I also followed some instructions which asked me to click in some menu to fill in automatically some setup info, and guess what, it opens the issue on blender rather than blender-addons. > 2. The description of the issue is not clear, and it's important to provide more information for us to understand > and reproduce the problem. Without a clear understanding of the issue, we cannot blindly accept and apply patches. Agreed, I should have tracked how I triggered it and provided a MWE. But you know how life is, it's 2AM, you fix a minor thing and move on, the patch is obviously fixing an issue. > 3. If you have a patch to fix the issue, it is recommended to create a Pull Request (PR) following our contribution guidelines. > You can find the guidelines at: https://developer.blender.org/docs/handbook/contributing/ Too much fuss for a one-liner, sorry. I find an issue that has been there for 9 months, I fix it, open a ticket, provide a patch, I think I have done my share of the work. I am quite sure in the past I created a patch through some github interface which transparently created a PR, maybe that would fill a gap for simple fixes like this one. You would be happier, I would save some time. Maybe I missed it, though. Anyway, thanks for Blender, I started playing with it a few days ago for one specific need (shadow projections), it has done the job wonderfully.

SL-1 commented

2024-01-22 20:16:58 +01:00

@SL-1 Germano is right, but thanks for the report and patch. The issue will be fixed in 4.1 as well as the next 3.6 release.

You are welcome, I'll see when this gets packaged for my distro.

> @SL-1 Germano is right, but thanks for the report and patch. The issue will be fixed in 4.1 as well as the next 3.6 release. You are welcome, I'll see when this gets packaged for my distro.

❤️ 1

Philipp Oeser referenced this issue from a commit

2024-02-14 15:10:33 +01:00

Sun Position: fix error with Diurnal mode of Sun collection

Sign in to join this conversation.