Regression: Crash on deleting NLA strip in tweak mode #109430

New Issue

Albert-OShea · 2023-06-28T02:34:58+02:00

Albert-OShea commented

2023-06-28 02:34:58 +02:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 522.30

Blender Version
Broken: version: 3.0, 3.6.0, branch: blender-v3.6-release, commit date: 2023-06-27 08:08, hash: c7fc78b81ecb
Worked: 2.93

Short description of error
When using the 'Previous Layer' function of the Action Editor to tweak NLA strips, trying to delete a (green) strip in tweak mode crashes Blender.

Exact steps for others to reproduce the error

Open 109430.blend
In the NLA area, press X to delete the green strip.
Blender crashes

Original/from fresh file:

In the default startup file, open 2 areas; a Dope Sheet set to Action Editor, and a Nonlinear Animation.
Keyframe any property of the default cube.
In the Action Editor, click Push Down on the newly created action.
Also in the Action Editor, click the 'Previous Layer' button (the small down arrow). This activates tweaking for the NLA strip.
In the NLA area, click the green strip so it's highlighted.
Press X to delete it. Blender crashes.

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 522.30 **Blender Version** Broken: version: 3.0, 3.6.0, branch: blender-v3.6-release, commit date: 2023-06-27 08:08, hash: `c7fc78b81ecb` Worked: 2.93 **Short description of error** When using the 'Previous Layer' function of the Action Editor to tweak NLA strips, trying to delete a (green) strip in tweak mode crashes Blender. **Exact steps for others to reproduce the error** - Open `109430.blend` - In the NLA area, press X to delete the green strip. - Blender crashes Original/from fresh file: - In the default startup file, open 2 areas; a Dope Sheet set to Action Editor, and a Nonlinear Animation. - Keyframe any property of the default cube. - In the Action Editor, click Push Down on the newly created action. - Also in the Action Editor, click the 'Previous Layer' button (the small down arrow). This activates tweaking for the NLA strip. - In the NLA area, click the green strip so it's highlighted. - Press X to delete it. Blender crashes.

blender.crash.txt

52 KiB

109430.blend

872 KiB

Albert-OShea added the

labels 2023-06-28 02:34:59 +02:00

YimingWu commented

2023-06-28 07:01:53 +02:00

Can confirm the crash. Will upload the file for the convenience of testing.

YimingWu added

and removed

labels 2023-06-28 07:02:19 +02:00

Pratik Borhade commented

2023-06-28 08:08:24 +02:00

Looks like a regression introduced between 2.93 - 3.0 release.

Pratik Borhade changed title from ~~Crash on deleting NLA strip in tweak mode~~ to Regression: Crash on deleting NLA strip in tweak mode

2023-06-28 08:09:04 +02:00

Nathan Vegdahl self-assigned this 2023-10-31 14:11:51 +01:00

Nathan Vegdahl referenced a pull request that will close this issue

2023-10-31 15:50:59 +01:00

Fix #109430: exit tweak mode before deleting an in-tweak-mode NLA strip #114331

Nathan Vegdahl referenced this issue from a commit

2023-10-31 16:06:47 +01:00

Fix #109430: exit tweak mode before deleting an in-tweak-mode NLA strip

Nathan Vegdahl closed this issue

2023-10-31 16:06:49 +01:00

Blender Bot added

and removed

labels 2023-10-31 16:06:50 +01:00

Pratik Borhade commented

2023-11-03 10:48:13 +01:00

@nathanvegdahl hi, can we backport your fix to 3.3, 3.6LTS? Looks small and safe enough

Nathan Vegdahl commented

2023-11-07 09:54:21 +01:00

@PratikPB2123 I think so? I'm not aware of any code changes that would make this problematic to backport, at least.

Do you want me to take care of that, or should I leave that to you?

@PratikPB2123 I think so? I'm not aware of any code changes that would make this problematic to backport, at least. Do you want me to take care of that, or should I leave that to you?

Pratik Borhade referenced this issue

2023-11-07 10:58:38 +01:00

Blender LTS: Maintenance Task 3.6 #109399

Pratik Borhade referenced this issue

2023-11-07 10:58:53 +01:00

Blender LTS: Maintenance Task 3.3 #100749

Pratik Borhade commented

2023-11-07 11:00:34 +01:00

@nathanvegdahl , thanks. Added in #109430, #109399

👍 1

Philipp Oeser referenced this issue from a commit

2023-11-14 13:20:08 +01:00