Geometry Nodes: Float Curve input limits are not working unless "reset view" is used #106139

New Issue

Closed

opened 2023-03-25 20:27:17 +01:00 by Serge Lyatin · 4 comments

Serge Lyatin commented

2023-03-25 20:27:17 +01:00

System Information
Operating system: win10
Graphics card: 1050ti

Blender Version
Broken: 3.5.0

Short description of error
Max Y parameter is set to 2 and control point's actual Y value is also 2, view area is default. But output value is still 1.
This is broken only in GN, same node from shader editor is working fine.

Exact steps for others to reproduce the error
In attached file:

Activate Reset View in GN Float Curve's settings to see correct value in Viewer node (it is already pinned in spreadsheet)
If zoomed in on the GN Float Curve, the spreadsheet value will be clamped to the maximum value of the viewable range of the curve widget.

**System Information** Operating system: win10 Graphics card: 1050ti **Blender Version** Broken: 3.5.0 **Short description of error** Max Y parameter is set to 2 and control point's actual Y value is also 2, view area is default. But output value is still 1. This is broken only in GN, same node from shader editor is working fine. **Exact steps for others to reproduce the error** In attached file: * Activate **Reset View** in GN *Float Curve*'s settings to see correct value in Viewer node (it is already pinned in spreadsheet) * If zoomed in on the GN *Float Curve*, the spreadsheet value will be clamped to the maximum value of the viewable range of the curve widget.

float_curve_limit_problem.blend

117 KiB

Serge Lyatin added the

labels 2023-03-25 20:27:18 +01:00

Iliya Katushenock commented

2023-03-25 22:10:48 +01:00

Member

The last time I looked at the limits, I found out that this node has no value limits. This is a parameter of curve editor, that is, by doing from 0 to 2x in Y, you simply change the scale of the curve display.
But now, playing with your example, I see the strangest thing that has ever happened: try clicking on different control points of the curve, it changes the result.

The last time I looked at the limits, I found out that this node has no value limits. This is a parameter of curve editor, that is, by doing from 0 to 2x in Y, you simply change the scale of the curve display. But now, playing with your example, I see the strangest thing that has ever happened: try clicking on different control points of the curve, it changes the result.

Iliya Katushenock added the

Nodes & Physics

labels 2023-03-25 22:11:03 +01:00

Iliya Katushenock commented

2023-03-25 22:23:28 +01:00

Member

No description provided.

2023-03-26 00-22-46.mp4

4.3 MiB

YimingWu commented

2023-03-26 16:15:08 +02:00

Member

After fiddling around I found that the value will always be clamped to the viewing range maximum Y value, reproducible by zooming in/out and moving the curve viewing range.

This could be the cause:

source/blender/blenkernel/intern/colortools.c, line 973

float BKE_curvemapping_evaluateF(const CurveMapping *cumap, int cur, float value)
{
  const CurveMap *cuma = cumap->cm + cur;
  float val = BKE_curvemap_evaluateF(cumap, cuma, value);

  /* account for clipping */
  if (cumap->flag & CUMA_DO_CLIP) {
    if (val < cumap->curr.ymin) {       <------------ Should be `clipr.ymin`, similarly below.
      val = cumap->curr.ymin;
    }
    else if (val > cumap->curr.ymax) {
      val = cumap->curr.ymax;
    }
  }

  return val;
}

After commenting out those lines, the problem disappears. Further inspection seem to indicate that we need to use clipr instead of curr, since curr is basically representing the viewing range, it should not change evaluation result.

After fiddling around I found that the value will always be clamped to the viewing range maximum Y value, reproducible by zooming in/out and moving the curve viewing range. This could be the cause: source/blender/blenkernel/intern/colortools.c, line 973 ```Cpp float BKE_curvemapping_evaluateF(const CurveMapping *cumap, int cur, float value) { const CurveMap *cuma = cumap->cm + cur; float val = BKE_curvemap_evaluateF(cumap, cuma, value); /* account for clipping */ if (cumap->flag & CUMA_DO_CLIP) { if (val < cumap->curr.ymin) { <------------ Should be `clipr.ymin`, similarly below. val = cumap->curr.ymin; } else if (val > cumap->curr.ymax) { val = cumap->curr.ymax; } } return val; } ``` After commenting out those lines, the problem disappears. Further inspection seem to indicate that we need to use `clipr` instead of `curr`, since `curr` is basically representing the viewing range, it should not change evaluation result. ![图片](/attachments/a977dbba-3fef-464a-8f7f-77706674a192) ![图片](/attachments/5e7f0f67-9cd3-4f5b-834b-630effc9dba2)

Pratik Borhade commented

2023-03-27 04:23:45 +02:00

Member

Can confirm.

Can confirm.

Pratik Borhade added

Nodes & Physics

and removed

Nodes & Physics

labels 2023-03-27 04:24:09 +02:00

YimingWu referenced a pull request that will close this issue

2023-03-27 11:22:55 +02:00

Fix #106139: Curvemapping clipping range variable error #106164

Iliya Katushenock added

and removed

Nodes & Physics

labels 2023-05-02 15:48:49 +02:00

YimingWu referenced this issue from a commit

2023-07-21 03:26:35 +02:00

Fix #106139: Curvemapping clipping range variable error

YimingWu closed this issue

2023-07-21 03:26:36 +02:00

Blender Bot added

and removed

labels 2023-07-21 03:26:37 +02:00

YimingWu referenced this issue

2023-07-21 03:29:37 +02:00

Blender LTS: Maintenance Task 3.6 #109399

YimingWu referenced this issue

2023-07-21 03:30:32 +02:00

Blender LTS: Maintenance Task 3.3 #100749

Philipp Oeser referenced this issue from a commit

2023-08-09 17:13:00 +02:00

Fix #106139: Curvemapping clipping range variable error

Philipp Oeser referenced this issue from a commit

2023-08-09 22:57:02 +02:00

Fix #106139: Curvemapping clipping range variable error

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106139

No description provided.