blender
/
blender
134
398
Fork 581
Code Issues 6.3k Pull Requests 757 Projects 19 Wiki Activity

Cycles: build graphics binaries for Meteor Lake iGPUs #117027

Manually merged
Brecht Van Lommel merged 7 commits from xavierh/blender:blender3.6meteor_lake into blender-v3.6-release 2024-02-15 17:43:13 +01:00
Conversation 16 Commits 7 Files Changed 10 +84 -44
Xavier Hallade commented 2024-01-11 13:20:46 +01:00
Member
Copy Link

This is a backport of
1161455084
ef80392721
7df6d9eb52
9d5164d472
5aed85dcd7
3faa5db2e9
to 3.6, so graphics binaries for Intel Core Ultra iGPUs get included.

This is a backport of 1161455084b80ff101f7dcf4d2cf74fb42e858ea ef803927219e49a975da4133b3837a098dcb297f 7df6d9eb528def7d595b73d97e3e48a567870442 9d5164d472ac83a4e4c8393fae9966594b28c78b 5aed85dcd71ba8d47b5a3f9661a334b635d02b22 3faa5db2e907592d93799d17580030bfdd39a8c9 to 3.6, so graphics binaries for Intel Core Ultra iGPUs get included.
Xavier Hallade changed title from Cycles: build graphics binaries for Meteor Lake iGPUs to WIP: Cycles: build graphics binaries for Meteor Lake iGPUs 2024-01-11 13:33:20 +01:00
Xavier Hallade commented 2024-01-11 13:53:18 +01:00
Author
Member
Copy Link

Meteor Lake drivers need to be 101.4730, or 101.5125 or higher (not released yet as of today) for the generated binaries to be used, there are issues with 101.5122.

Meteor Lake drivers need to be 101.4730, or 101.5125 or higher (not released yet as of today) for the generated binaries to be used, there are issues with 101.5122.
Xavier Hallade changed title from WIP: Cycles: build graphics binaries for Meteor Lake iGPUs to Cycles: build graphics binaries for Meteor Lake iGPUs 2024-01-11 13:55:21 +01:00
Xavier Hallade force-pushed blender3.6meteor_lake from 287f12147b to e5c4ad2e06 2024-01-11 16:51:51 +01:00 Compare
Xavier Hallade requested review from Brecht Van Lommel 2024-01-12 21:37:08 +01:00
Brecht Van Lommel commented 2024-01-15 11:20:37 +01:00
Owner
Copy Link

@blender-bot build

@blender-bot build
Brecht Van Lommel commented 2024-01-15 17:45:24 +01:00
Owner
Copy Link

I didn't realize this would also require updating the precompiled libraries in 3.6, which I'm not sure I want to burden the platform maintainers with.

Though I can think we can just copy the binaries between svn branches. @ideasman42 @LazyDodo any objection to me doing that?

I didn't realize this would also require updating the precompiled libraries in 3.6, which I'm not sure I want to burden the platform maintainers with. Though I can think we can just copy the binaries between svn branches. @ideasman42 @LazyDodo any objection to me doing that?
Ray molenkamp commented 2024-01-15 20:46:15 +01:00
Member
Copy Link

we're not building IGC/ocloc on windows, as they just don't support it and we're forced to use their binary distro, so the builder side changes are essentially a no-op for windows.

We'd probably have to update our ocloc binary and see if it builds on the bots, but that's out of my hands.

we're not building IGC/ocloc on windows, as they just don't support it and we're forced to use their binary distro, so the builder side changes are essentially a no-op for windows. We'd probably have to update our ocloc binary and see if it builds on the bots, but that's out of my hands.
Brecht Van Lommel commented 2024-01-16 12:48:41 +01:00
Owner
Copy Link

Ah yes, I forgot. I would just be backporting the binaries for Linux then.

The ocloc binary was already updated for 4.1, this PR is just about backporting to 3.6 LTS.

Ah yes, I forgot. I would just be backporting the binaries for Linux then. The ocloc binary was already updated for 4.1, this PR is just about backporting to 3.6 LTS.
Philipp Oeser commented 2024-02-14 12:46:19 +01:00
Member
Copy Link

Just double-checking the status here:

  • are libraries in a state for 3.6 so that this could go in?
  • I see the linting failed, could this PR be updated so it is not failing?
Just double-checking the status here: - are libraries in a state for 3.6 so that this could go in? - I see the linting failed, could this PR be updated so it is not failing?
Xavier Hallade commented 2024-02-14 13:50:12 +01:00
Author
Member
Copy Link

the ocloc/IGC library should be in a state they could go in yes - @brecht can you backport the binaries?
It seems lint failed due to format differences from files that this PR hasn't touched, maybe a rebase will help, triggering it now.

the ocloc/IGC library should be in a state they could go in yes - @brecht can you backport the binaries? It seems lint failed due to format differences from files that this PR hasn't touched, maybe a rebase will help, triggering it now.
Xavier Hallade force-pushed blender3.6meteor_lake from e5c4ad2e06 to 731ff7721f 2024-02-14 13:50:58 +01:00 Compare
Philipp Oeser commented 2024-02-14 15:13:26 +01:00
Member
Copy Link

@blender-bot build

@blender-bot build
Brecht Van Lommel commented 2024-02-14 20:46:07 +01:00
Owner
Copy Link

I backported the Linux libraries. If this build passes, I think this PR can be merged.

@blender-bot package

The lint failures are unrelated I think.

I backported the Linux libraries. If this build passes, I think this PR can be merged. @blender-bot package The lint failures are unrelated I think.
Blender Bot commented 2024-02-14 20:46:14 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR117027) when ready.
Brecht Van Lommel approved these changes 2024-02-14 20:46:17 +01:00
Brecht Van Lommel added 1 commit 2024-02-15 00:28:32 +01:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
4c4d55f826 Merge branch 'blender-v3.6-release' into blender3.6meteor_lake
Brecht Van Lommel commented 2024-02-15 00:29:37 +01:00
Owner
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-02-15 00:29:56 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR117027) when ready.
Philipp Oeser commented 2024-02-15 10:29:05 +01:00
Member
Copy Link

OK, still curious why linter failed here (it wasnt for my backports to the 3.6 branch yesterday) -- and cannot make much out of the somewhat cryptic error message...

OK, still curious why linter failed here (it wasnt for my backports to the 3.6 branch yesterday) -- and cannot make much out of the somewhat cryptic error message...
Philipp Oeser commented 2024-02-15 10:48:54 +01:00
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-02-15 10:50:08 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR117027) when ready.
Brecht Van Lommel manually merged commit b2d628cf27 into blender-v3.6-release 2024-02-15 17:43:13 +01:00
Philipp Oeser commented 2024-02-15 19:52:31 +01:00
Member
Copy Link

Again: thank you @brecht taking care here (was caught up with our module-marathon- meeting today)

Again: thank you @brecht taking care here (was caught up with our module-marathon- meeting today)
Sign in to join this conversation.
Reviewers
No reviewers
Brecht Van Lommel
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117027
No description provided.
Delete Branch "xavierh/blender:blender3.6meteor_lake"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?