Fix #109771: deps_builder: crash in Embree HW BVH building #109966

Merged
Xavier Hallade merged 1 commits from xavierh/blender:embree_arena_fix_main into main 2023-07-19 19:40:01 +02:00
Member

When an offline render was done side by side render preview, further
render preview updates requiring BVH to be rebuilt would trigger a
crash.
This will be fixed upstream the same way in Embree 4.2.

When an offline render was done side by side render preview, further render preview updates requiring BVH to be rebuilt would trigger a crash. This will be fixed upstream the same way in Embree 4.2.
Xavier Hallade added this to the 4.0 milestone 2023-07-11 14:48:57 +02:00
Xavier Hallade added the
Interest
Render & Cycles
label 2023-07-11 14:48:57 +02:00
Xavier Hallade added 1 commit 2023-07-11 14:49:09 +02:00
1119257760 Fix #109771: deps_builder: crash in Embree HW BVH building
When an offline render was done side by side render preview, further
render preview updates requiring BVH to be rebuilt would trigger a
crash.
This will be fixed upstream the same way in Embree 4.2.
Xavier Hallade added this to the Render & Cycles project 2023-07-11 14:49:16 +02:00
Xavier Hallade requested review from Ray molenkamp 2023-07-11 15:01:05 +02:00
Xavier Hallade requested review from Brecht Van Lommel 2023-07-11 15:01:14 +02:00
Author
Member

@LazyDodo @ideasman42 this fix means a rebuild of the embree library on Windows and Linux.

@LazyDodo @ideasman42 this fix means a rebuild of the embree library on Windows and Linux.
Brecht Van Lommel approved these changes 2023-07-11 18:09:45 +02:00
Member

how far off is 4.2? and how important is it to fix this bug asap?

how far off is 4.2? and how important is it to fix this bug asap?
Author
Member

4.2 is for July 20nd according to https://github.com/embree/embree/issues/453
But it has more changes than just this fix, I haven't tested it enough from blender to recommend it yet, I feel it's safer to just patch it up at this stage, for 3.6 LTS at least.
Regarding the importance - you're the judge - the workflow the issue kicks in seems common enough to be faced by many users.

4.2 is for July 20nd according to https://github.com/embree/embree/issues/453 But it has more changes than just this fix, I haven't tested it enough from blender to recommend it yet, I feel it's safer to just patch it up at this stage, for 3.6 LTS at least. Regarding the importance - you're the judge - the workflow the issue kicks in seems common enough to be faced by many users.
Ray molenkamp approved these changes 2023-07-11 19:25:48 +02:00
Ray molenkamp left a comment
Member

ok then, was hoping to ride it out till 4.2 , but you make a good point about 3.6 LTS it'll need this fix regardless

ok then, was hoping to ride it out till 4.2 , but you make a good point about 3.6 LTS it'll need this fix regardless
Author
Member

@LazyDodo how do we land it for 4.0 and 3.6? I do source and ask for it to get backported to 3.6 then you handle deps builder or you do it all at once?

@LazyDodo how do we land it for 4.0 and 3.6? I do source and ask for it to get backported to 3.6 then you handle deps builder or you do it all at once?
Member

You can just land in main, then add it to #109399 , I'll update both #104895 and #109244 once the commits show up in their respective branches.

You can just land in main, then add it to #109399 , I'll update both #104895 and #109244 once the commits show up in their respective branches.
Xavier Hallade merged commit ece704af45 into main 2023-07-19 19:40:01 +02:00
Xavier Hallade deleted branch embree_arena_fix_main 2023-07-19 19:40:02 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109966
No description provided.