Errors encountered when re-opening a .blend file with multiple library overrides with local parents #109993

Closed
opened 2023-07-12 06:19:22 +02:00 by Erik Scott · 7 comments

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 536.40

Blender Version
Broken: version: 3.6.0, branch: blender-v3.6-release, commit date: 2023-06-27 08:08, hash: c7fc78b81ecb
Worked: never to my knowledge (also broken in 3.5.1)

Short description of error
Project saved with two library overrides of the same linked asset. The parent object of both overrides was made local so it could be renamed and drivers added to custom properties. Upon re-opening the .blend file, some (all but one?) of the parent objects was no longer local, stuck at the origin, and the parent-child relationship as no longer properly reflected in the outliner.

Exact steps for others to reproduce the error
Please see the attached LibraryOverrideError.zip file. It contains an example of a messed-up file (CombinedFile.blend) and a file for reproducing the error (CombinedFileStarter.blend). There is also an assets folder which contains various assets to be linked in and made into library overrides.

Detailed Steps:

  1. Open default scene
  2. Go to File > Link. Navigate to assets > GenericComponents.blend > Collection > VECTOR_INDICATOR and click "Link"
  3. In the 3d viewport, click Object > Library Override > Make.
  4. Select the FORCE_INDICATOR_PARENT empty.
  5. Localize the empty so that it can be renamed: in the properties panel in the object tab, click the chain-arrow icon next to the object name to create a local version and rename it to "left" (exact name is not necessary to re-produce the error).
  6. Make sure the "left" empty is selected and Ctrl-click the cube
  7. Press Ctrl-P and select "Object (Without Inverse)". (make cube object parent)
  8. Move the "left" empty to another position (X = -5)
  9. Repeat steps 2 through 8 with another VECTOR_INDICATOR. When re-naming the parent empty, name it "right", and the intended position(X = 5)
  10. Save the file and close Blender.
  11. Re-open the file and observe the outliner. Notice that one of the parent empties (either wing_rt or wing lt) has been renamed back to FORCE_INDICATOR_PARENT.001. It is no longer local, and the child objects are no longer appear as childern under it in the outliner (despite still being children). The parent has been re-positioned back to the global origin, and is no-longer parented to the airframe_axes object. It cannot be moved, rotated, or scaled.

Some of these steps probably aren't strictly necessary. However, this is a simplified version of the situation in which I encountered this issue and I felt it was important to retain the context for the purposes of reproducibility and to demonstrate the error within a specific workflow.

Workarounds
Appending the asset works fine, as it keeps everything local to the file. Unfortunately, this defeats the pointed of having a remote asset that can be re-used and updated across multiple places.

I have attempted a workaround in which I don't make the parent object local. Instead, I would create a super-parent (named "wing_lt", for instance) and give it custom properties. The custom properties of the original linked parent would then be driven by the super parent's properties using drives. Unfortunately, the custom properties of a library override cannot use drivers (even ones marked "library overridable").

Other thoughts
Simply allowing drivers in the custom properties of a library override would go a long way towards making linked rigs work well. Alternatively, a way to add an "interface" of custom properties to linked assets without having to create overrides would be huge benefit to my intended use case and workflow.

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 536.40 **Blender Version** Broken: version: 3.6.0, branch: blender-v3.6-release, commit date: 2023-06-27 08:08, hash: `c7fc78b81ecb` Worked: never to my knowledge (also broken in 3.5.1) **Short description of error** Project saved with two library overrides of the same linked asset. The parent object of both overrides was made local so it could be renamed and drivers added to custom properties. Upon re-opening the .blend file, some (all but one?) of the parent objects was no longer local, stuck at the origin, and the parent-child relationship as no longer properly reflected in the outliner. **Exact steps for others to reproduce the error** Please see the attached LibraryOverrideError.zip file. It contains an example of a messed-up file (CombinedFile.blend) and a file for reproducing the error (CombinedFileStarter.blend). There is also an assets folder which contains various assets to be linked in and made into library overrides. Detailed Steps: 1. Open default scene 2. Go to File > Link. Navigate to assets > GenericComponents.blend > Collection > VECTOR_INDICATOR and click "Link" 3. In the 3d viewport, click Object > Library Override > Make. 4. Select the FORCE_INDICATOR_PARENT empty. 5. Localize the empty so that it can be renamed: in the properties panel in the object tab, click the chain-arrow icon next to the object name to create a local version and rename it to "left" (exact name is not necessary to re-produce the error). 6. Make sure the "left" empty is selected and Ctrl-click the cube 7. Press Ctrl-P and select "Object (Without Inverse)". (make cube object parent) 8. Move the "left" empty to another position (X = -5) 9. Repeat steps 2 through 8 with another VECTOR_INDICATOR. When re-naming the parent empty, name it "right", and the intended position(X = 5) 10. Save the file and close Blender. 11. Re-open the file and observe the outliner. Notice that one of the parent empties (either wing_rt or wing lt) has been renamed back to FORCE_INDICATOR_PARENT.001. It is no longer local, and the child objects are no longer appear as childern under it in the outliner (despite still being children). The parent has been re-positioned back to the global origin, and is no-longer parented to the airframe_axes object. It cannot be moved, rotated, or scaled. Some of these steps probably aren't strictly necessary. However, this is a simplified version of the situation in which I encountered this issue and I felt it was important to retain the context for the purposes of reproducibility and to demonstrate the error within a specific workflow. **Workarounds** Appending the asset works fine, as it keeps everything local to the file. Unfortunately, this defeats the pointed of having a remote asset that can be re-used and updated across multiple places. I have attempted a workaround in which I don't make the parent object local. Instead, I would create a super-parent (named "wing_lt", for instance) and give it custom properties. The custom properties of the original linked parent would then be driven by the super parent's properties using drives. Unfortunately, the custom properties of a library override cannot use drivers (even ones marked "library overridable"). **Other thoughts** Simply allowing drivers in the custom properties of a library override would go a long way towards making linked rigs work well. Alternatively, a way to add an "interface" of custom properties to linked assets without having to create overrides would be huge benefit to my intended use case and workflow.
Erik Scott added the
Type
Report
Status
Needs Triage
Priority
Normal
labels 2023-07-12 06:19:23 +02:00
Member

Thanks for the report. Can confirm even when I link the object data in default scene. (updated the report accordingly)

It is no longer local, and the child objects are no longer appear as childern under it in the outliner (despite still being children)

After reopening the file, no user has detected for some overridden objects.
I'm not sure about the cause. Maybe @mont29 have an idea? (want me to simplify this issue further?)

Thanks for the report. Can confirm even when I link the object data in default scene. (updated the report accordingly) > It is no longer local, and the child objects are no longer appear as childern under it in the outliner (despite still being children) After reopening the file, no user has detected for some overridden objects. I'm not sure about the cause. Maybe @mont29 have an idea? (want me to simplify this issue further?)
Pratik Borhade added
Status
Needs Info from Developers
Interest
Overrides
and removed
Status
Needs Triage
labels 2023-07-12 08:30:02 +02:00

I cannot reproduce with current main, may very well have been fixed by the this set of commits yesterday.

But please note that starting to make some part of an override hierarchy local is a very dangerous game, while supported in theory, you will most certainly run into issues in case there is some resync needed at some point (i.e. if your library/asset data is updated in some ways that affect relationships between IDs).

Also, adding drivers to overrides should not be a problem, as long as they do not have any animation data in their linked reference.

I cannot reproduce with current main, may very well have been fixed by the [this set of commits](https://projects.blender.org/blender/blender/compare/f2d3d321bbffc745232f23519019cb0a585055ab...d2c87c32816925ef3f250d96aee42a1527e04da7) yesterday. But please note that starting to make some part of an override hierarchy local is a very dangerous game, while supported in theory, you will most certainly run into issues in case there is some resync needed at some point (i.e. if your library/asset data is updated in some ways that affect relationships between IDs). Also, adding drivers to overrides should not be a problem, as long as they do not have any animation data in their linked reference.
Member

Yes, fixed in current master. (I should have done this before 😅)
@erikscott128 , could you verify in 4.0 build?: https://builder.blender.org/download/daily/

Yes, fixed in current master. (I should have done this before 😅) @erikscott128 , could you verify in 4.0 build?: https://builder.blender.org/download/daily/
Pratik Borhade added
Status
Needs Information from User
and removed
Status
Needs Info from Developers
labels 2023-07-12 11:38:24 +02:00
Author

Thanks for the super-quick turn around on this! The error appears fixed on my end with the 4.0.0 alpha build.

@mont29 I understand that making part of a library override local is probably not best-practice. However, nearly all of my external assets utilize a number of drivers which I believe constitute animation data (even if no action is present). If it's just the presence of animation data that's blocking my ability to add drivers to an override's custom properties, I see that as a significant shortcoming. Is there some other preferred way to instance an external asset in such a way that it can be animated and either renamed or have drivers applied to properties (or both)? (Apologies if this is the wrong forum to ask these questions)

Thanks for the super-quick turn around on this! The error appears fixed on my end with the 4.0.0 alpha build. @mont29 I understand that making part of a library override local is probably not best-practice. However, nearly all of my external assets utilize a number of drivers which I believe constitute animation data (even if no action is present). If it's just the presence of animation data that's blocking my ability to add drivers to an override's custom properties, I see that as a significant shortcoming. Is there some other preferred way to instance an external asset in such a way that it can be animated and either renamed or have drivers applied to properties (or both)? (Apologies if this is the wrong forum to ask these questions)
Member

The error appears fixed on my end with the 4.0.0 alpha build.

Will close then :)
I'm not sure whether we can backport the fix

> The error appears fixed on my end with the 4.0.0 alpha build. Will close then :) I'm not sure whether we can backport the fix
Blender Bot added
Status
Archived
and removed
Status
Needs Information from User
labels 2023-07-13 07:20:09 +02:00

@erikscott128 in short: no. We do not support currently modifying existing animation data (at least when it comes to drivers). In existing animation data case, the only possible thing with liboverrides is to create or change the active action, or to edit the NLA (although within limits).

@erikscott128 in short: no. We do not support currently modifying existing animation data (at least when it comes to drivers). In existing animation data case, the only possible thing with liboverrides is to create or change the active action, or to edit the NLA (although within limits).

I'm not sure whether we backport the fix

The backport of the fixes is scheduled for 3.6.2 (see #109399, 3.3 will not get it). That way it has a few weeks of validation in Main first.

> I'm not sure whether we backport the fix The backport of the fixes is scheduled for 3.6.2 (see #109399, 3.3 will not get it). That way it has a few weeks of validation in Main first.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109993
No description provided.