Fix #111933: wrong rest position #111958

Jacques Lucke · 2023-09-05T10:24:25+02:00

Jacques Lucke commented

2023-09-05 10:24:25 +02:00

This was caused by 56659f1510.
The line added by this patch was added by the reverted 82ca3d3604, but should not have been reverted. It was not obvious enough that two different things were changed by the same patch.

This was caused by 56659f1510b1d8ab1345efa9d6e7ed6050476d68. The line added by this patch was added by the reverted 82ca3d3604bded96f72650c23a7f95f29b956f30, but should not have been reverted. It was not obvious enough that two different things were changed by the same patch.

Jacques Lucke added 1 commit 2023-09-05 10:24:39 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

c80121c0fc fix

Jacques Lucke requested review from Philipp Oeser 2023-09-05 10:25:06 +02:00

Jacques Lucke requested review from Hans Goudey 2023-09-05 10:25:06 +02:00

Philipp Oeser commented

2023-09-05 10:37:12 +02:00

@blender-bot build

Philipp Oeser commented

2023-09-05 11:10:49 +02:00

@blender-bot build

Philipp Oeser referenced this pull request

2023-09-05 12:55:50 +02:00

Blender LTS: Maintenance Task 3.6 #109399

Philipp Oeser commented

2023-09-05 13:02:21 +02:00

LGTM (but not familiar enough with that part of the code to give green light), but would wait for @HooglyBoogly approval, have added it to #109399 so it does not get lost

LGTM (but not familiar enough with that part of the code to give green light), but would wait for @HooglyBoogly approval, have added it to https://projects.blender.org/blender/blender/issues/109399 so it does not get lost

Hans Goudey approved these changes 2023-09-05 13:39:08 +02:00

Hans Goudey left a comment

Oops, thanks.

Demeter Dzadik commented

2023-09-06 00:46:23 +02:00

Hey guys, thanks a lot for the fix!

While this wasn't yet broken in 3.6.2, I'd really appreciate if the fix could be landed and back-ported to 3.6.3 before the film premiere on the 12th, because we aim to release the files then, and it would be sad if people downloaded some of the files with the current release candidate and it went all explodey.

(That said, the files are ofc not expected to work flawlessly in 4.0 and we'll put plenty of warnings about that everywhere.)

I hope that's doable, thanks!

Hey guys, thanks a lot for the fix! While this wasn't yet broken in 3.6.2, I'd really appreciate if the fix could be landed and back-ported to 3.6.3 before the film premiere on the 12th, because we aim to release the files then, and it would be sad if people downloaded some of the files with the current release candidate and it went all explodey. (That said, the files are ofc not expected to work flawlessly in 4.0 and we'll put plenty of warnings about that everywhere.) I hope that's doable, thanks!

Philipp Oeser commented

2023-09-06 09:03:34 +02:00

Hey guys, thanks a lot for the fix!

While this wasn't yet broken in 3.6.2, I'd really appreciate if the fix could be landed and back-ported to 3.6.3 before the film premiere on the 12th, because we aim to release the files then, and it would be sad if people downloaded some of the files with the current release candidate and it went all explodey.

(That said, the files are ofc not expected to work flawlessly in 4.0 and we'll put plenty of warnings about that everywhere.)

I hope that's doable, thanks!

LTS releases are usually in the third Tuesday of a month (that would be the 19th for 3.6.3), but I can put the fix in 3.6.3 RC, if that is enough?

See https://projects.blender.org/blender/blender/milestone/5

> Hey guys, thanks a lot for the fix! > > While this wasn't yet broken in 3.6.2, I'd really appreciate if the fix could be landed and back-ported to 3.6.3 before the film premiere on the 12th, because we aim to release the files then, and it would be sad if people downloaded some of the files with the current release candidate and it went all explodey. > > (That said, the files are ofc not expected to work flawlessly in 4.0 and we'll put plenty of warnings about that everywhere.) > > I hope that's doable, thanks! LTS releases are usually in the third Tuesday of a month (that would be the 19th for 3.6.3), but I can put the fix in 3.6.3 RC, if that is enough? See https://projects.blender.org/blender/blender/milestone/5

Demeter Dzadik commented

2023-09-06 11:16:37 +02:00

Yeah, that's what I meant, just for the few users who might be using the release candidate. (So tbf, probably the smallest userbase out of all the available versions, but still :3)

So that would be appreciated, thank you!

Yeah, that's what I meant, just for the few users who might be using the release candidate. (So tbf, probably the smallest userbase out of all the available versions, but still :3) So that would be appreciated, thank you!

Philipp Oeser merged commit 439e37466c into blender-v3.6-release

2023-09-06 13:26:43 +02:00

Philipp Oeser referenced this issue from a commit

2023-09-06 13:26:44 +02:00

Fix #111933: wrong rest position

Philipp Oeser deleted branch fix-rest-position

2023-09-06 13:26:47 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #111933: wrong rest position #111958