Crash when changing asset icon #106976

New Issue

Kent Davis · 2023-04-15T01:25:14+02:00

Kent Davis commented

2023-04-15 01:25:14 +02:00

Blender Version
Broken: version: 3.5
Worked: - (never, it is related to "All" which was introduced in 3.5)

Short description of error
Blender crash guide during ASSET open .png

Exact steps for others to reproduce the error

Set Interface > Temporary Editors > File Browser to open in maximized area
Mark cube as asset
Open Asset Browser
In side panel, change asset icon (any should do)

It will crash.

Note: It will only crash if library is "All".

**Blender Version** Broken: version: 3.5 Worked: - (never, it is related to "All" which was introduced in 3.5) **Short description of error** Blender crash guide during ASSET open .png **Exact steps for others to reproduce the error** * Set `Interface > Temporary Editors > File Browser` to open in maximized area * Mark cube as asset * Open Asset Browser * In side panel, change asset icon (any should do) It will crash. Note: It will only crash if library is "All".

Blender-2023-04-14-161822.ips

49 KiB

106976.blend

1.1 MiB

Kent Davis added the

labels 2023-04-15 01:25:15 +02:00

Kent Davis commented

2023-04-18 02:04:08 +02:00

@Harley
There

@Harley There

Pratik Borhade commented

2023-04-21 08:58:58 +02:00

Hi, thanks for the report. I'm not able to reproduce the crash.
Could you check again in latest build?: https://builder.blender.org/download/daily/
Does this happen with any other png file?

Call stack:
BKE_previewimg_id_custom_set
lib_id_load_custom_preview_exec(bContext*, wmOperator*)
wm_handler_fileselect_do(bContext*, ListBase*, wmEventHandler_Op*, int)
wm_handlers_do_intern(bContext*, wmWindow*, wmEvent*, ListBase*)
wm_handlers_do(bContext*, wmEvent*, ListBase*)
wm_event_do_handlers
WM_main
main

Hi, thanks for the report. I'm not able to reproduce the crash. Could you check again in latest build?: https://builder.blender.org/download/daily/ Does this happen with any other png file? ``` Call stack: BKE_previewimg_id_custom_set lib_id_load_custom_preview_exec(bContext*, wmOperator*) wm_handler_fileselect_do(bContext*, ListBase*, wmEventHandler_Op*, int) wm_handlers_do_intern(bContext*, wmWindow*, wmEvent*, ListBase*) wm_handlers_do(bContext*, wmEvent*, ListBase*) wm_event_do_handlers WM_main main ```

Kent Davis commented

2023-04-21 09:00:29 +02:00

@PratikPB2123
Yes still crash latest version build on Blender 3.6.0 today already. for Mac.

@PratikPB2123 Yes still crash latest version build on Blender 3.6.0 today already. for Mac.

Pratik Borhade commented

2023-04-21 09:04:37 +02:00

Ok, thanks for the update

Does this happen with any other png file?

Any updates on this?

Also check if crash happens with .png which is not a part of asset library.

Ok, thanks for the update > Does this happen with any other png file? Any updates on this? - - - Also check if crash happens with .png which is not a part of asset library.

Kent Davis commented

2023-04-21 09:17:57 +02:00

@PratikPB2123
Any PNG, JPG, and etc not matter.
Random select not matter still crash during open Asset button.
Open Folder button

@PratikPB2123 Any PNG, JPG, and etc not matter. Random select not matter still crash during open Asset button. Open Folder button ![image](/attachments/4914f58d-88ec-43f0-8a61-405ea2f58295)

2-Milk-Christian-salvation.jpg

424 KiB

734 KiB

204 KiB

16 KiB

218 KiB

image.png

21 KiB

02.jpg

171 KiB

HSS.png

178 KiB

Kent Davis commented

2023-04-21 09:20:35 +02:00

There crash file.

Blender-2023-04-21-001849.ips

48 KiB

Kent Davis commented

2023-04-21 09:39:32 +02:00

Other crash on latest version build.

Blender-2023-04-21-002941.ips

48 KiB

Pratik Borhade commented

2023-04-21 12:34:31 +02:00

Still unable to reproduce with local assets and your images.
Maybe irrelevant but could you check whether crash triggers with OpenGL backend?

Still unable to reproduce with local assets and your images. Maybe irrelevant but could you check whether crash triggers with OpenGL backend?

Pratik Borhade added

Status

Needs Information from User

and removed

Status

Needs Triage

labels 2023-04-21 12:37:15 +02:00

Kent Davis commented

2023-04-21 13:07:33 +02:00

I take test OpenGL and Metal also EEVEE and Cycles-x not matter what. Ignore about Metal, OpenGL and Cycles and EEVEE just very IGNORE. Only focus ASSET BROWSER Open Folder both not matter still CRASH!

I take test OpenGL and Metal also EEVEE and Cycles-x not matter what. Ignore about Metal, OpenGL and Cycles and EEVEE just very IGNORE. Only focus ASSET BROWSER Open Folder both not matter still CRASH! ![image](/attachments/3db0b60b-699a-4db7-a3b0-07e55cbcede2)

image.png

1.0 MiB

Kent Davis commented

2023-04-21 13:07:56 +02:00

Ask some one for Mac not for Windows.

Pratik Borhade commented

2023-04-21 13:21:32 +02:00

@mano-wii , can you check?

Pratik Borhade added

Status

Needs Triage

and removed

Status

Needs Information from User

labels 2023-04-21 13:21:43 +02:00

Germano Cavalcante commented

2023-04-21 18:16:19 +02:00

Let me see if I understood the problem correctly.
Any .blend file, any Asset.
The described problem should occur when trying to change the preview image of an asset.

If these are the steps, I can't replicate:

Let me see if I understood the problem correctly. Any .blend file, any Asset. The described problem should occur when trying to change the preview image of an asset. If these are the steps, I can't replicate: ![Apr-21-2023 13-15-01.gif](/attachments/fa61e876-6c9a-45a1-9755-5475940a74d1)

Apr-21-2023 13-15-01.gif

428 KiB

Kent Davis commented

2023-04-21 18:34:46 +02:00

@mano-wii
Are you sure your own iMac and other Macintosh?

@mano-wii Are you sure your own iMac and other Macintosh?

Germano Cavalcante commented

2023-04-21 18:40:51 +02:00

Maybe it's a problem with Macs with AMD.
@iss can you try?

My specs:

Operating system: macOS-13.2.1-arm64-arm-64bit 64 Bits
Graphics card: Metal API Apple M1 1.2

Maybe it's a problem with Macs with AMD. @iss can you try? My specs: ``` Operating system: macOS-13.2.1-arm64-arm-64bit 64 Bits Graphics card: Metal API Apple M1 1.2 ```

Kent Davis commented

2023-04-21 18:52:57 +02:00

Me Intel i5

Kent Davis commented

2023-04-21 19:11:58 +02:00

@PratikPB2123
@mano-wii

I just found out. Library > Application Support > Blender > 3.6 folder is active make crash during open folder Asset Browser.
Without 3.6 folder and Asset Browser open is fine.
You can try my 3.6 folder through Show from hidden ~/Library

@PratikPB2123 @mano-wii I just found out. Library > Application Support > Blender > 3.6 folder is active make crash during open folder Asset Browser. Without 3.6 folder and Asset Browser open is fine. You can try my 3.6 folder through Show from hidden ~/Library

3.6.zip

714 KiB

Kent Davis commented

2023-04-21 19:37:00 +02:00

userpref.blend make crash. Let's test some more.

userpref.blend make crash. Let's test some more. ![image](/attachments/dfbaaaf9-9fdf-4cc6-b19c-1dc16b649618)

image.png

494 KiB

Kent Davis commented

2023-04-22 01:23:08 +02:00

userpref.blend is very very sensitive crash when I setting special thing and ASSET Browser open folder and crash. I remove and resetting then crash after open folder. I try again until finally stop crash during asset open folder. I let you know.

Kent Davis commented

2023-04-22 01:41:47 +02:00

I FOUND OUT NOW!!! There is very bad crash!!! I am tell you.

I FOUND OUT NOW!!! There is very bad crash!!! I am tell you. ![image](/attachments/f2f0d3be-9849-49fa-82f8-10e1c6244537)

image.png

1.0 MiB

Kent Davis commented

2023-04-24 15:55:54 +02:00

@PratikPB2123
Please check last my picture Temporary Editors Maximized Area can cause crash within Asset Browser open folder.

@PratikPB2123 Please check last my picture Temporary Editors Maximized Area can cause crash within Asset Browser open folder.

Richard Antalik commented

2023-04-24 21:22:35 +02:00

Can't reproduce this issue.

Kent Davis commented

2023-04-24 21:58:10 +02:00

@iss
Why?

@iss Why?

Kent Davis commented

2023-05-17 01:59:56 +02:00

I ask you why? you never answer me back.

Richard Antalik commented

2023-05-20 05:18:34 +02:00

Why I can't reproduce the issue? I can't tell why. Most likely due to different hardware I use.

Kent Davis commented

2023-05-20 05:30:27 +02:00

Why I can't reproduce the issue? I can't tell why. Most likely due to different hardware I use.

Why not you need use Preferences:

==========
Temporary Editor:
Render In: Maximized Area
File Browser: Maximized Area
first
==========
Then go to Asset Browser
==========
Open folder icon button small one.
==========
Any .png and .jpg then click (Load Cust...) button make crash.

> Why I can't reproduce the issue? I can't tell why. Most likely due to different hardware I use. Why not you need use Preferences: 1. ========== Temporary Editor: Render In: Maximized Area File Browser: Maximized Area first ![image](/attachments/3bbf5338-8f0f-4886-a486-94463637ac6e) 2. ========== Then go to Asset Browser ![image](/attachments/41045d43-1ed9-4029-9be1-aa4fd2144688) 3. ========== Open folder icon button small one. ![image](/attachments/3e0c090b-973a-48fa-8206-9c2774540b80) 4. ========== Any .png and .jpg then click (Load Cust...) button make crash. ![image](/attachments/8bf6f674-78b8-4891-a959-29feaccf2039)

image.png

204 KiB

image.png

1.3 MiB

image.png

49 KiB

image.png

170 KiB

image.png

691 KiB

Richard Antalik commented

2023-05-23 05:52:31 +02:00

I have re-checked just in case, and I was able to reproduce now, so will confirm.

Richard Antalik changed title from ~~Blender crash guide during ASSET open .png~~ to Crash when changing asset icon

2023-05-23 05:56:27 +02:00

Richard Antalik added

and removed

labels 2023-05-23 05:57:45 +02:00

Kent Davis commented

2023-05-23 06:07:20 +02:00

Thanks

Dalai Felinto commented

2023-05-26 11:00:31 +02:00

This happens in 3.5 as well, not only 3.6 (and on Linux too by the way).
cc @JulianEisel

This happens in 3.5 as well, not only 3.6 (and on Linux too by the way). cc @JulianEisel

Dalai Felinto added

and removed

labels 2023-05-26 11:00:57 +02:00

Pratik Borhade commented

2023-05-26 11:18:42 +02:00

#108066 could be merged into this report if crash is platform independent

Dalai Felinto commented

2023-05-26 11:55:25 +02:00

The issue seems to be that CTX_data_pointer_get(C, "id") returns NULL when called from lib_id_load_custom_preview_exec in this case.

The issue seems to be that `CTX_data_pointer_get(C, "id")` returns NULL when called from `lib_id_load_custom_preview_exec` in this case.

Dalai Felinto commented

2023-05-26 11:56:27 +02:00

@PratikPB2123 it can be merged. Not sure how to do it in the new system to be honest.

👍 1

Dalai Felinto referenced this issue

2023-05-26 12:00:01 +02:00

Asset Browser: Crash when choose a custom icon #108066

Kent Davis commented

2023-05-26 12:05:53 +02:00

This happens in 3.5 as well, not only 3.6 (and on Linux too by the way).
cc @JulianEisel

Yes.

@PratikPB2123 Yes merge

Edit > Preferences and Add-ons Install is fine.
File > Open is fine.
Asset Browser open (Folder icon) CRASH
that why

Don't forget about this picture.

> This happens in 3.5 as well, not only 3.6 (and on Linux too by the way). > cc @JulianEisel Yes. @PratikPB2123 Yes merge Edit > Preferences and Add-ons Install is fine. File > Open is fine. Asset Browser open (Folder icon) CRASH that why ![image](/attachments/7aa943ef-f0ad-42db-a21c-964a8fa4ad2e) Don't forget about this picture.

image.png

153 KiB

👍 1

Pratik Borhade referenced this issue

2023-05-26 12:14:39 +02:00

Asset Browser: Crash when choose a custom icon #108066

Pratik Borhade commented

2023-05-26 12:26:59 +02:00

Not sure if this is a regression (I suspect this is affected by new "all" option).

Crash triggers when "all" is selected as asset preference
If file is a part of asset library, crash will happen with "user library" and "all" libraries
If "current file" library is selected, crash will not happen

Not sure if this is a regression (I suspect this is affected by new "all" option). - Crash triggers when "all" is selected as asset preference - If file is a part of asset library, crash will happen with "user library" and "all" libraries - If "current file" library is selected, crash will not happen

👍 1

Kent Davis commented

2023-05-26 13:06:03 +02:00

Not sure if this is a regression (I suspect this is affected by new "all" option).

Crash triggers when "all" is selected as asset preference

If file is a part of asset library, crash will happen with "user library" and "all" libraries

If "current file" library is selected, crash will not happen

No, Not talk about "ALL". I talk about "Maximized Area" cause Asset Browser open crash.

See youtube: https://youtu.be/r5gjmBsBvyc

> Not sure if this is a regression (I suspect this is affected by new "all" option). > - Crash triggers when "all" is selected as asset preference > - If file is a part of asset library, crash will happen with "user library" and "all" libraries > - If "current file" library is selected, crash will not happen No, Not talk about "ALL". I talk about "Maximized Area" cause Asset Browser open crash. See youtube: https://youtu.be/r5gjmBsBvyc

Dalai Felinto commented

2023-05-26 15:10:14 +02:00

Great finding @PratikPB2123, I updated the task description