Fix #109781: Linked datablocks are keyable #109813

Merged
Christoph Lendenfeld merged 3 commits from ChrisLend/blender:fix_lib_override_keyframes into main 2023-07-13 14:09:56 +02:00

Add a simple check when inserting keyframes to ensure the data is not linked

Add a simple check when inserting keyframes to ensure the data is not linked
Christoph Lendenfeld added the
Module
Animation & Rigging
label 2023-07-07 11:08:43 +02:00
Christoph Lendenfeld added 1 commit 2023-07-07 11:08:57 +02:00
Christoph Lendenfeld requested review from Sybren A. Stüvel 2023-07-07 11:18:32 +02:00
Sybren A. Stüvel reviewed 2023-07-07 14:50:54 +02:00
@ -1497,2 +1498,4 @@
}
if (!BKE_id_is_editable(bmain, id)) {
BKE_reportf(reports, RPT_ERROR, "ID block for %s is not editable", rna_path);

AFAIK in the UI it's only "data-block", not "ID" or "ID block".

Do you think BKE_reportf(reports, RPT_ERROR, "Data-block %s for %s is not editable", id->name+2, rna_path); would work? It doesn't say what kind the data-block is (hence the +2), but at least the name is explicit in the message.

AFAIK in the UI it's only "data-block", not "ID" or "ID block". Do you think `BKE_reportf(reports, RPT_ERROR, "Data-block %s for %s is not editable", id->name+2, rna_path);` would work? It doesn't say what kind the data-block is (hence the `+2`), but at least the name is explicit in the message.
Author
Member

I just used ID block because it was used a few lines above that as well
But I changed it to e.g. 'location' on Cube is not editable

I had tried your solution but Data-block Cube for location is not editable sounded a bit weird

I just used ID block because it was used a few lines above that as well But I changed it to e.g. `'location' on Cube is not editable` I had tried your solution but `Data-block Cube for location is not editable` sounded a bit weird

Yeah, yours is much better!

Yeah, yours is much better!
Author
Member

can I get a green tick on this then? :D

can I get a green tick on this then? :D
Christoph Lendenfeld added 1 commit 2023-07-07 15:19:11 +02:00
Sybren A. Stüvel approved these changes 2023-07-10 10:51:44 +02:00
Sybren A. Stüvel left a comment
Member

Of course you can get a green tick! Sorry for the delay!

Of course you can get a green tick! Sorry for the delay!

After landing, please add the commit to #100749 and #109399 as well so that it can be backported to 3.3 + 3.6 LTS.

After landing, please add the commit to #100749 and #109399 as well so that it can be backported to 3.3 + 3.6 LTS.
Christoph Lendenfeld added 1 commit 2023-07-13 14:08:39 +02:00
Christoph Lendenfeld merged commit babc650779 into main 2023-07-13 14:09:56 +02:00
Christoph Lendenfeld deleted branch fix_lib_override_keyframes 2023-07-13 14:09:58 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109813
No description provided.