blender
/
blender
130
398
Fork 572
Code Issues 6.2k Pull Requests 747 Projects 19 Wiki Activity

Cycles Light Linking #104972

New Issue
Open
opened 2023-02-20 15:14:56 +01:00 by Brecht Van Lommel · 0 comments
Brecht Van Lommel commented 2023-02-20 15:14:56 +01:00
Owner
Copy Link

Support to have a light to influence only a subset of objects in the scene.

Plan

This is implemented by having a collection per light, where only the objects in the collection are illuminated by that light. This is compatible with other software and USD, which makes interop easier.

It is also simpler in production, since lights tend to be different for each shot and can be easily modified, whereas the linking being on the receivers or their materials would require heavy use of overrides in every shot.

This is however not the most convenient user interface, and a better UI is planned to be added after the initial implementation lands. This UI would have a global overview of all links in the scene, and allow viewing and editing both from the emitter -> receiver and receiver -> emitter points of view.

Cycles

  • Add object bitmask for receiving and emitting, light bitmask for emitting
  • Implement basic kernel side logic including for transparency, volumes, MIS
  • Build specialized light tree for every light set (#107561)
  • Shadow linking basic implementation (#106501)
  • Shadow linking with MIS (#107439)
  • Multiple lights on the ray path for shadow linking (#107739)
  • Mesh emitters for shadow linking (#107981)
  • Distant lights for shadow linking (#107979)
  • Clamping (try to make bounce same as for main path)
  • Path guiding: make recording consistent with main path (#108195)
  • Regression tests (#107964)
  • Optimizatons for dedicated light paths
    • Skip selecting random meshes that don't have matching light link set (#108091)
    • Dedicated intersection filter for selecting lights (scene intersection in shadow_linking_pick_mesh_intersection())
    • MNEE optimizations
  • Reduce memory usage for objects and lights when not using light linking
  • Reduce memory accesses and conditionals related to light linking
  • Hydra import

Blender

  • Light linking receiver collection on objects
  • A way to mark a member of the collection as inclusive or exclusive
  • Separate collections for light and shadow linking
  • Depsgraph implementation to compute bitmask from collections
    • Basic implementation
    • Optimize depsgraph to only weakly reference receiver objects and not evaluate them
  • Dynamic alloc LightLinking in DNA (#108090)
  • UI for easily adding scene collections and objects to the receiver collection
    • Drag-n-drop support of the objects and collections (#106101)
    • Operator to link selection to the active emitter
    • Change x next to list items to more standard - button next to list
    • Add + button next to list, with picker or using selected objects
    • Change light icon for exclude to checkbox (#112857)
    • Re-ordering of the light and shadow linking collections (#112849)
      • Ideally base on #107742
      • Short-term solution could be to use up/down buttons (similar Shapekey list)
  • Remove world and replace it by light object, that then supports linking
  • User interface with overview of all light and shadow links in the scene, where it's possible to switch between emtiter and receiver centrics views
  • USD import and export support (see USDLuxLightAPI.GetLightLinkCollectionAPI)
Support to have a light to influence only a subset of objects in the scene. * [User feedback topic](https://devtalk.blender.org/t/cycles-light-and-shadow-linking/29587) * Previous discussion: #68915 * [Implementation notes](https://wiki.blender.org/wiki/Reference/Release_Notes/4.0/Cycles) ### Plan This is implemented by having a collection per light, where only the objects in the collection are illuminated by that light. This is compatible with other software and USD, which makes interop easier. It is also simpler in production, since lights tend to be different for each shot and can be easily modified, whereas the linking being on the receivers or their materials would require heavy use of overrides in every shot. This is however not the most convenient user interface, and a better UI is planned to be added after the initial implementation lands. This UI would have a global overview of all links in the scene, and allow viewing and editing both from the emitter -> receiver and receiver -> emitter points of view. ### Cycles - [x] Add object bitmask for receiving and emitting, light bitmask for emitting - [x] Implement basic kernel side logic including for transparency, volumes, MIS - [x] Build specialized light tree for every light set (#107561) - [x] Shadow linking basic implementation (#106501) - [x] Shadow linking with MIS (#107439) - [x] Multiple lights on the ray path for shadow linking (#107739) - [x] Mesh emitters for shadow linking (#107981) - [x] Distant lights for shadow linking (#107979) - [x] Clamping (try to make `bounce` same as for main path) - [x] Path guiding: make recording consistent with main path (#108195) - [x] Regression tests (#107964) - [ ] Optimizatons for dedicated light paths - [x] Skip selecting random meshes that don't have matching light link set (#108091) - [ ] Dedicated intersection filter for selecting lights (scene intersection in `shadow_linking_pick_mesh_intersection()`) - [ ] MNEE optimizations - [ ] Reduce memory usage for objects and lights when not using light linking - [ ] Reduce memory accesses and conditionals related to light linking - [ ] Hydra import ### Blender - [x] Light linking receiver collection on objects - [x] A way to mark a member of the collection as inclusive or exclusive - [x] Separate collections for light and shadow linking - [ ] Depsgraph implementation to compute bitmask from collections - [x] Basic implementation - [ ] Optimize depsgraph to only weakly reference receiver objects and not evaluate them - [x] Dynamic alloc LightLinking in DNA (#108090) - [ ]UI for easily adding scene collections and objects to the receiver collection - [x] Drag-n-drop support of the objects and collections (#106101) - [x] Operator to link selection to the active emitter - [x] Change x next to list items to more standard - button next to list - [x] Add + button next to list, with picker or using selected objects - [x] Change light icon for exclude to checkbox (#112857) - [x] Re-ordering of the light and shadow linking collections (#112849) - Ideally base on #107742 - Short-term solution could be to use up/down buttons (similar Shapekey list) - [ ] Remove world and replace it by light object, that then supports linking - [ ] User interface with overview of all light and shadow links in the scene, where it's possible to switch between emtiter and receiver centrics views - [ ] USD import and export support (see `USDLuxLightAPI.GetLightLinkCollectionAPI`)
👀 5 ❤️ 16 🎉 8
Brecht Van Lommel added the
Module
Render & Cycles
 label 2023-02-20 15:14:56 +01:00
Brecht Van Lommel added this to the Render & Cycles project 2023-02-20 15:14:57 +01:00
Brecht Van Lommel locked as Off-topic and limited conversation to collaborators 2023-02-20 15:18:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
brush-assets-project
fix-121021
blender-v4.1-release
blender-v3.3-release
blender-v3.6-release
universal-scene-description
blender-v3.6-temp_wmoss_animrig_public
temp-sculpt-dyntopo
gpencil-next
anim/animation-id-113594
blender-v4.0-release
blender-projects-basics
bridge-curves
sculpt-blender
asset-browser-frontend-split
asset-shelf
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-v2.93-release
realtime-clock
sculpt-dev
bevelv2
xr-dev
v4.1.1
v3.6.11
v3.3.18
v4.1.0
v3.3.17
v3.6.10
v3.6.9
v3.3.16
v3.6.8
v3.6.7
v3.3.14
v4.0.2
v4.0.1
v4.0.0
v3.6.5
v3.3.12
v3.6.4
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Render & Cycles
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104972
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?