msgfmt: fix runtime requirements #105048

Ray molenkamp · 2023-02-21T20:48:46+01:00

Ray molenkamp commented

2023-02-21 20:48:46 +01:00

msgfmt has a TBB dependency though bf_blenlib, now for a release build
The MSVC linker is smart enough to realize none of the TBB code is
actually used and discards it. In debug mode the linker is a bit more
conservative and doesn't, leaving msgfmt with a runtime dependency
on TBB. The problem here is, we only copy the runtime dlls during
the install phase, and msgfmt runs long long before that.

For this reason when we run msgfmt we should make sure any runtime
needs it could have are met in the path, there already is a handy
variable for that since oslc has similar requirements.

msgfmt has a TBB dependency though bf_blenlib, now for a release build The MSVC linker is smart enough to realize none of the TBB code is actually used and discards it. In debug mode the linker is a bit more conservative and doesn't, leaving msgfmt with a runtime dependency on TBB. The problem here is, we only copy the runtime dlls during the install phase, and msgfmt runs long long before that. For this reason when we run msgfmt we should make sure any runtime needs it could have are met in the path, there already is a handy variable for that since oslc has similar requirements.

Ray molenkamp added 1 commit 2023-02-21 20:49:00 +01:00

buildbot/vexp-code-patch-coordinator Build done. Details

61ff65b567 msgfmt: fix runtime requirements

msgfmt has a TBB dependency though bf_blenlib, now for a release build
The MSVC linker is smart enough to realize none of the TBB code is
actually used and discards it. In debug mode the linker is a bit more
conservative and doesn't, leaving msgfmt with a runtime dependency
on TBB. The problem here is, we only copy the runtime dlls during
the install phase, and msgfmt runs long long before that.

For this reason when we run msgfmt we should make sure any runtime
needs it could have are met in the path, there already is a handy
variable for that since oslc has similar requirements.

Ray molenkamp commented

2023-02-21 20:50:28 +01:00

https://builder.blender.org/admin/#/builders/136/builds/582
https://builder.blender.org/admin/#/builders/136/builds/583

https://builder.blender.org/admin/#/builders/136/builds/582 https://builder.blender.org/admin/#/builders/136/builds/583

Ray molenkamp commented

2023-02-21 22:58:28 +01:00

The test failure is unrelated, just shows because it's a debug build, msgfmt ran fine so i'm ignoring that result (but alerted hans to the failure regardless)

Ray molenkamp added 1 commit 2023-02-21 22:59:06 +01:00

3f0a4cbd28 Merge branch 'main' into tmp_msgfmt_fix

Ray molenkamp merged commit b874a0ead8 into main

2023-02-21 23:00:45 +01:00

Ray molenkamp deleted branch tmp_msgfmt_fix

2023-02-21 23:00:46 +01:00

Ray molenkamp referenced this issue from a commit

2023-02-21 23:00:46 +01:00

msgfmt: fix runtime requirements

Ray molenkamp referenced this issue from a commit

2023-03-05 01:39:57 +01:00

msgfmt: fix runtime requirements