Move to Nodes does not work if the node tree has no Geometry input or output #106257

Closed
opened 2023-03-29 07:52:19 +02:00 by Sun Kim · 3 comments
Contributor

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: Radeon RX 570 Series ATI Technologies Inc. 4.5.0 Core Profile Context 23.3.2.230315

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-03-27 23:56, hash: 16576beb222a
Worked: n/a

Move to Nodes operator is introduced in 3.5.

Short description of error
Move to Nodes operator does not work if Geometry Nodes has no geometry input or output.

Error:

Python: Traceback (most recent call last):
  File "C:\Program Files (x86)\Steam\steamapps\common\Blender\3.6\scripts\startup\bl_operators\geometry_nodes.py", line 189, in execute
    group.links.new(first_geometry_output, group_output_node.inputs[data_("Geometry")])
TypeError: NodeLinks.new(): error with argument 1, "input" -  Function.input does not support a 'None' assignment NodeSocket type

If the operator should not work in this case, it's missing proper error message and documentation for it.

Exact steps for others to reproduce the error

  • From startup file, add Geometry Nodes to the cube
  • From node editor, go to Sidebar > Group, and remove either Geometry input or output
  • From modifier panel, select Move to Nodes

MovetoNodes.png

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: Radeon RX 570 Series ATI Technologies Inc. 4.5.0 Core Profile Context 23.3.2.230315 **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-03-27 23:56, hash: `16576beb222a` Worked: n/a Move to Nodes operator is introduced in 3.5. **Short description of error** `Move to Nodes` operator does not work if Geometry Nodes has no geometry input or output. Error: ``` Python: Traceback (most recent call last): File "C:\Program Files (x86)\Steam\steamapps\common\Blender\3.6\scripts\startup\bl_operators\geometry_nodes.py", line 189, in execute group.links.new(first_geometry_output, group_output_node.inputs[data_("Geometry")]) TypeError: NodeLinks.new(): error with argument 1, "input" - Function.input does not support a 'None' assignment NodeSocket type ``` If the operator should not work in this case, it's missing proper error message and documentation for it. **Exact steps for others to reproduce the error** - From startup file, add Geometry Nodes to the cube - From node editor, go to `Sidebar > Group`, and remove either Geometry input or output - From modifier panel, select Move to Nodes ![MovetoNodes.png](/attachments/3d86312d-cc44-4b4f-93b6-06cd55545d44)
Sun Kim added the
Severity
Normal
Type
Report
Status
Needs Triage
labels 2023-03-29 07:52:20 +02:00
Hans Goudey added the
Meta
Good First Issue
label 2023-03-29 20:10:57 +02:00

If no one else is working on this, could I take it as my first issue?

If no one else is working on this, could I take it as my first issue?

@Elena-Peng Hey, of course

@Elena-Peng Hey, of course
Contributor

There is a difference between removing Geometry input/output from Sidebar > Group and removing input/output nodes in Node Editor.
Actually, removing input/output nodes directory has no problem because input/output geometries are still saved in group input/output. However, removing group input/output makes this issue.

As @persun says, I think correct error handling and documentation is needed, and I'll work on it.

There is a difference between removing Geometry input/output from `Sidebar > Group` and removing input/output nodes in Node Editor. Actually, removing input/output nodes directory has no problem because input/output geometries are still saved in group input/output. However, removing group input/output makes this issue. As @persun says, I think correct error handling and documentation is needed, and I'll work on it.
Blender Bot added
Status
Resolved
and removed
Status
Confirmed
labels 2023-08-02 14:00:41 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
glTF
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106257
No description provided.