Add constraints executing Move to Nodes #104529

Hyu Ogawa · 2023-08-01T05:57:57+02:00

Hyu Ogawa commented

2023-08-01 05:57:57 +02:00

documentation fix for blender/blender#106257

Move to Nodes needs input and output but it is not written.

documentation fix for https://projects.blender.org/blender/blender/issues/106257 `Move to Nodes` needs input and output but it is not written.

Hyu Ogawa added 1 commit 2023-08-01 05:57:59 +02:00

bd1c43d5d5 Add constraints executing Move to Nodes

Aaron Carlisle requested changes 2023-08-06 20:50:52 +02:00

manual/modeling/modifiers/generate/geometry_nodes.rst Outdated

						
				@ -78,3 +78,3 @@

				Creates a new geometry node tree with the name of the current node tree with `.wrapper` appended to the name.

				This operation moves all inputs and outputs from the old modifier into a new node group.

				This operation moves all inputs and outputs from the old modifier into a new node group, ensuring that group inputs and group outputs have one or more geometry.

Aaron Carlisle commented

2023-08-06 20:50:49 +02:00

The following sound clearer in my opinion:

This operation moves all inputs and outputs from the old modifier into a new node group.
In order for this operator to function there **must** be a Group Input **and** a Group Output node.

The following sound clearer in my opinion: ``` This operation moves all inputs and outputs from the old modifier into a new node group. In order for this operator to function there **must** be a Group Input **and** a Group Output node. ```

👍 1

Hyu Ogawa commented

2023-08-07 00:57:47 +02:00

@Blendify Thank you for reviewing. I think it's better!
But I think it should not be Group output node, should be Group output geometry, I commited using geometry with your review.
Would you re-review again?

@Blendify Thank you for reviewing. I think it's better! But I think it should not be `Group output node`, should be `Group output geometry`, I commited using `geometry` with your review. Would you re-review again?

Hyu Ogawa added 1 commit 2023-08-07 00:55:11 +02:00

47b116119d fix: improve description with review in Move to Nodes

Hyu Ogawa requested review from Aaron Carlisle 2023-08-07 00:57:52 +02:00

Aaron Carlisle added 1 commit 2023-08-07 02:08:29 +02:00

ef4535ee46 Clarify that the group inputs must have a geometry "socket"

Aaron Carlisle approved these changes 2023-08-07 02:08:38 +02:00

Aaron Carlisle merged commit fb8824a7bf into main

2023-08-07 02:08:45 +02:00

Aaron Carlisle referenced this issue from a commit

2023-08-07 02:09:15 +02:00

Add constraints executing Move to Nodes

Sign in to join this conversation.