Regression: Optimal display for subdivision does not work when there's other modifier after that #106289

New Issue

Closed

opened 2023-03-30 04:31:04 +02:00 by Sun Kim · 4 comments

Sun Kim commented

2023-03-30 04:31:04 +02:00

Contributor

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: Radeon RX 570 Series ATI Technologies Inc. 4.5.0 Core Profile Context 23.3.2.230315

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-03-28 14:33, hash: 8d16e8f7261b
Worked: version: 3.5.0 Alpha, branch: main, commit date: 2023-02-09 01:29, hash: 3c8f7b1a641e

Caused by 7ca651d182

Short description of error
Optimal display for subdivision modifier does not work when there's other modifier after that.

For example, put Mirror modifier after Subdivision modifier.

Working	Broken

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: Radeon RX 570 Series ATI Technologies Inc. 4.5.0 Core Profile Context 23.3.2.230315 **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-03-28 14:33, hash: `8d16e8f7261b` Worked: version: 3.5.0 Alpha, branch: main, commit date: 2023-02-09 01:29, hash: `3c8f7b1a641e` Caused by 7ca651d18274acacfe8e0ecb7bc6fdd3399ea01b **Short description of error** Optimal display for subdivision modifier does not work when there's other modifier after that. For example, put Mirror modifier after Subdivision modifier. | Working | Broken | | -------- | -------- | | ![OptimalDisplay.png](/attachments/100e3b2e-1b8f-4bfa-8efa-27d942a50890) | ![OptimalDisplayBroken.png](/attachments/90638cad-f063-47b3-b4f9-db9149d92399) |

OptimalDisplay.png

191 KiB

OptimalDisplayBroken.png

209 KiB

Sun Kim added the

labels 2023-03-30 04:31:05 +02:00

Pratik Borhade commented

2023-03-30 06:40:47 +02:00

Member

Hi, thanks for the report. I can confirm.

Hi, thanks for the report. I can confirm.

Pratik Borhade added

EEVEE & Viewport

and removed

labels 2023-03-30 06:41:10 +02:00

Pratik Borhade changed title from ~~Optimal display for subdivision does not work when there's other modifier after that~~ to Regression: Optimal display for subdivision does not work when there's other modifier after that

2023-03-30 06:41:20 +02:00

Pratik Borhade referenced this issue

2023-03-30 06:42:06 +02:00

"optimal wireframe #106290

Pratik Borhade referenced this issue

2023-03-30 07:06:44 +02:00

blender not showing "optimal display" for wireframe if there is ANY active modifier under the subd modifier in 3.5 #106291

Pratik Borhade commented

2023-03-30 07:36:12 +02:00

Member

Caused by 7ca651d182
@HooglyBoogly ^

@persun, thanks for finding the closest good-bad commits :)

Caused by 7ca651d18274acacfe8e0ecb7bc6fdd3399ea01b @HooglyBoogly ^ - - - @persun, thanks for finding the closest good-bad commits :)

Hans Goudey commented

2023-03-30 13:49:57 +02:00

Member

This may not work in all of the cases it worked in before, but I can fix the mirror and array modifiers, at least when there is no merging.

This may not work in all of the cases it worked in before, but I can fix the mirror and array modifiers, at least when there is no merging.

Hans Goudey self-assigned this 2023-03-30 13:50:09 +02:00

Hans Goudey added

and removed

labels 2023-03-30 15:07:15 +02:00

Harley Acheson referenced this issue

2023-04-07 00:27:07 +02:00

Optimal display of subdiv. surface doesn´t work with boolean modifier #106647

Pratik Borhade referenced this issue

2023-04-07 06:21:53 +02:00

Optimal display of subdiv. surface doesn´t work with boolean modifier #106647

Hans Goudey commented

2023-04-16 21:42:17 +02:00

Member

The basic problem here is that "optimal display" is stored as a BitVector on meshes, which isn't automatically interpolated to the result mesh. Currently I think that's a good thing though; making the optimal display tag into an actual attribute means it's interpolated too much. So the best way to fix this is probably manually copying the bits into the result mesh's bit vector in a few modifiers/nodes. It would also be a bit weird to call this "optimal display" and then allocate a byte per subdivided mesh edge and interpolate it in later modifiers :/

To do that I'd like to implement MutableBitSpan::copy_from(BitSpan other).

Maybe making this into a generic attribute would be reasonable too. But then it has to be removed manually before some operations like dual mesh that really mess it up.

The basic problem here is that "optimal display" is stored as a `BitVector` on meshes, which isn't automatically interpolated to the result mesh. Currently I think that's a good thing though; making the optimal display tag into an actual attribute means it's interpolated _too_ much. So the best way to fix this is probably manually copying the bits into the result mesh's bit vector in a few modifiers/nodes. It would also be a bit weird to call this "optimal display" and then allocate a byte per subdivided mesh edge and interpolate it in later modifiers :/ To do that I'd like to implement `MutableBitSpan::copy_from(BitSpan other)`. Maybe making this into a generic attribute would be reasonable too. But then it has to be removed manually before some operations like dual mesh that really mess it up.

Hans Goudey referenced a pull request that will close this issue

2023-04-27 18:40:20 +02:00

BLI: Add bit span operations and bounded bit spans #107408

Hans Goudey closed this issue

2023-04-28 15:43:43 +02:00

Blender Bot added

and removed

labels 2023-04-28 15:43:44 +02:00

Hans Goudey referenced this issue from a commit

2023-04-28 16:06:13 +02:00

Fix #106289: Copy optimal display edges in mirror, array modifiers

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106289

No description provided.