Operators in vertexpaint and weightpaint (incl. the gradient tool) affect hidden (in editmode) parts of the mesh #106354

New Issue

Closed

opened 2023-03-31 04:36:17 +02:00 by 刘文博 · 11 comments

刘文博 commented

2023-03-31 04:36:17 +02:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 528.24

Blender Version
Broken: version: 3.3.5, branch: master, commit date: 2023-03-20 10:19, hash: dd0cd1df1d1a
Worked: (newest version of Blender that worked as expected)

Short description of error
When not using paintmask, Weight gradient tool in weight paint affects the hidden parts of mesh, while using brush to paint doesn't.
Editmode hiding was only respected (when not using paintmask) since e3801a2bd4 [which also made it so PBVH drawing strokes does not at on hidden geo -- but left out other operators]

This is also true for many other operators in vertexpaint and weightpaint as well btw., as opposed to painting stokes [PBVH respects the BM_ELEM_HIDDEN flag, so that is fine], many operators act on hidden (in editmode) geometry when not using paintmask (e.g. Weights > Invert or Paint > Invert)

Note: this breaks the principle of "only edit visible stuff"
Note: imagepaint otoh still does not respect editmode hiding

Exact steps for others to reproduce the error
1 add 2 cylinders in a single mesh object
2 hide part of mesh in editmode
3 use the gradient tool (it will affect hidden parts of the mesh)

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 528.24 **Blender Version** Broken: version: 3.3.5, branch: master, commit date: 2023-03-20 10:19, hash: `dd0cd1df1d1a` Worked: (newest version of Blender that worked as expected) **Short description of error** When not using paintmask, Weight gradient tool in weight paint affects the hidden parts of mesh, while using brush to paint doesn't. Editmode hiding was only respected (when not using paintmask) since e3801a2bd417b63f8b30c4c2dfa19b2efdbf9ce7 [which also made it so PBVH drawing strokes does not at on hidden geo -- but left out other operators] This is also true for many other operators in vertexpaint and weightpaint as well btw., as opposed to painting stokes [PBVH respects the BM_ELEM_HIDDEN flag, so that is fine], many operators act on hidden (in editmode) geometry when not using paintmask (e.g. `Weights` > `Invert` or `Paint` > `Invert`) Note: this breaks the principle of "only edit visible stuff" Note: imagepaint otoh still does not respect editmode hiding **Exact steps for others to reproduce the error** 1 add 2 cylinders in a single mesh object 2 hide part of mesh in editmode 3 use the gradient tool (it will affect hidden parts of the mesh)

22 MiB

刘文博 added the

labels 2023-03-31 04:36:18 +02:00

Iliya Katushenock added the

Sculpt, Paint & Texture

labels 2023-03-31 08:30:19 +02:00

YimingWu commented

2023-03-31 09:04:50 +02:00

Member

Looks like this is indeed a inconsistency. Using brush to paint weights doesn't affect hidden meshes while using gradient does.

Looks like this is indeed a inconsistency. Using brush to paint weights doesn't affect hidden meshes while using gradient does.

Philipp Oeser commented

2023-03-31 09:29:52 +02:00

Member

Can confirm, will check

Can confirm, will check

Philipp Oeser added

Animation & Rigging

and removed

labels 2023-03-31 09:30:29 +02:00

Philipp Oeser added

Sculpt, Paint & Texture

and removed

Sculpt, Paint & Texture

labels 2023-03-31 09:57:01 +02:00

刘文博 commented

2023-03-31 12:06:49 +02:00

Author

Looks like this is indeed a inconsistency. Using brush to paint weights doesn't affect hidden meshes while using gradient does.

I konw that but I wish the gradient tool have the same effect as brush.

> Looks like this is indeed a inconsistency. Using brush to paint weights doesn't affect hidden meshes while using gradient does. I konw that but I wish the gradient tool have the same effect as brush.

Philipp Oeser commented

2023-03-31 12:11:37 +02:00

Member

This is also true for many other operators in vertexpaint and weightpaint as well btw., as opposed to painting stokes [PBVH respects the BM_ELEM_HIDDEN flag, so that is fine], many operators act on hidden (in editmode) geometry when not using paintmask (e.g. Weights > Invert or Paint > Invert)

This is also true for many other operators in vertexpaint and weightpaint as well btw., as opposed to painting stokes [PBVH respects the BM_ELEM_HIDDEN flag, so that is fine], many operators act on hidden (in editmode) geometry when not using paintmask (e.g. `Weights` > `Invert` or `Paint` > `Invert`)

Philipp Oeser changed title from ~~Why gradient tool in weight paint affects the hidden parts of mesh?~~ to Operators in vertexpaint and weightpaint (incl. the gradient tool) affect hidden (in editmode) parts of the mesh

2023-03-31 12:34:42 +02:00

YimingWu commented

2023-03-31 14:02:41 +02:00

Member

Yeah I have experiences on other modifiers doing this kind of thing as well, not sure if these are all bugs or if there's any design incentives to it (I doubt).

Yeah I have experiences on other modifiers doing this kind of thing as well, not sure if these are all bugs or if there's any design incentives to it (I doubt).

Philipp Oeser commented

2023-03-31 14:10:20 +02:00

Member

Yeah I have experiences on other modifiers doing this kind of thing as well, not sure if these are all bugs or if there's any design incentives to it (I doubt).

Modifiers in editmode you mean? Got an example?
Or do you mean operators?

> Yeah I have experiences on other modifiers doing this kind of thing as well, not sure if these are all bugs or if there's any design incentives to it (I doubt). Modifiers in editmode you mean? Got an example? Or do you mean operators?

YimingWu commented

2023-03-31 15:09:19 +02:00

Member

Oh I mean operator, just typed it wrong.

Oh I mean operator, just typed it wrong.

Philipp Oeser commented

2023-03-31 15:36:40 +02:00

Member

Which operators? (might look into something that respects it for all appropriate operators)

Which operators? (might look into something that respects it for all appropriate operators)

YimingWu commented

2023-04-01 07:35:37 +02:00

Member

@lichtwerk OK I remembered, it's not exactly "hidden" surfaces, but if you enablesback face culling, sculpting brushes would still affect back face which looks really weird.

Considering back face culling is done naturally on the GPU, this particular bug (for sculpting) might not be easy to solve, it's gonna be a different thing than this issue.

@lichtwerk OK I remembered, it's not exactly "hidden" surfaces, but if you enablesback face culling, sculpting brushes would still affect back face which looks really weird. Considering back face culling is done naturally on the GPU, this particular bug (for sculpting) might not be easy to solve, it's gonna be a different thing than this issue.

YimingWu referenced a pull request that will close this issue

2023-04-01 08:07:06 +02:00

Fix #106354: Account for hidden vertices in weight gradient operator #106417

Philipp Oeser commented

2023-04-03 10:20:44 +02:00

Member

Will have a look into this (both making imagepaint consistent as well as have all relevant operators respect the hidden state -- after talking in chat, this seems to have consensus amongst painting and animation artists)

Will have a look into this (both making imagepaint consistent as well as have all relevant operators respect the hidden state -- after talking in chat, this seems to have consensus amongst painting and animation artists)

Philipp Oeser self-assigned this 2023-04-03 10:21:15 +02:00

Philipp Oeser referenced this issue

2023-04-03 16:42:50 +02:00

Fix #106354: Account for hidden vertices in weight gradient operator #106417

Philipp Oeser referenced this issue

2023-04-04 13:44:02 +02:00

Texture Paint: always respect edit mode hiding #106544

Philipp Oeser commented

2023-04-04 13:46:21 +02:00

Member

A PR for Texture Paint: always respect edit mode hiding on faces is in #106544

A PR for `Texture Paint: always respect edit mode hiding on faces` is in #106544

Philipp Oeser referenced this issue from a commit

2023-04-06 09:28:37 +02:00

Texture Paint: always respect edit mode hiding

YimingWu referenced this issue from a commit

2023-05-02 09:05:34 +02:00

Fix #106354: Account for hidden vertices in weight gradient operator

YimingWu closed this issue

2023-05-02 09:05:35 +02:00

Blender Bot added

and removed

labels 2023-05-02 09:05:37 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106354

No description provided.