Fix #106354: Account for hidden vertices in weight gradient operator #106417
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#106417
Loading…
Reference in New Issue
No description provided.
Delete Branch "ChengduLittleA/blender:weight_grad_fix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Weight gradient operator didn't respect hidden vertices. Now fixed.
Nice improvement, but this will crash when there is no
.hide_vert
attribute. Also, the custom data lookup should happen once rather than for every index.I see, thanks!
It's inside the callback, so I guess I'll check before this is called and store the array inside
WPGradient_userData
to make it available inside the callback.67acbde995
toa0a2eb3297
Initiated the VArray for
.hide_vert
outside the callback.@ -8,6 +8,7 @@
#include "BLI_bitmap.h"
#include "BLI_math.h"
#include "BLI_virtual_array.hh"
BKE_attribute.hh
includesBLI_virtual_array.hh
indirectly, no need to add it here separately.@lichtwerk In the issue you mentioned there's still inconsistency with image painting. What I understood there is that the user should not be able to paint inside a UV region where the corresponding face is hidden? (Or not?) I think the intention is to merge this PR and take care of those later?
Hm, I was thinking to make this a bit more general (since like I mentioned in #106354 a lot of other operators are affected as well...), but also fine for me to have this in and improve more later.
@lichtwerk If not anything I guess we could merge this one for now?
yeah, dont want to hold this back just for future improvements.