Fix #106484: Show all rotations with same precision #106515

Harley Acheson · 2023-04-04T01:49:57+02:00

Harley Acheson commented

2023-04-04 01:49:57 +02:00

Increase precision of some rotational inputs so that they all show the
same precision. And have the arrows change in full degrees.

As #106484 shows, it is confusing that our display of Object rotational degrees does not show tenths of degrees above 99.9 degrees This is especially confusing because clicking the "up" and "down" arrow buttons continues to change in tenths.

The vast majority of our PROP_EULER properties specify a precision of RNA_TRANSLATION_PREC_DEFAULT, which is 5. Without this the precision is 3. This PR just makes all of these rotational inputs have the same precision of RNA_TRANSLATION_PREC_DEFAULT for consistency.

A bit more contentious is that this also changes all these rotational properties to use a step value of 100. This is because float properties scale this value by UI_PRECISION_FLOAT_SCALE, which is 0.01f. Most rotational inputs are using a step value of 1 which means that clicking the "up" and "down" arrows changes the rotation by a hundredth of a degree. Therefore this PR makes it so that "up" and "down" changes a degree, which seems expected.

Increase precision of some rotational inputs so that they all show the same precision. And have the arrows change in full degrees. --- As #106484 shows, it is confusing that our display of Object rotational degrees does not show tenths of degrees above 99.9 degrees This is especially confusing because clicking the "up" and "down" arrow buttons continues to change in tenths. ![Rotation1.gif](/attachments/1825d07c-b246-4f08-b056-746eb093e4e6) The vast majority of our PROP_EULER properties specify a precision of RNA_TRANSLATION_PREC_DEFAULT, which is 5. Without this the precision is 3. This PR just makes all of these rotational inputs have the same precision of RNA_TRANSLATION_PREC_DEFAULT for consistency. A bit more contentious is that this also changes all these rotational properties to use a `step` value of 100. This is because float properties scale this value by UI_PRECISION_FLOAT_SCALE, which is 0.01f. Most rotational inputs are using a step value of 1 which means that clicking the "up" and "down" arrows changes the rotation by a hundredth of a degree. Therefore this PR makes it so that "up" and "down" changes a degree, which seems expected.

Rotation1.gif

87 KiB

Harley Acheson added this to the User Interface project 2023-04-07 19:20:33 +02:00

Harley Acheson requested review from Hans Goudey 2023-04-07 19:20:43 +02:00

Hans Goudey reviewed 2023-04-07 19:48:49 +02:00

Hans Goudey left a comment

Looks good! I see a lot of other uses of PROP_FLOAT, PROP_EULER and just PROP_EULER that don't have this UI data set. Maybe they would have the same issue?

Looks good! I see a lot of other uses of `PROP_FLOAT, PROP_EULER` and just `PROP_EULER` that don't have this UI data set. Maybe they would have the same issue?

Hans Goudey requested changes 2023-04-18 22:14:29 +02:00

Hans Goudey left a comment

Just requesting changes pending investigation on whether this same problem applies elsewhere :)

Harley Acheson changed title from ~~Fix #106484: Show Rotation with higher precision~~ to WIP: Fix #106484: Show Rotation with higher precision

2023-04-18 23:38:34 +02:00

Harley Acheson changed title from ~~WIP: Fix #106484: Show Rotation with higher precision~~ to Fix #106484: Show all rotations with same precision

2023-04-19 02:49:53 +02:00

Harley Acheson force-pushed RotationPrecision from d462531c18 to 3c720a9121

2023-04-19 02:51:44 +02:00

Compare

Harley Acheson commented

2023-04-19 02:53:33 +02:00

@HooglyBoogly - ...investigation on whether this same problem applies elsewhere

That was a great suggestion. This PR now removes all the inconsistencies with these and some other oddness. I updated the first comment to explain it.

> @HooglyBoogly - ...investigation on whether this same problem applies elsewhere That was a great suggestion. This PR now removes all the inconsistencies with these and some other oddness. I updated the first comment to explain it.

Harley Acheson merged commit b34ece48f8 into main

2023-05-19 00:25:14 +02:00

Harley Acheson deleted branch RotationPrecision

2023-05-19 00:25:17 +02:00

Harley Acheson referenced this issue from a commit

2023-05-19 00:25:23 +02:00

Fix #106484: Show all rotations with same precision

Harley Acheson referenced this issue from a commit

2023-05-21 19:39:01 +02:00

Fix #106484: Show all rotations with same precision

Falk David referenced this issue from a commit

2023-05-23 14:35:34 +02:00