Regression: Multires: Enabling "Sculpt Base Mesh" after using transform tools crashes Blender #107092

New Issue

Closed

opened 2023-04-18 17:39:10 +02:00 by Julien Kaspar · 6 comments

Julien Kaspar commented

2023-04-18 17:39:10 +02:00

Member

System Information
Operating system: Linux-6.2.11-gentoo-x86_64-AMD_Ryzen_Threadripper_1950X_16-Core_Processor-with-glibc2.36 64 Bits, X11 UI
Graphics card: Quadro GP100/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 530.41.03

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-04-18 15:15, hash: 5bb3a3f1575d

Caused by b86fc55d30

Short description of error
When using any transform tool or operator in sculpt mode and afterwards toggling on the "Sculpt Base Mesh" feature in the Multiresolution panel, Blender crashes.

Exact steps for others to reproduce the error

Add a cube
Add a Multires modifier and subdivide
Enter Sculpt Mode
Use the Move Tool
Enable "Sculpt Base Mesh" in the Multires modifier

**System Information** Operating system: Linux-6.2.11-gentoo-x86_64-AMD_Ryzen_Threadripper_1950X_16-Core_Processor-with-glibc2.36 64 Bits, X11 UI Graphics card: Quadro GP100/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 530.41.03 **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-04-18 15:15, hash: `5bb3a3f1575d` Caused by b86fc55d30054d454c2d3c8bf0f91fdfbb5d0a29 **Short description of error** When using any transform tool or operator in sculpt mode and afterwards toggling on the "Sculpt Base Mesh" feature in the Multiresolution panel, Blender crashes. **Exact steps for others to reproduce the error** - Add a cube - Add a Multires modifier and subdivide - Enter Sculpt Mode - Use the Move Tool - Enable "Sculpt Base Mesh" in the Multires modifier

Julien Kaspar added the

labels 2023-04-18 17:39:11 +02:00

Julien Kaspar commented

2023-04-18 17:43:22 +02:00

Author

Member

Actually, the crash can also be caused by just toggling the visibility of the Multires modifier instead of this specific option.

Actually, the crash can also be caused by just toggling the visibility of the Multires modifier instead of this specific option.

Iliya Katushenock added the

Sculpt, Paint & Texture

label 2023-04-18 19:34:43 +02:00

Jesse Yurkovich commented

2023-04-18 21:39:59 +02:00

Member

The 2 crashes are actually separate issues.

Toggling "Sculpt Base Mesh" triggers an assert:

BLI_assert failed: source/blender/blenkernel/intern/pbvh.cc:3207, BKE_pbvh_vert_coords_apply(), at '0'
  PBVH: Given deforming vcos number does not match PBVH vertex number!

Toggling the visibility causes a use-after-free memory error:

==7462==ERROR: AddressSanitizer: heap-use-after-free on address 0x61100134ec08 at pc 0x0000014fadf8 bp 0x7ffe48693fa0 sp 0x7ffe48693f90
READ of size 8 at 0x61100134ec08 thread T0
    #0 0x14fadf7 in BKE_pbvh_get_grid_updates /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/pbvh.cc:1974
    #1 0x150927f in BKE_pbvh_update_normals /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/pbvh.cc:3047
    #2 0x4e0cf6e in drw_sculpt_generate_calls /home/deadpin/source/blender-git/blender/source/blender/draw/intern/draw_manager_data.cc:1361

0x61100134ec08 is located 8 bytes inside of 200-byte region [0x61100134ec00,0x61100134ecc8)
freed by thread T40 here:
    #0 0x7f03a0e25517 in __interceptor_free ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:127
    #1 0x1d4e45bc in MEM_lockfree_freeN /home/deadpin/source/blender-git/blender/intern/guardedalloc/intern/mallocn_lockfree_impl.c:102
    #2 0x17e3dea in BKE_subdiv_ccg_destroy /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/subdiv_ccg.cc:640
    #3 0x110ca32 in free_subdiv_ccg /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/mesh_runtime.cc:68
    #4 0x110fb73 in BKE_mesh_runtime_clear_geometry /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/mesh_runtime.cc:219

The 2 crashes are actually separate issues. Toggling "Sculpt Base Mesh" triggers an assert: ``` BLI_assert failed: source/blender/blenkernel/intern/pbvh.cc:3207, BKE_pbvh_vert_coords_apply(), at '0' PBVH: Given deforming vcos number does not match PBVH vertex number! ``` Toggling the visibility causes a use-after-free memory error: ``` ==7462==ERROR: AddressSanitizer: heap-use-after-free on address 0x61100134ec08 at pc 0x0000014fadf8 bp 0x7ffe48693fa0 sp 0x7ffe48693f90 READ of size 8 at 0x61100134ec08 thread T0 #0 0x14fadf7 in BKE_pbvh_get_grid_updates /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/pbvh.cc:1974 #1 0x150927f in BKE_pbvh_update_normals /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/pbvh.cc:3047 #2 0x4e0cf6e in drw_sculpt_generate_calls /home/deadpin/source/blender-git/blender/source/blender/draw/intern/draw_manager_data.cc:1361 0x61100134ec08 is located 8 bytes inside of 200-byte region [0x61100134ec00,0x61100134ecc8) freed by thread T40 here: #0 0x7f03a0e25517 in __interceptor_free ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:127 #1 0x1d4e45bc in MEM_lockfree_freeN /home/deadpin/source/blender-git/blender/intern/guardedalloc/intern/mallocn_lockfree_impl.c:102 #2 0x17e3dea in BKE_subdiv_ccg_destroy /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/subdiv_ccg.cc:640 #3 0x110ca32 in free_subdiv_ccg /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/mesh_runtime.cc:68 #4 0x110fb73 in BKE_mesh_runtime_clear_geometry /home/deadpin/source/blender-git/blender/source/blender/blenkernel/intern/mesh_runtime.cc:219 ```

Jesse Yurkovich added

and removed

labels 2023-04-18 21:40:16 +02:00

Philipp Oeser commented

2023-04-19 09:22:58 +02:00

Member

Similar to #107068 (I assume) this seems to be a recent regression.

Will try my luck bisecting again

Similar to #107068 (I assume) this seems to be a recent regression. Will try my luck bisecting again

Philipp Oeser added

Sculpt, Paint & Texture

and removed

Sculpt, Paint & Texture

labels 2023-04-19 09:23:26 +02:00

Philipp Oeser commented

2023-04-19 10:06:44 +02:00

Member

Caused by b86fc55d30

CC @JosephEagar

Caused by b86fc55d30054d454c2d3c8bf0f91fdfbb5d0a29 CC @JosephEagar

Philipp Oeser changed title from ~~Multires: Enabling "Sculpt Base Mesh" after using transform tools crashes Blender~~ to Regression: Multires: Enabling "Sculpt Base Mesh" after using transform tools crashes Blender

2023-04-19 10:07:13 +02:00

~~Julien Kaspar referenced this issue 2023-04-19 10:10:01 +02:00~~

Multiresolution Issues #107118

Julien Kaspar commented

2023-04-19 10:27:36 +02:00

Author

Member

@lichtwerk Are both the above mentioned crashes caused by that commit?

@lichtwerk Are both the above mentioned crashes caused by that commit?

Philipp Oeser commented

2023-04-19 10:39:01 +02:00

Member

I followed the repro steps, so enable "Sculpt Base Mesh" is what I bisected

I followed the repro steps, so enable "Sculpt Base Mesh" is what I bisected

Julien Kaspar added

and removed

labels 2023-04-24 14:47:56 +02:00

Joseph Eagar referenced this issue from a commit

2023-04-24 21:20:10 +02:00

Sculpt: Fix #107092: ss->filter_cache not being null'd on free

Joseph Eagar closed this issue

2023-04-24 21:20:11 +02:00

Blender Bot added

and removed

labels 2023-04-24 21:20:13 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107092

No description provided.