Copy/Paste object operator copies collections specified somewhere in that object (e.g. Geometry Node Collection Info node, particle system instance collection, ...) #107111

New Issue

Open

opened 2023-04-19 01:40:50 +02:00 by Firefly-4 · 9 comments

Firefly-4 commented

2023-04-19 01:40:50 +02:00

Blender Version
Broken: Current master.
Worked: Never.

Short description of error
The copy operator treats the Collection Info node as the fact that the object belongs to the collection.

Ctrl+C	Ctrl+V	Expected

Exact steps for others to reproduce the error

Create collections Collection_1, Collection_2.
Add Cube in Collection_1.
Add Cone in Collection_2.
Create geometry node modifier on Cube. Go in node tree:
a. Create Collection Info node.
b. Choose a Collection_2.
Select Collection_1, Cube.
Copy object in 3d view.
Expected: Cube object will copied.
Bug: Copyring object, collection and attach that in collection that chosen in Collection Info node.

The same happens when you:

Create collections Collection_1, Collection_2.
-- Add Cube in Collection_1.
-- Add Cone in Collection_2.
Create a particle system on the Cube
-- Render As Collection
-- specify Collection_2 as the Instance Collection
Select Collection_1, Cube.
-- Copy object in 3d view.
-- Expected: Cube object will copied.
-- Bug: Copying object, collection and attach that in collection that chosen in the Particle Instance Collection.

**Blender Version** Broken: Current master. Worked: Never. **Short description of error** The copy operator treats the `Collection Info` node as the fact that the object belongs to the collection. | Ctrl+C | Ctrl+V | Expected | | -- | -- | -- | | ![image](/attachments/8f22a8f4-ddec-4db1-b799-6d8e743d85a1) | ![image](/attachments/b7bf8674-25df-42b7-8abc-cc90f8714d9e) | ![image](/attachments/952a1047-656c-485c-9ae8-3f81dadc3a3d) | **Exact steps for others to reproduce the error** 1. Create collections `Collection_1`, `Collection_2`. 2. Add Cube in `Collection_1`. 3. Add Cone in `Collection_2`. 4. Create geometry node modifier on Cube. Go in node tree: a. Create `Collection Info` node. b. Choose a `Collection_2`. 5. Select `Collection_1`, Cube. 6. Copy object in 3d view. Expected: Cube object will copied. Bug: Copyring object, collection and attach that in collection that chosen in `Collection Info` node. The same happens when you: - Create collections Collection_1, Collection_2. -- Add Cube in Collection_1. -- Add Cone in Collection_2. - Create a particle system on the Cube -- Render As Collection -- specify Collection_2 as the Instance Collection - Select Collection_1, Cube. -- Copy object in 3d view. -- Expected: Cube object will copied. -- Bug: Copying object, collection and attach that in collection that chosen in the Particle Instance Collection.

collection copy bug.blend

831 KiB

2023-04-19 14-58-45.mp4

7.6 MiB

21 KiB

17 KiB

14 KiB

Firefly-4 added the

labels 2023-04-19 01:40:51 +02:00

Iliya Katushenock added the

Nodes & Physics

labels 2023-04-19 06:49:53 +02:00

Pratik Borhade commented

2023-04-19 12:01:56 +02:00

Member

Hi, thanks for the report. Can repro this locally.
Reducing density might help to understand why RAM and CPU usage were increased (see uploaded file).
Copy-pasting is not really creating duplicate of the original object. It instead is creating multiple copies of the original object and instances.
A quick fix would be to add realize instances and apply modifier > then do the copy-pasting.

Guess Instance on points node is causing this? Will forward the report to devs.

Hi, thanks for the report. Can repro this locally. Reducing density might help to understand why RAM and CPU usage were increased (see uploaded file). Copy-pasting is not really creating duplicate of the original object. It instead is creating multiple copies of the original object and instances. A quick fix would be to add realize instances and apply modifier > then do the copy-pasting. Guess `Instance on points node` is causing this? Will forward the report to devs.

grasstile-simplified.blend

1.3 MiB

Pratik Borhade added

Needs Info from Developers

Nodes & Physics

and removed

Nodes & Physics

labels 2023-04-19 12:02:56 +02:00

Iliya Katushenock commented

2023-04-19 13:04:57 +02:00

Member

I will check it. There is a suspicion that Hans had already decided it yesterday.

I will check it. There is a suspicion that Hans had already decided it yesterday.

Firefly-4 commented

2023-04-19 13:21:17 +02:00

Author

I found this older bug report while browsing and it appears to be related (huge ram spike and instance on points node is involved) but the use case is different: #99480

The bug was a bit inconsistent in my case too, I did manage to copy/paste it a couple of times while checking if it's reproducible, but 99% of the time it would hang.

P.S.
Yup, realize instances + apply worked great.

I found this older bug report while browsing and it appears to be related (huge ram spike and instance on points node is involved) but the use case is different: https://projects.blender.org/blender/blender/issues/99480 The bug was a bit inconsistent in my case too, I did manage to copy/paste it a couple of times while checking if it's reproducible, but 99% of the time it would hang. P.S. Yup, realize instances + apply worked great.

Iliya Katushenock commented

2023-04-19 13:26:50 +02:00

Member

I'm shocked at what a bug this could be. I'm not sure yet, but it's terrible.

I'm shocked at what a bug this could be. I'm not sure yet, but it's terrible.

Iliya Katushenock commented

2023-04-19 13:29:46 +02:00

Member

Just... how... why this happens what are visitor are think that selected nodes is selected collections for duplicate/

Just... how... why this happens what are visitor are think that selected nodes is selected collections for duplicate/

2023-04-19 14-28-06.mp4

3.8 MiB

Iliya Katushenock commented

2023-04-19 13:41:59 +02:00

Member

I will describe you a bug:

You are copying an object.
It belongs to collection 1.
But the object has a node with collection 2.
Copying thinks that you are copying an object and a collection 2. And also links them for some reason.
The destination of the copy is collection 2, as it is active in the outliner.
Now you have 2 copies of the object. The first in the collection and is evaluated for its copy of the collection 2. This is fine.
But after that, the original tries to take the geometry from the collection 2, and takes already 1 mega large grass object.

I'll redo your report to reflect the actual bug, thanks for reporting it.

I will describe you a bug: 1. You are copying an object. 2. It belongs to collection 1. 3. But the object has a node with collection 2. 4. Copying thinks that you are copying an object and a collection 2. And also links them for some reason. 5. The destination of the copy is collection 2, as it is active in the outliner. 6. Now you have 2 copies of the object. The first in the collection and is evaluated for its copy of the collection 2. This is fine. 7. But after that, the original tries to take the geometry from the collection 2, and takes already 1 mega large grass object. I'll redo your report to reflect the actual bug, thanks for reporting it.

Firefly-4 commented

2023-04-19 13:53:24 +02:00

Author

So it's kind of like the grass tile including itself (infinitely?) I did not pay attention to what collection I had selected before pasting, maybe those times when it did not repro for me I accidentally selected a different collection and that's why the paste worked.

It's great that the real cause has been found 👍

So it's kind of like the grass tile including itself (infinitely?) I did not pay attention to what collection I had selected before pasting, maybe those times when it did not repro for me I accidentally selected a different collection and that's why the paste worked. It's great that the real cause has been found 👍

Iliya Katushenock changed title from ~~Massive RAM usage increase & Blender hangs when copy/pasting this particular object with geometry nodes~~ to Geometry Nodes: Copy object operator perceives Collection Info node as collection attach

2023-04-19 14:03:12 +02:00

Iliya Katushenock added

and removed

Needs Info from Developers

labels 2023-04-19 14:03:22 +02:00

Iliya Katushenock added reference main

2023-04-19 14:09:39 +02:00

Iliya Katushenock removed reference main

2023-04-19 14:09:43 +02:00

Iliya Katushenock referenced this issue

2023-09-19 13:27:22 +02:00

Additional unwanted objects being created when asset browser asset is used #107180

Philipp Oeser commented

2023-09-19 13:47:54 +02:00

Member

The same happens when you:

Create collections Collection_1, Collection_2.
-- Add Cube in Collection_1.
-- Add Cone in Collection_2.
Create a particle system on the Cube
-- Render As Collection
-- specify Collection_2 as the Instance Collection
Select Collection_1, Cube.
-- Copy object in 3d view.
-- Expected: Cube object will copied.
-- Bug: Copying object, collection and attach that in collection that chosen in the Particle Instance Collection.

I believe this is the correct way if you pate into another file, but it is unexpected if you paste locally into the same file.
@mont29 might know more...

The same happens when you: - Create collections Collection_1, Collection_2. -- Add Cube in Collection_1. -- Add Cone in Collection_2. - Create a particle system on the Cube -- Render As Collection -- specify Collection_2 as the Instance Collection - Select Collection_1, Cube. -- Copy object in 3d view. -- Expected: Cube object will copied. -- Bug: Copying object, collection and attach that in collection that chosen in the Particle Instance Collection. I believe this is the correct way if you pate into another file, but it is unexpected if you paste locally into the same file. @mont29 might know more...

Philipp Oeser added

Nodes & Physics

and removed

Nodes & Physics

labels 2023-09-19 13:48:45 +02:00

Philipp Oeser changed title from ~~Geometry Nodes: Copy object operator perceives Collection Info node as collection attach~~ to Copy/Paste object operator copies collections specified somewhere in that object (e.g. Geometry Node Collection Info node, particle system instance collection, ...)

2023-09-19 13:50:49 +02:00

Philipp Oeser referenced this issue

2023-09-19 13:51:15 +02:00

Additional unwanted objects being created when asset browser asset is used #107180

Bastien Montagne commented

2023-09-25 16:16:23 +02:00

Owner

This is expected behavior, if your object depends on another collection, the other collection will be copied as well indeed.

This for sure could (should) be improved, but given current back-end of the ID copy/paste feature (saving in temp blendfile, and appending from there), not much to be done. Fixing this would likely require a decent re-design of the whole copy-paste system.

This is expected behavior, if your object depends on another collection, the other collection will be copied as well indeed. This for sure could (should) be improved, but given current back-end of the ID copy/paste feature (saving in temp blendfile, and appending from there), not much to be done. Fixing this would likely require a decent re-design of the whole copy-paste system.

Bastien Montagne added

and removed

labels 2023-09-25 16:17:03 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107111

No description provided.