"New action" tooltip should be duplicate/copy action #107625

New Issue

Ken Heslip · 2023-05-04T17:33:57+02:00

Ken Heslip commented

2023-05-04 17:33:57 +02:00

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 531.29

Blender Version
Broken: version: 3.5.1, branch: blender-v3.5-release, commit date: 2023-04-24 18:11, hash: e1ccd9d4a1d3
Worked: (newest version of Blender that worked as expected)

Short description of error
This tooltip in the image isn't strictly correct. While it does create a new action, it really makes a copy of the current action.

Exact steps for others to reproduce the error
Hover mouse over the icon circled in green in the image. In the action editor.
The tooltip says "New action. Create new action.".

I think the tooltip should say: "Copy action. Copy current action.".

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 531.29 **Blender Version** Broken: version: 3.5.1, branch: blender-v3.5-release, commit date: 2023-04-24 18:11, hash: `e1ccd9d4a1d3` Worked: (newest version of Blender that worked as expected) **Short description of error** This tooltip in the image isn't strictly correct. While it does create a new action, it really makes a copy of the current action. **Exact steps for others to reproduce the error** Hover mouse over the icon circled in green in the image. In the action editor. The tooltip says "New action. Create new action.". I think the tooltip should say: "Copy action. Copy current action.".

2023-05-04 (1).png

40 KiB

Ken Heslip added the

labels 2023-05-04 17:33:58 +02:00

YimingWu added

Module

User Interface

Status

Needs Info from Developers

and removed

Status

Needs Triage

labels 2023-05-05 05:20:20 +02:00

YimingWu commented

2023-05-05 05:22:32 +02:00

Yeah from the quick look at the code it seems that it's always been copying the old action.

I suggest changing the tool tip into "Create a new action by duplicating the current one".

Yeah from the quick look at the code it seems that it's always been copying the old action. I suggest changing the tool tip into "Create a new action by duplicating the current one".

👍 1

Ken Heslip commented

2023-05-05 22:27:41 +02:00

I'd be happy with that or something slightly altered...

"Creates new action by duplicating the current action."

I'd be happy with that or something slightly altered... "Creates new action by duplicating the current action."

👍 1

Pratik Borhade added

and removed

Needs Info from Developers

labels 2023-06-09 07:15:35 +02:00

Pratik Borhade commented

2023-06-09 07:17:48 +02:00

I can confirm. Tagged with "good first issue"

👍 1

crabs referenced this issue

2023-07-08 05:38:20 +02:00

"New material" tooltip should be "Copy current material" #109845

Andras-Borsanyi commented

2023-07-08 10:52:58 +02:00

I can fix this one. Should I do #109845 at the same time?

Andras-Borsanyi commented

2023-07-08 14:46:36 +02:00

I've bumped into the issue of the the tooltips for the copy button when there already is a linked action and the + New button when there is no action linked being the same. If I change the tooltip to "Copy Action", it changes even if there is no action to copy.

The easy solution would be to change the tooltip to "New Action" "Create new action or duplicate the current one", but this might be confusing if there is no current action and sounds like it's possible to create a blank action if there already is one.

The more complicated approach would be to use separate operators for new and copy, but I couldn't figure out how the copy and + New buttons are linked and I am not sure if you are supposed to mess with that anyways. (Geometry Nodes have separate tooltips and I don't know how, all I know is it’s in Python)

Any ideas?

I've bumped into the issue of the the tooltips for the copy button when there already is a linked action and the `+ New ` button when there is no action linked being the same. If I change the tooltip to "Copy Action", it changes even if there is no action to copy. The easy solution would be to change the tooltip to "New Action" "Create new action or duplicate the current one", but this might be confusing if there is no current action and sounds like it's possible to create a blank action if there already is one. The more complicated approach would be to use separate operators for new and copy, but I couldn't figure out how the copy and `+ New ` buttons are linked and I am not sure if you are supposed to mess with that anyways. (Geometry Nodes have separate tooltips and I don't know how, all I know is it’s in Python) Any ideas?

crabs referenced this issue

2023-07-09 16:58:25 +02:00

"New material" tooltip should be "Copy current material" #109845

Danilo-Ferreira referenced a pull request that will close this issue

2024-02-12 17:20:48 +01:00

Fix #107625 Making the create action's tooltip different for creation and duplication #118144

Danilo-Ferreira commented

2024-02-16 23:04:21 +01:00

I was reading your conversation about this issue and while I was investigating the problem I found a solution.
So I opened a PR to solve it. It's my first PR so I don't know the next steps.
Any necessary change on PR, let me know.

I was reading your conversation about this issue and while I was investigating the problem I found a solution. So I opened a PR to solve it. It's my first PR so I don't know the next steps. Any necessary change on PR, let me know.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

"New action" tooltip should be duplicate/copy action #107625