"New material" tooltip should be "Copy current material" #109845

Open
opened 2023-07-08 05:36:53 +02:00 by crabs · 6 comments
Contributor

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 536.25

Blender Version
Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-07-08 02:41, hash: c677f791f063
Worked: Unknown

The tooltip in the image is not correct and might cause confusion. Clicking the button instead of just creating a new material, it copies the material to a new one, instead of creating a new material from a blank template.

Exact steps for others to reproduce the error
Hover mouse over the icon pointed by the red arrow in the attached image (located in the shader editor).

The tooltip says: "New material".
I think the tooltip should say:
"Copy material"
"Creates a new material by duplicating the current one"

Observation
This issue is similar to issue #107625, but in another part of Blender.

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 536.25 **Blender Version** Broken: version: 4.0.0 Alpha, branch: main, commit date: 2023-07-08 02:41, hash: `c677f791f063` Worked: Unknown The tooltip in the image is not correct and might cause confusion. Clicking the button instead of just creating a new material, it copies the material to a new one, instead of creating a new material from a blank template. **Exact steps for others to reproduce the error** Hover mouse over the icon pointed by the red arrow in the attached image (located in the shader editor). The tooltip says: "New material". I think the tooltip should say: "Copy material" "Creates a new material by duplicating the current one" **Observation** This issue is similar to issue #107625, but in another part of Blender.
crabs added the
Type
Report
Status
Needs Triage
Priority
Normal
labels 2023-07-08 05:36:53 +02:00
Member

This is interestingly how blender always worked, that button is consistently duplicating the existing one. I guess people have long being used to the way. Yeah the tooltip might need to have a change.

This is interestingly how blender always worked, that button is consistently duplicating the existing one. I guess people have long being used to the way. Yeah the tooltip might need to have a change.
YimingWu added
Module
User Interface
Status
Confirmed
and removed
Status
Needs Triage
labels 2023-07-09 04:56:02 +02:00

Just pointing out that the same widget for geometry nodes uses the 'copy' wording, similar to what's suggested here. This discrepancy doesn't seem intentional, I can't see a reason why it would be.

Screenshot 2023-07-09 173121.png

Just pointing out that the same widget for geometry nodes uses the 'copy' wording, similar to what's suggested here. This discrepancy doesn't seem intentional, I can't see a reason why it would be. [![Screenshot 2023-07-09 173121.png](/attachments/0ce97375-05d3-4cb0-8f42-1e961bd95b3a)](url)
Author
Contributor

Just pointing out that the same widget for geometry nodes uses the 'copy' wording, similar to what's suggested here. This discrepancy doesn't seem intentional, I can't see a reason why it would be.

Screenshot 2023-07-09 173121.png

I was trying to fix issue #107625 by looking at similar behaviour in the Blender UI that worked as expected. Geometry nodes was the only one I could find that had proper tooltip, but I wasn't to find in the code where the Geo Node tooltip comes from. It seems to come from a .py file, which was quite odd to me, as a newbie wanna be Blender developer.

> Just pointing out that the same widget for geometry nodes uses the 'copy' wording, similar to what's suggested here. This discrepancy doesn't seem intentional, I can't see a reason why it would be. > > [![Screenshot 2023-07-09 173121.png](/attachments/0ce97375-05d3-4cb0-8f42-1e961bd95b3a)](url) I was trying to fix issue #107625 by looking at similar behaviour in the Blender UI that worked as expected. Geometry nodes was the only one I could find that had proper tooltip, but I wasn't to find in the code where the Geo Node tooltip comes from. It seems to come from a .py file, which was quite odd to me, as a newbie wanna be Blender developer.
Member

The problem of this is that blender uses the same base logic in these places "If exists, copy this one, otherwise creates a new one". But detailed behaviour is quite different. Like for texture and text blocks, the duplicate button will not duplicate but it will always ask you for a new one. So maybe we need to have some further designs on the icon as well to make things consistent.

Maybe this can be lower priority since mostly people are used to the logic here and can easily adapt to these minor differences

The problem of this is that blender uses the same base logic in these places "If exists, copy this one, otherwise creates a new one". But detailed behaviour is quite different. Like for texture and text blocks, the duplicate button will not duplicate but it will always ask you for a new one. So maybe we need to have some further designs on the icon as well to make things consistent. Maybe this can be lower priority since mostly people are used to the logic here and can easily adapt to these minor differences
Member

Like for texture and text blocks, the duplicate button will not duplicate but it will always ask you for a new one. So maybe we need to have some further designs on the icon as well to make things consistent.

Agreed. It's the same thing for the Image editor: it has a "New Image" button that always creates a new blank image, but still uses the universal icon for duplication. I'd say Blender needs a new (heh) icon for indicating the concept of "New" as opposed to "Copy".

> Like for texture and text blocks, the duplicate button will not duplicate but it will always ask you for a new one. So maybe we need to have some further designs on the icon as well to make things consistent. Agreed. It's the same thing for the Image editor: it has a "New Image" button that always creates a new blank image, but still uses the universal icon for duplication. I'd say Blender needs a new (heh) icon for indicating the concept of "New" as opposed to "Copy".

I think that "duplicate" is a better term than "copy", which is usually related to clipboard.

I think that "duplicate" is a better term than "copy", which is usually related to clipboard.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109845
No description provided.