Regression: Group Insert operator creates invalid links #108141

New Issue

Lukas Tönne · 2023-05-22T11:58:20+02:00

Lukas Tönne commented

2023-05-22 11:58:20 +02:00

Blender Version
Broken: 7f4aa0b5
Broken: 3.5.1
Worked: 3.4.1, 3.3.6

Behavior changed in fa3ca9afdb

Short description of error
If a node is already connected to a group, inserting nodes into a group using the "Group Insert" operator creates invalid back-to-front links from outputs to inputs.

Exact steps for others to reproduce the error
group_insert_bad_links.blend

Open attached file. Select one of the Add nodes and then the connected group node. Run the Node > Group Insert operator to move the Add node into the group. The result contains invalid links which are not correctly detected:

**Blender Version** Broken: 7f4aa0b5 Broken: 3.5.1 Worked: 3.4.1, 3.3.6 Behavior changed in fa3ca9afdb6f1ea1b709226af3f085133e5ddc2f **Short description of error** If a node is already connected to a group, inserting nodes into a group using the "Group Insert" operator creates invalid back-to-front links from outputs to inputs. **Exact steps for others to reproduce the error** [group_insert_bad_links.blend](/attachments/44310ff5-df57-4f87-917d-f78ae9ffbb7c) Open attached file. Select one of the _Add_ nodes and then the connected group node. Run the _Node > Group Insert_ operator to move the Add node into the group. The result contains invalid links which are not correctly detected: ![](/attachments/5238a6e0-9627-49ba-86b6-d38cd64e662e)

group_insert_bad_links.blend

1.2 MiB

image.png

62 KiB

Screenshot_20230522_115535.png

64 KiB

Lukas Tönne added the

labels 2023-05-22 11:58:20 +02:00

Lukas Tönne added this to the Nodes & Physics project 2023-05-22 11:59:59 +02:00

Philipp Oeser commented

2023-05-22 12:04:32 +02:00

Can confirm, looks like a regression (does not happen in 3.3.6), will check

Philipp Oeser added

and removed

labels 2023-05-22 12:05:11 +02:00

Lukas Tönne commented

2023-05-22 12:10:07 +02:00

I suspect my own changes in #107807

Philipp Oeser commented

2023-05-22 12:18:57 +02:00

I suspect my own changes in #107807

Dont think so, broke between good 50c7eb14f4 & bad 4924f8cffd

> I suspect my own changes in #107807 Dont think so, broke between good 50c7eb14f455 & bad 4924f8cffd45

Philipp Oeser commented

2023-05-22 12:19:29 +02:00

will do a quick bisect

Philipp Oeser commented

2023-05-22 12:40:38 +02:00

Behavior changed in fa3ca9afdb

CC @HooglyBoogly

Behavior changed in fa3ca9afdb6f1ea1b709226af3f085133e5ddc2f CC @HooglyBoogly

Philipp Oeser added

and removed

labels 2023-05-22 12:41:02 +02:00

Iliya Katushenock self-assigned this 2023-05-22 14:44:42 +02:00

Iliya Katushenock commented

2023-05-24 19:34:38 +02:00

Summary of my exploration: Regression also means that this case:

Will not be processed (the operator simply does nothing).
I see that this operator needs to be radically redesigned (it does not do the most useful result anyway).
I can now make a quick stub to eliminate the creation of cycles.
But later already consider changing behavior dramatically.

Summary of my exploration: Regression also means that this case: ![image](/attachments/fbb5cfa2-f1e7-482f-80c4-fa09d071899a) Will not be processed (the operator simply does nothing). I see that this operator needs to be radically redesigned (it does not do the most useful result anyway). I can now make a quick stub to eliminate the creation of cycles. But later already consider changing behavior dramatically.

image.png

64 KiB

Iliya Katushenock referenced a pull request that will close this issue

2023-05-26 22:32:00 +02:00

Fix #108141: Group Insert operator creates invalid links #108332

Iliya Katushenock changed title from ~~Group Insert operator creates invalid links~~ to Regression: Group Insert operator creates invalid links

2023-05-29 18:24:45 +02:00

Hans Goudey referenced this issue from a commit

2023-06-16 20:24:38 +02:00

Fix #108141: Group Insert operator creates invalid links

Hans Goudey closed this issue

2023-06-16 20:24:38 +02:00

Blender Bot added

and removed