Pasting a material crashes #108495

New Issue

Campbell Barton · 2023-06-01T09:10:13+02:00

Campbell Barton commented

2023-06-01 09:10:13 +02:00

NOTE: reporting for reference.

Blender Version
Broken: 3.6x and main branch.
Worked: never

Short description of error

Pasting a material which references other ID's may crash.

Exact steps for others to reproduce the error

Click on the the "Shader" tab
Add a node that references an ID, examples (it may crash after any one of these).

In the node editor:
- Add -> Texture -> Image Texture, then create new image.
- Add -> Script -> Script, then create a text data-block and reference it.
- Add some nodes and move them into a group.
Copy the material in the material properties tab.
File -> New
Click on the shading tab.
Paste the material in the material properties tab.
Blender should crash.

_NOTE: reporting for reference._ **Blender Version** Broken: 3.6x and `main` branch. Worked: never **Short description of error** Pasting a material which references other ID's may crash. **Exact steps for others to reproduce the error** - Click on the the "Shader" tab - Add a node that references an ID, examples (it may crash after any one of these). In the node editor: - Add -> Texture -> Image Texture, then create new image. - Add -> Script -> Script, then create a text data-block and reference it. - _Add some nodes and move them into a group._ - Copy the material in the material properties tab. - File -> New - Click on the shading tab. - Paste the material in the material properties tab. - Blender should crash.

Campbell Barton added the

labels 2023-06-01 09:10:14 +02:00

Campbell Barton referenced a pull request that will close this issue

2023-06-01 09:26:26 +02:00

Fix #108495: Pasting a material crashes #108496

Philipp Oeser commented

2023-06-01 10:43:27 +02:00

Can confirm

Philipp Oeser added

and removed

labels 2023-06-01 10:43:44 +02:00

Campbell Barton referenced this issue from a commit

2023-06-02 02:20:50 +02:00

Fix #108495: Pasting a material crashes

Campbell Barton closed this issue

2023-06-02 02:20:51 +02:00

Blender Bot added

and removed

labels 2023-06-02 02:20:55 +02:00

Campbell Barton commented

2023-06-02 04:00:26 +02:00

Re-opening as this is still an issue in 3.6.

Campbell Barton reopened this issue

2023-06-02 04:00:27 +02:00

Blender Bot added

and removed

labels 2023-06-02 04:00:28 +02:00

Pratik Borhade added

and removed

labels 2023-06-02 04:47:52 +02:00

Campbell Barton commented

2023-06-02 04:54:05 +02:00

Committed a fix for this 5177e2f20b37eb5c97f0ed989febd7f783ae4f1f which was intended as a fix for 3.6x, however Bastien wasn't confident about this change.

I've stressed tested materials with complex node-trees from einar_v1.zip (with ASAN enabled) & could not find any problems:

copy/paste between files.
copy/paste into the same file after reloading.
copy/paste into the same file between undo/redo steps.
pasting the default material into complex materials (to ensure they are properly cleared).

So in I think it could be considered for 3.6x, an alternative could be to remove material copy/paste from 3.6x, as the crashes are fairly easy to reproduce and could loose users work.

Committed a fix for this `5177e2f20b37eb5c97f0ed989febd7f783ae4f1f` which was intended as a fix for 3.6x, however Bastien wasn't confident about this change. I've stressed tested materials with complex node-trees from `einar_v1.zip` (with ASAN enabled) & could not find any problems: - copy/paste between files. - copy/paste into the same file after reloading. - copy/paste into the same file between undo/redo steps. - pasting the default material into complex materials (to ensure they are properly cleared). So in I think it could be considered for 3.6x, an alternative could be to remove material copy/paste from 3.6x, as the crashes are fairly easy to reproduce and could loose users work.

Brecht Van Lommel commented

2023-06-02 19:37:40 +02:00

I would prefer the fix to be backported. Looking at the code, I think there is not really a risk of breaking other functionality. This is a pretty obscure feature and already quite broken, so not really worried about it.

Campbell Barton referenced a pull request that will close this issue

2023-06-03 13:03:45 +02:00

Fix #108495: Pasting a material crashes (back-port from main) #108567

Campbell Barton commented

2023-06-03 13:05:24 +02:00

Submitted PR !108567.

Campbell Barton referenced this issue from a commit

2023-06-07 05:28:47 +02:00

Fix #108495: Pasting a material crashes

Campbell Barton closed this issue

2023-06-07 05:42:58 +02:00

Blender Bot added