Editing redo panel properties of torus in edit mode reverts some steps #108638

Open
opened 2023-06-06 00:45:53 +02:00 by Miles Cooley · 6 comments

System Information
Operating system: macOS-10.14.6-x86_64-i386-64bit 64 Bits
Graphics card: NVIDIA GeForce GT 650M OpenGL Engine NVIDIA Corporation 4.1 NVIDIA-12.0.24 355.11.10.50.10.103

Blender Version
Broken: version: 3.4.1, branch: blender-v3.4-release, commit date: 2022-12-20 08:50, hash: rBef9ca44dee7f
Worked: (never worked as expected)

Short description of error
Adding and then adjusting a Torus or any Add Mesh add-on in edit mode reverts edits made to nodes, video sequencer, and more, since entering edit mode on the mesh object.

Exact steps for others to reproduce the error

  1. Go to the Geometry Nodes workspace
  2. Select the default cube
  3. Click the New button to add the Geometry Nodes modifier and create and assign a new node group
  4. In the 3D Viewport switch to Edit mode
  5. In the Node Editor, pour your heart and soul into crafting an elaborate node tree (lol, jk 👀💔)
  6. In the 3D Viewport add a Torus
  7. Tweak any setting in the Adjust Last Operation panel
  8. Observe Geometry Nodes edits reverted (all edits since entering edit mode in the 3D Viewport)

No other built-in mesh primitives (nor even primatives!) have this effect, but the Add Mesh add-ons all do.

I have checked some of the editors to see what data is reverted and what is preserved. This is not yet an exhaustive review.
The following data is reverted:

  • Video Sequencer
  • Properties
  • every Node editor
  • Timeline

The following data is preserved:

  • Preferences
  • Text Editor
  • Python Console
  • Movie Clip Editor
  • UV Editor

The Outliner has mixed results:

  • Hierarchy expansion reverts in Blender File, Data API, and Orphan Data but not in Scenes nor View Layer.

Some editors have special behavior:

  • Image editor
    • Paint mode
      • {Add torus, paint image, tweak torus} reverts the paint
      • {Paint, add, tweak} kicks out of Edit mode into Object mode
    • Switching Image Editor modes does not close the ALO panel. The following sequence of steps produces a Python error:
      • Add torus
      • Switch Image Editor modes
      • Adjust torus
        (If this merits its own tracker issue, tell me and I will write one up. This all seems so tied to one root culprit that it is not my initial inclination to do so)
**System Information** Operating system: macOS-10.14.6-x86_64-i386-64bit 64 Bits Graphics card: NVIDIA GeForce GT 650M OpenGL Engine NVIDIA Corporation 4.1 NVIDIA-12.0.24 355.11.10.50.10.103 **Blender Version** Broken: version: 3.4.1, branch: blender-v3.4-release, commit date: 2022-12-20 08:50, hash: `rBef9ca44dee7f` Worked: (never worked as expected) **Short description of error** Adding and then adjusting a Torus or any Add Mesh add-on in edit mode reverts edits made to nodes, video sequencer, and more, since entering edit mode on the mesh object. **Exact steps for others to reproduce the error** 1. Go to the Geometry Nodes workspace 2. Select the default cube 3. Click the New button to add the Geometry Nodes modifier and create and assign a new node group 4. In the 3D Viewport switch to Edit mode 5. In the Node Editor, pour your heart and soul into crafting an elaborate node tree (lol, jk 👀💔) 6. In the 3D Viewport add a Torus 7. Tweak any setting in the Adjust Last Operation panel 8. Observe Geometry Nodes edits reverted (all edits since entering edit mode in the 3D Viewport) No other built-in mesh primitives (nor even primatives!) have this effect, but the Add Mesh add-ons all do. I have checked some of the editors to see what data is reverted and what is preserved. This is not yet an exhaustive review. The following data is reverted: - Video Sequencer - Properties - every Node editor - Timeline The following data is preserved: - Preferences - Text Editor - Python Console - Movie Clip Editor - UV Editor The Outliner has mixed results: - Hierarchy expansion reverts in Blender File, Data API, and Orphan Data but not in Scenes nor View Layer. Some editors have special behavior: - Image editor - Paint mode - {Add torus, paint image, tweak torus} reverts the paint - {Paint, add, tweak} kicks out of Edit mode into Object mode - Switching Image Editor modes does not close the ALO panel. The following sequence of steps produces a Python error: - Add torus - Switch Image Editor modes - Adjust torus (If this merits its own tracker issue, tell me and I will write one up. This all seems so tied to one root culprit that it is not my initial inclination to do so)
Miles Cooley added the
Priority
Normal
Type
Report
Status
Needs Triage
labels 2023-06-06 00:45:53 +02:00
Member

Can confirm it does cause geometry nodes to revert after adding a torus and adjusting values.

This might again be a very weird quirk of the current undo system.

Can confirm it does cause geometry nodes to revert after adding a torus and adjusting values. This might again be a very weird quirk of the current undo system.
YimingWu added
Module
Core
Status
Confirmed
Interest
Core
Interest
Undo
and removed
Status
Needs Triage
labels 2023-06-06 05:24:06 +02:00
Member

Observe Geometry Nodes edits reverted (all edits since entering edit mode in the 3D Viewport)

I'm not able to replicate this in 4.0
Maybe a Global vs edit-mode undo issue. Could be related to #71895

> Observe Geometry Nodes edits reverted (all edits since entering edit mode in the 3D Viewport) I'm not able to replicate this in 4.0 Maybe a Global vs edit-mode undo issue. Could be related to #71895
Member

@PratikPB2123 , in step 5 you can add a subdiv node between input and output, and once you added the tours and tweaked the value, you can see that subdiv node disappears.

@PratikPB2123 , in step 5 you can add a subdiv node between input and output, and once you added the tours and tweaked the value, you can see that subdiv node disappears.
Member

@ChengduLittleA , thanks. can confirm now. Appears to happen with Torus only. Editing redo panel values of other mesh retains GN tree.

@ChengduLittleA , thanks. can confirm now. Appears to happen with Torus only. Editing redo panel values of other mesh retains GN tree.
Pratik Borhade changed title from Add Mesh > Adjust Last Operation reverts data en masse to Editing redo panel properties of torus in edit mode reverts some steps 2023-06-06 07:50:03 +02:00
Member

@PratikPB2123 seems to be the case here for me as well.

@PratikPB2123 seems to be the case here for me as well.
Member

From my experience, operators that start in Edit mode, modify data other than what's currently in Edit mode and then finish in Edit mode (either by not changing the mode at all, or by changing the mode back to Edit mode at the end) have issues with undo/redo.

The Add Torus operator is a case of starting in Edit mode, changing to Object mode to create a new mesh and join it to the active mesh and then changing back to Edit mode before finishing.

If I'm writing an operator that can be run from edit mode, I either only affect the Edit mode data of what's in Edit mode, or I change the mode to the mode I need and let the operator finish in that mode.

From my experience, operators that start in Edit mode, modify data other than what's currently in Edit mode and then finish in Edit mode (either by not changing the mode at all, or by changing the mode back to Edit mode at the end) have issues with undo/redo. The Add Torus operator is a case of starting in Edit mode, changing to Object mode to create a new mesh and join it to the active mesh and then changing back to Edit mode before finishing. If I'm writing an operator that can be run from edit mode, I either only affect the Edit mode data of what's in Edit mode, or I change the mode to the mode I need and let the operator finish in that mode.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108638
No description provided.