GPv3: Select circle operator #108662

Closed
opened 2023-06-06 15:24:15 +02:00 by Falk David · 7 comments
Member

The VIEW3D_OT_select_circle operator needs to be implemented for the new grease pencil data.

Checklist:

  • In blender/source/blender/editors/space_view3d/view3d_select.cc in the function obedit_circle_select, create a case for OB_GREASE_PENCIL and call into a new static function called grease_pencil_circle_select.
  • Similar to do_grease_pencil_box_select iterate over the editable drawings and call into ed::curves::select_circle.

References:

  • case OB_CURVES: in obedit_circle_select in blender/source/blender/editors/space_view3d/view3d_select.cc
  • do_grease_pencil_box_select in #108661
The `VIEW3D_OT_select_circle` operator needs to be implemented for the new grease pencil data. Checklist: - [ ] In `blender/source/blender/editors/space_view3d/view3d_select.cc` in the function `obedit_circle_select`, create a case for `OB_GREASE_PENCIL` and call into a new static function called `grease_pencil_circle_select`. - [ ] Similar to `do_grease_pencil_box_select` iterate over the editable drawings and call into `ed::curves::select_circle`. References: - `case OB_CURVES:` in `obedit_circle_select` in `blender/source/blender/editors/space_view3d/view3d_select.cc` - `do_grease_pencil_box_select` in https://projects.blender.org/blender/blender/pulls/108661
Falk David added the
Type
To Do
label 2023-06-06 15:24:15 +02:00
Falk David added this to the Grease Pencil project 2023-06-06 15:24:16 +02:00
Falk David changed title from GPv3: Select circle oeprator to GPv3: Select circle operator 2023-06-06 15:24:39 +02:00

Good morning
how can i help you

Good morning how can i help you

I propose changes to lines 4877-4879 for OB_GREASE_PENSIL and changes to lines 4849-4852 for called grease_pencil_circle_select function .
If it wasn't good, you give me information so that i did changes.
Thank you

I propose changes to lines 4877-4879 for OB_GREASE_PENSIL and changes to lines 4849-4852 for called grease_pencil_circle_select function . If it wasn't good, you give me information so that i did changes. Thank you
Author
Member

@Gangneron Hello, would you like to contribute and work on this task? If so, have you contributed to Blender before?

@Gangneron Hello, would you like to contribute and work on this task? If so, have you contributed to Blender before?

Yes i would like contribute and work on task but i never contributed to blender

Yes i would like contribute and work on task but i never contributed to blender
Author
Member

@Gangneron Fantastic! I think in this case it will be easier to join the channel on https://blender.chat/channel/grease-pencil-module to discuss the contribution process further.

@Gangneron Fantastic! I think in this case it will be easier to join the channel on https://blender.chat/channel/grease-pencil-module to discuss the contribution process further.

However I knowledge an python and i learn C++ and HLSL

However I knowledge an python and i learn C++ and HLSL
Author
Member

Resolved by fde2eca1d2

Resolved by https://projects.blender.org/blender/blender/commit/fde2eca1d2b1d6c1acad75f10a70dfcb81de96e9
Blender Bot added the
Status
Archived
label 2023-07-05 12:18:54 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108662
No description provided.