blender
/
blender
134
398
Fork 580
Code Issues 6.3k Pull Requests 759 Projects 19 Wiki Activity

WIP: GPv3: Select Circle operator #108815

Closed
Gangneron wants to merge 14 commits from (deleted):gpv3-select-circle into main
pull from: (deleted):gpv3-select-circle
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 8 Commits 14 Files Changed 2 +5865 -5834
Gangneron commented 2023-06-09 17:29:08 +02:00
First-time contributor
Copy Link

modification requested on #108662 obedit_circle_select and creation of function grease_pensil_circle_select as well as creation of case OB_GREASE_PENSIL.

modification requested on #108662 obedit_circle_select and creation of function grease_pensil_circle_select as well as creation of case OB_GREASE_PENSIL.
Gangneron added 3 commits 2023-06-09 17:31:06 +02:00
a65ac095da WIP : GPv3 : Select circle operator 
modification requested on #108662 obedit_circle_select and creation  of function  grease_pensil_circle_select as well as creation of case OB_GREASE_PENSIL.
eae7599128 WIP : GPv3 Select circle operator 
modification requested on #108662 obedit_circle_select and creation  of function  grease_pensil_circle_select as well as creation of case OB_GREASE_PENSIL.
Iliya Katushenock changed title from gpv3-select-circle to GPv3: Select Circle operator 2023-06-09 17:54:45 +02:00
Iliya Katushenock added this to the Grease Pencil project 2023-06-09 17:55:15 +02:00
Iliya Katushenock requested review from Falk David 2023-06-09 17:55:29 +02:00
Gangneron added 1 commit 2023-06-09 19:49:19 +02:00
a544da4d8b Téléverser vers blender/source/blender/editors/space_view3d 
change from ed::curves::select_box to ed::curves::select_circle
Gangneron commented 2023-06-09 19:52:41 +02:00
Author
First-time contributor
Copy Link

what should i change

what should i change
Gangneron added 1 commit 2023-06-11 13:19:58 +02:00
dbe0b3eb50 blender/source/blender/editors/space_view3d 
fixed do_grease_pensil_box_select and added ed::curves::select_circle to OB_GREASE_PENSIL for obedit_circle_select
Gangneron changed title from GPv3: Select Circle operator to WIP: GPv3: Select Circle operator 2023-06-11 16:59:25 +02:00
Gangneron changed title from WIP: GPv3: Select Circle operator to GPv3: Select Circle operator 2023-06-11 17:00:04 +02:00
Falk David requested changes 2023-06-11 17:01:27 +02:00
Falk David left a comment
Member
Copy Link
  1. Please compile your code, before opening the review. This code does not compile.
  2. Please use the clang-format. The formatting of the code is not right. See https://wiki.blender.org/wiki/Tools/ClangFormat
1. Please compile your code, before opening the review. This code does not compile. 2. Please use the `clang-format`. The formatting of the code is not right. See https://wiki.blender.org/wiki/Tools/ClangFormat
source/blender/editors/space_view3d/view3d_select.cc Outdated
@ -4028,6 +4029,32 @@ static bool do_pose_box_select(bContext *C,
return changed_multi;
}
static bool do_grease_pencil_box_select(ViewContext *vc, const rcti *rect, const eSelectOp sel_op)
Falk David commented 2023-06-11 16:53:39 +02:00
Member
Copy Link

This function should be removed. It looks like you might also need to merge with main.

This function should be removed. It looks like you might also need to merge with `main`.
source/blender/editors/space_view3d/view3d_select.cc Outdated
@ -4113,6 +4140,10 @@ static int view3d_box_select_exec(bContext *C, wmOperator *op)
}
break;
}
case OB_GREASE_PENCIL: {
Falk David commented 2023-06-11 16:53:52 +02:00
Member
Copy Link

Same comment as above.

Same comment as above.
source/blender/editors/space_view3d/view3d_select.cc Outdated
@ -4839,1 +4871,4 @@
* Callbacks for select circle in greasce pensil mode
*/
static bool grease_pensil_circle_select(ViewContext *vc,
Falk David commented 2023-06-11 16:57:51 +02:00
Member
Copy Link

This function doesn't look right. First, it should be named grease_pencil_circle_select.
Second, the logic in the function is not right, it should be similar to the logic inside do_grease_pencil_box_select.

This function doesn't look right. First, it should be named `grease_pencil_circle_select`. Second, the logic in the function is not right, it should be similar to the logic inside `do_grease_pencil_box_select`.
source/blender/editors/space_view3d/view3d_select.cc Outdated
@ -4870,6 +4924,17 @@ static bool obedit_circle_select(bContext *C,
case OB_MBALL:
changed = mball_circle_select(vc, sel_op, mval, rad);
break;
case OB_GREASE_PENSIL:{
Falk David commented 2023-06-11 16:59:14 +02:00
Member
Copy Link

OB_GREASE_PENSIL -> OB_GREASE_PENCIL

`OB_GREASE_PENSIL` -> `OB_GREASE_PENCIL`
source/blender/editors/space_view3d/view3d_select.cc Outdated
@ -4871,2 +4925,4 @@
changed = mball_circle_select(vc, sel_op, mval, rad);
break;
case OB_GREASE_PENSIL:{
GreasePencil &grease_pencil = *static_cast<GreasePencil *>(vc->obedit->data);
Falk David commented 2023-06-11 16:58:53 +02:00
Member
Copy Link

There should just be a call to grease_pencil_circle_select here.

There should just be a call to `grease_pencil_circle_select` here.
Gangneron added 1 commit 2023-06-11 18:31:10 +02:00
Gangneron added 1 commit 2023-06-11 18:52:46 +02:00
0a7a95e7de Téléverser vers blender/source/blender/editors/space_view3d 
the compilation problem could not be resolved, however corrections have been made. I await your reply. Sorry for my inefficiency
Gangneron requested review from Falk David 2023-06-11 18:54:20 +02:00
Gangneron added 1 commit 2023-06-11 19:06:22 +02:00
cc4fe3e6d2 Téléverser vers blender/source/blender/editors/space_view3d 
added static after int for case OB_GREASE_PENCIL
Gangneron commented 2023-06-11 20:21:01 +02:00
Author
First-time contributor
Copy Link

I just have a problem because you marked that you have to do like do_grease_pensil_select_box and it is even you who added this function and now you have to delete it

I just have a problem because you marked that you have to do like do_grease_pensil_select_box and it is even you who added this function and now you have to delete it
Falk David requested changes 2023-06-12 17:01:01 +02:00
Falk David left a comment
Member
Copy Link

Have you been able to compile and build blender by now?

There are still syntax errors in here.

Have you been able to compile and build blender by now? There are still syntax errors in here.
source/blender/editors/space_view3d/view3d_select.cc Outdated
@ -4027,6 +4028,28 @@ static bool do_pose_box_select(bContext *C,
return changed_multi;
}
using namespace blender;
Falk David commented 2023-06-12 16:57:20 +02:00
Member
Copy Link

This looks like some copy-paste error, these added lines should be removed.

This looks like some copy-paste error, these added lines should be removed.
source/blender/editors/space_view3d/view3d_select.cc Outdated
@ -4871,2 +4920,4 @@
changed = mball_circle_select(vc, sel_op, mval, rad);
break;
case OB_GREASE_PENCIL:{
static int grease_pencil_circle_select;
Falk David commented 2023-06-12 16:58:50 +02:00
Member
Copy Link

Here you need to call the function you defined. Like so:

changed = grease_pencil_circle_select(vc, sel_op, mval, rad);
Here you need to call the function you defined. Like so: ``` changed = grease_pencil_circle_select(vc, sel_op, mval, rad); ```
source/blender/editors/space_view3d/view3d_select.cc Outdated
@ -4895,3 +4948,3 @@
BLI_assert(0);
break;
}
}
Falk David commented 2023-06-12 16:59:56 +02:00
Member
Copy Link

Remove added space here.
Again, this should not happen if you use make format.

Remove added space here. Again, this should not happen if you use `make format`.
source/blender/editors/space_view3d/view3d_select.cc Outdated
@ -4899,3 +4952,1 @@
if (changed) {
DEG_id_tag_update(static_cast<ID *>(vc->obact->data), ID_RECALC_SELECT);
WM_main_add_notifier(NC_GEOM | ND_SELECT, vc->obact->data);
if (changed) {
Falk David commented 2023-06-12 17:00:18 +02:00
Member
Copy Link

There shouldn't be any changes here, please undo them.

There shouldn't be any changes here, please undo them.
Gangneron added 1 commit 2023-06-12 18:05:50 +02:00
0a638e3c79 Téléverser vers blender/source/blender/editors/space_view3d 
fix ever issue but compilation problem is always present
Gangneron requested review from Falk David 2023-06-12 18:15:55 +02:00
Gangneron commented 2023-06-12 18:19:24 +02:00
Author
First-time contributor
Copy Link

I made the changes requested however as I solved the git syntax problem to consider that I had changed all the code and therefore to delete all the code in red and add the code with modification in green

I made the changes requested however as I solved the git syntax problem to consider that I had changed all the code and therefore to delete all the code in red and add the code with modification in green
Gangneron commented 2023-06-12 19:17:40 +02:00
Author
First-time contributor
Copy Link

I managed to compile the file

I managed to compile the file
Gangneron added 1 commit 2023-06-13 18:37:21 +02:00
Gangneron added 1 commit 2023-06-16 16:16:57 +02:00
Gangneron added 1 commit 2023-06-16 16:18:19 +02:00
Gangneron changed title from GPv3: Select Circle operator to WIP: GPv3: Select Circle operator 2023-06-20 17:37:07 +02:00
Gangneron added 1 commit 2023-06-20 18:13:50 +02:00
Gangneron commented 2023-06-20 18:30:34 +02:00
Author
First-time contributor
Copy Link

@filedescriptor I fixed every problem but I'm still trying to compile except it still won't open files with .h and .hh extensions and I'm having the problem with all blender files. I have tried telling it the file paths in different ways but nothing works

@filedescriptor I fixed every problem but I'm still trying to compile except it still won't open files with .h and .hh extensions and I'm having the problem with all blender files. I have tried telling it the file paths in different ways but nothing works
Iliya Katushenock commented 2023-06-20 18:33:36 +02:00
Member
Copy Link

Have you use IDE or something else with unicode?

Have you use IDE or something else with unicode?
Gangneron commented 2023-06-20 18:36:31 +02:00
Author
First-time contributor
Copy Link

I use visual studio code and visual studio community

I use visual studio code and visual studio community
Gangneron commented 2023-06-20 18:43:58 +02:00
Author
First-time contributor
Copy Link

@mod_moder and @filedescriptor was it necessary to remove the do_grease_pencil_box_select function from the file.
And I think certian of #108662 could be validated no? And is it grease_pencil_circle_select fontion is good or no

@mod_moder and @filedescriptor was it necessary to remove the do_grease_pencil_box_select function from the file. And I think certian of #108662 could be validated no? And is it grease_pencil_circle_select fontion is good or no
Gangneron changed title from WIP: GPv3: Select Circle operator to WIP: GPv3: Select Circle operator 2023-06-21 12:52:41 +02:00
Gangneron added 1 commit 2023-06-21 13:38:25 +02:00
Falk David closed this pull request 2023-07-05 12:18:11 +02:00
Falk David removed this from the Grease Pencil project 2023-07-05 12:19:38 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Falk David
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108815
No description provided.
Delete Branch "(deleted):gpv3-select-circle"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?