Crash on exit with Metal backend #108792

New Issue

Sergey Sharybin · 2023-06-09T10:25:18+02:00

Sergey Sharybin commented

2023-06-09 10:25:18 +02:00

System Information
Operating system: macOS-13.4-arm64-arm-64bit 64 Bits
Graphics card: Metal API Apple M2 Max 1.2

Blender Version
Broken: version: 3.6.0 Beta, branch: blender-v3.6-release, commit date: 2023-06-08 19:55, hash: fd74b280d95b
Worked: Perhaps 3.5

Short description of error

Blender 3.6 Beta and 4.0 Alpha very often crash on exit. When built with ASAN the following hint is reported:

=================================================================
==33707==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x0001692a0fb0 at pc 0x0001262961f4 bp 0x00016d44a7b0 sp 0x00016d44a7a8
READ of size 8 at 0x0001692a0fb0 thread T0
    #0 0x1262961f0 in blender::gpu::MTLBuffer::~MTLBuffer() mtl_memory.mm:589
    #1 0x12627c438 in blender::gpu::MTLBuffer::~MTLBuffer() mtl_memory.mm:588
    #2 0x12627ba48 in blender::gpu::MTLBufferPool::free() mtl_memory.mm:58
    #3 0x12627b6a4 in blender::gpu::MTLBufferPool::~MTLBufferPool() mtl_memory.mm:50
    #4 0x12627c3dc in blender::gpu::MTLBufferPool::~MTLBufferPool() mtl_memory.mm:49
    #5 0x1261d43c8 in blender::gpu::MTLContext::global_memory_manager_release_ref() mtl_context.hh:907
    #6 0x1261d1490 in blender::gpu::MTLContext::~MTLContext() mtl_context.mm:352
    #7 0x1261bba58 in blender::gpu::MTLContext::~MTLContext() mtl_context.mm:263
    #8 0x1261bbaac in blender::gpu::MTLContext::~MTLContext() mtl_context.mm:263
    #9 0x125cb671c in GPU_context_discard gpu_context.cc:121
    #10 0x109096920 in DRW_opengl_context_destroy draw_manager.c:3238
    #11 0x1076d6ee8 in WM_exit_ex wm_init_exit.cc:673
    #12 0x1076d6008 in WM_exit wm_init_exit.cc:716
    #13 0x1076d5eac in wm_exit_handler(bContext*, wmEvent const*, void*) wm_init_exit.cc:453
    #14 0x107646640 in wm_handler_ui_call(bContext*, wmEventHandler_UI*, wmEvent const*, bool) wm_event_system.cc:817
    #15 0x10763ff20 in wm_handlers_do_intern(bContext*, wmWindow*, wmEvent*, ListBase*) wm_event_system.cc:3313
    #16 0x107634ad4 in wm_handlers_do(bContext*, wmEvent*, ListBase*) wm_event_system.cc:3430
    #17 0x107630884 in wm_event_do_handlers wm_event_system.cc:4057
    #18 0x1075c41e0 in WM_main wm.c:632
    #19 0x102b03c70 in main creator.c:584
    #20 0x19fc73f24  (<unknown module>)

Is hard to reproduce reliably with a simple file, but is ver easy to do with more complex files.

Exact steps for others to reproduce the error

Download Mr. Elephant scene from https://www.blender.org/download/demo-files/
Open the file
Hit F12
CMD-Q and exit.

**System Information** Operating system: macOS-13.4-arm64-arm-64bit 64 Bits Graphics card: Metal API Apple M2 Max 1.2 **Blender Version** Broken: version: 3.6.0 Beta, branch: blender-v3.6-release, commit date: 2023-06-08 19:55, hash: `fd74b280d95b` Worked: Perhaps 3.5 **Short description of error** Blender 3.6 Beta and 4.0 Alpha very often crash on exit. When built with ASAN the following hint is reported: ``` ================================================================= ==33707==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x0001692a0fb0 at pc 0x0001262961f4 bp 0x00016d44a7b0 sp 0x00016d44a7a8 READ of size 8 at 0x0001692a0fb0 thread T0 #0 0x1262961f0 in blender::gpu::MTLBuffer::~MTLBuffer() mtl_memory.mm:589 #1 0x12627c438 in blender::gpu::MTLBuffer::~MTLBuffer() mtl_memory.mm:588 #2 0x12627ba48 in blender::gpu::MTLBufferPool::free() mtl_memory.mm:58 #3 0x12627b6a4 in blender::gpu::MTLBufferPool::~MTLBufferPool() mtl_memory.mm:50 #4 0x12627c3dc in blender::gpu::MTLBufferPool::~MTLBufferPool() mtl_memory.mm:49 #5 0x1261d43c8 in blender::gpu::MTLContext::global_memory_manager_release_ref() mtl_context.hh:907 #6 0x1261d1490 in blender::gpu::MTLContext::~MTLContext() mtl_context.mm:352 #7 0x1261bba58 in blender::gpu::MTLContext::~MTLContext() mtl_context.mm:263 #8 0x1261bbaac in blender::gpu::MTLContext::~MTLContext() mtl_context.mm:263 #9 0x125cb671c in GPU_context_discard gpu_context.cc:121 #10 0x109096920 in DRW_opengl_context_destroy draw_manager.c:3238 #11 0x1076d6ee8 in WM_exit_ex wm_init_exit.cc:673 #12 0x1076d6008 in WM_exit wm_init_exit.cc:716 #13 0x1076d5eac in wm_exit_handler(bContext*, wmEvent const*, void*) wm_init_exit.cc:453 #14 0x107646640 in wm_handler_ui_call(bContext*, wmEventHandler_UI*, wmEvent const*, bool) wm_event_system.cc:817 #15 0x10763ff20 in wm_handlers_do_intern(bContext*, wmWindow*, wmEvent*, ListBase*) wm_event_system.cc:3313 #16 0x107634ad4 in wm_handlers_do(bContext*, wmEvent*, ListBase*) wm_event_system.cc:3430 #17 0x107630884 in wm_event_do_handlers wm_event_system.cc:4057 #18 0x1075c41e0 in WM_main wm.c:632 #19 0x102b03c70 in main creator.c:584 #20 0x19fc73f24 (<unknown module>) ``` Is hard to reproduce reliably with a simple file, but is ver easy to do with more complex files. **Exact steps for others to reproduce the error** * Download Mr. Elephant scene from https://www.blender.org/download/demo-files/ * Open the file * Hit F12 * CMD-Q and exit.

👀 1

Sergey Sharybin added the

labels 2023-06-09 10:25:19 +02:00

Clément Foucault added this to the EEVEE & Viewport project 2023-06-09 10:32:05 +02:00

Clément Foucault added this to the 3.6 LTS milestone 2023-06-09 10:32:15 +02:00

Richard Antalik commented

2023-06-10 02:27:59 +02:00

It crashed here immediately when I pressed Cmd+Q, but got different trace and nothing from ASAN. But will confirm.

👀 1

Richard Antalik added

and removed

labels 2023-06-10 02:28:19 +02:00

Jesse Yurkovich referenced this issue

2023-06-10 07:22:24 +02:00

Crash on exit after every long Sculpt session (Metal backend) #108836

antonheg commented

2023-06-11 19:15:23 +02:00

Blender 3.6 and 4.0 are crashing on exit after long work sessions whatever the mode with a crash report identical to the first one (see #108836).

Blender 3.6 and 4.0 are crashing on exit _after long work sessions_ whatever the mode with a crash report identical to the first one (see #108836).

Michael Parkin-White commented

2023-06-12 11:42:16 +02:00

Will look into getting this sorted asap!

❤️ 1

Michael Parkin-White referenced this issue

2023-06-12 15:30:47 +02:00

Cycles rendered 3DViewport massive performance drop, using lights with node groups. --Intel MacOS-- #108357

Jason Fielder referenced a pull request that will close this issue

2023-06-13 16:29:53 +02:00

Fix #108792: Ensure Metal buffers correctly freed on exit #108940

Brecht Van Lommel added

and removed

labels 2023-06-14 13:12:09 +02:00

antonheg commented

2023-06-14 18:47:26 +02:00

@Michael-Parkin-White-Apple I'll be demoing some Blender 3.6 new features (probably also 4.0) over the weekend. I am afraid it will crash on exit. Any chance of having your fix merged by then? 🙏

Michael Parkin-White commented

2023-06-14 18:48:54 +02:00

@antonheg PR above is currently in review and feedback so far seems fairly straightforward to address. This should be completed tomorrow, so hopefully the patch will be able to land before the weekend!

👍 1 🚀 1

Chris Blackbourn commented

2023-06-18 06:37:28 +02:00

Have a repro here, Venture 13.3.1 (22E261), M1 Pro.

Will apply #108940 and see if it helps.

Have a repro here, Venture 13.3.1 (22E261), M1 Pro. Will apply https://projects.blender.org/blender/blender/pulls/108940 and see if it helps.

Anton Raves commented

2023-06-18 18:30:57 +02:00

Able to reproduce this problem too, MacBook Air M1 with Ventura 13.4 and Blender 3.6.0 Beta r4e7ee5d9ac50. Tried again, render a simple scene (or a complex one, that does not matter) like the default cube, when done rendering let Blender sit for a few minutes, go to a webbrowser, read some mail, whatever, just let Blender sit in the background. After some minutes, press Cmd-Q to quit Blender which it will do, but after a few seconds the message "Blender quit unexpectedly." appears, with "Reopen" / "Report..." or "Ignore" as options.

The "Report..." option created the following attached file:

Able to reproduce this problem too, MacBook Air M1 with Ventura 13.4 and Blender 3.6.0 Beta r4e7ee5d9ac50. Tried again, render a simple scene (or a complex one, that does not matter) like the default cube, when done rendering let Blender sit for a few minutes, go to a webbrowser, read some mail, whatever, just let Blender sit in the background. After some minutes, press Cmd-Q to quit Blender which it will do, but after a few seconds the message "Blender quit unexpectedly." appears, with "Reopen" / "Report..." or "Ignore" as options. The "Report..." option created the following attached file:

blender quit unexpectedly report.txt

81 KiB

Jeroen Bakker referenced this issue from a commit

2023-06-19 20:28:59 +02:00

Fix #108792: Ensure Metal buffers correctly freed on exit

Jeroen Bakker closed this issue

2023-06-19 20:29:01 +02:00

Blender Bot added

Status

Resolved

and removed

Status