GPU: Debug 'Shaders' Folder appearing in 3.6 &. 4.0 on Mac #109314

New Issue

Guido · 2023-06-24T00:11:17+02:00

Guido commented

2023-06-24 00:11:17 +02:00

System Information
Operating system: macOS-13.4.1-x86_64-i386-64bit 64 Bits
Graphics card: Metal API AMD Radeon Pro 5700 XT 1.2

As mentioned by @brecht in #108357 I put it here into a new report.

Blender Version
Broken: version: 3.6.0 Release Candidate, branch: blender-v3.6-release, commit date: 2023-06-22 20:19, hash: fa1121765d53
I tested with vanilla blender 3.1.2, 3.2, 3.3.1, 3.4.1, 3.5, 3.6a, 3.6b &. 4.0.
The Shader folder ONLY gets build when starting up blender from Blender version 3.6alpha to 4.0

Short description of error

When I downloaded blender from blender.org to test , I placed the blender app on the desktop for a quick test.
So when I start blender from the desktop, a folder 'Shaders' will be created on the desktop with all shader files (see file).

Wouldn't it be better to place it here (see image): /Users/USERNAME/Library/Application\ Support/Blender/4.0

This happens in any folder 'Blender' is installed in & the compiled builds blender-git folder.
Happens with downloaded from blender.org versions as well as compiled/build versions.

Another try to fix it:

brew update && brew upgrade (Already up-to-date)

I updated to latest Xcode 14.3.1

I deleted the 'build_darwin' folder in 'blender-git' folder.

make update && make without problems. see 'build log.txt'

New 'Shaders' folder was build after starting of blender in the blender-git folder.

as you can see the '.cache/cyles/kernels/AMD_Radeon_Pro_5700_XT' folder is not updated (see date) after rendering in the 3dviewport. (I also tried deleting it but it will NOT be rebuild) BUT the uncompiled Shaders in the 'Shaders' folder will !?

@Michael-Parkin-White-Apple
Michael Parkin-White commented 2 weeks ago

Regarding the "Shaders" folder:

This is a debug export used to preview generated Metal shaders for the Metal viewport backend, but should only be a debug option. It is likely it became erroneously enabled in another PR while the option was toggled on for debugging.
This itself is not necessary and can be removed, and should also have no bearing on application behaviour.
Viewport shaders (EEVEE, UI, workbench etc) make use of the system shader cache, as these shaders tend to be small in size.
This is also unrelated to the Cycles shader cache which is in-part manually managed using Metal binary archives. Deleting the cycles shader cache can help if issues had previously occurred or the data was in some way corrupted.
Regarding the crash on exit, this is something I am looking into relating to the Metal viewport, and has a separate report (Crash on exit with Metal backend #108792)

Regarding the mentioned performance issues, I can't personally comment on this, as it is unclear if it's a specific regression or just highlighting something which is unexpectedly slow. However @Michael-Jones would be the correct person to look into this, if it is indeed caused by Metal Cycles.

**System Information** Operating system: macOS-13.4.1-x86_64-i386-64bit 64 Bits Graphics card: Metal API AMD Radeon Pro 5700 XT 1.2 As mentioned by @brecht in https://projects.blender.org/blender/blender/issues/108357 I put it here into a new report. **Blender Version** Broken: version: 3.6.0 Release Candidate, branch: blender-v3.6-release, commit date: 2023-06-22 20:19, hash: `fa1121765d53` I tested with vanilla blender 3.1.2, 3.2, 3.3.1, 3.4.1, 3.5, 3.6a, 3.6b &. 4.0. The Shader folder ONLY gets build when starting up blender from Blender version 3.6alpha to 4.0 **Short description of error** When I downloaded blender from blender.org to test , I placed the blender app on the desktop for a quick test. So when I start blender from the desktop, a folder 'Shaders' will be created on the desktop with all shader files (see file). Wouldn't it be better to place it here (see image): /Users/USERNAME/Library/Application\ Support/Blender/4.0 This happens in any folder 'Blender' is installed in & the compiled builds blender-git folder. Happens with downloaded from blender.org versions as well as compiled/build versions. Another try to fix it: brew update && brew upgrade (Already up-to-date) I updated to latest Xcode 14.3.1 I deleted the 'build_darwin' folder in 'blender-git' folder. make update && make without problems. see 'build log.txt' New 'Shaders' folder was build after starting of blender in the blender-git folder. as you can see the '.cache/cyles/kernels/AMD_Radeon_Pro_5700_XT' folder is not updated (see date) after rendering in the 3dviewport. (I also tried deleting it but it will NOT be rebuild) BUT the uncompiled Shaders in the 'Shaders' folder will !? -------------------- @Michael-Parkin-White-Apple Michael Parkin-White commented 2 weeks ago Regarding the "Shaders" folder: This is a debug export used to preview generated Metal shaders for the Metal viewport backend, but should only be a debug option. It is likely it became erroneously enabled in another PR while the option was toggled on for debugging. This itself is not necessary and can be removed, and should also have no bearing on application behaviour. Viewport shaders (EEVEE, UI, workbench etc) make use of the system shader cache, as these shaders tend to be small in size. This is also unrelated to the Cycles shader cache which is in-part manually managed using Metal binary archives. Deleting the cycles shader cache can help if issues had previously occurred or the data was in some way corrupted. Regarding the crash on exit, this is something I am looking into relating to the Metal viewport, and has a separate report (Crash on exit with Metal backend #108792) Regarding the mentioned performance issues, I can't personally comment on this, as it is unclear if it's a specific regression or just highlighting something which is unexpectedly slow. However @Michael-Jones would be the correct person to look into this, if it is indeed caused by Metal Cycles.

System.jpg

21 KiB

Screenshot 2023-06-10 at 9.01.02 pm.jpg

12 KiB

Shaders.zip.webloc

300 B

build log.txt.webloc

300 B

Screenshot 2023-06-10 at 8.39.48 pm.jpg

139 KiB

Screenshot 2023-06-10 at 8.53.16 pm.jpg

28 KiB

Screenshot 2023-06-10 at 8.40.31 pm.jpg

157 KiB

Screenshot 2023-06-12 at 2.27.49 pm.jpg

22 KiB

Guido added the

labels 2023-06-24 00:11:18 +02:00

YimingWu added

Status

Needs Info from Developers

and removed

labels 2023-06-24 04:30:41 +02:00

Clément Foucault added this to the 3.6 LTS milestone 2023-06-24 10:47:15 +02:00

Clément Foucault added this to the EEVEE & Viewport project 2023-06-24 10:47:20 +02:00

Clément Foucault added

and removed

Needs Info from Developers

labels 2023-06-24 10:48:02 +02:00

Clément Foucault changed title from ~~Unknown 'Shaders' - Folder will be build next to blender app when starting vanilla blender 3.1.2, 3.2, 3.3.1, 3.4.1, 3.5, 3.6a, 3.6b &. 4.0. --Intel MacOS--~~ to GPU: Debug 'Shaders' Folder appearing in 3.6 &. 4.0 on Mac

2023-06-24 10:51:34 +02:00

Clément Foucault referenced a pull request that will close this issue

2023-06-24 15:16:00 +02:00

Fix #109314: Metal Debug 'Shaders' Folder appearing in 3.6 &. 4.0 #109323

Clément Foucault referenced this issue from a commit

2023-06-24 17:40:54 +02:00

Fix #109314: Metal Debug 'Shaders' Folder appearing in 3.6 &. 4.0

Clément Foucault closed this issue

2023-06-24 17:40:55 +02:00

Blender Bot added

Status

Resolved