Spreadsheet menu not 'themeable' #109439

New Issue

Closed

opened 2023-06-28 12:56:38 +02:00 by Nika Kutsniashvili · 9 comments

Nika Kutsniashvili commented

2023-06-28 12:56:38 +02:00

Contributor

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 535.98

Blender Version
Broken: version: 3.6.0, branch: blender-v3.6-release, commit date: 2023-06-27 08:08, hash: c7fc78b81ecb
Worked: (newest version of Blender that worked as expected)

Short description of error
Spreadsheet's menu is 'unthemeable', meaning user can't change its color, roundness, outline or anything. It doesn't fit into any of the User Interface menu items, and Spreadsheet menu in Theme has no control either. It is always this blue and rounded and can't be made to fit into themes.

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 535.98 **Blender Version** Broken: version: 3.6.0, branch: blender-v3.6-release, commit date: 2023-06-27 08:08, hash: `c7fc78b81ecb` Worked: (newest version of Blender that worked as expected) **Short description of error** Spreadsheet's menu is 'unthemeable', meaning user can't change its color, roundness, outline or anything. It doesn't fit into any of the User Interface menu items, and Spreadsheet menu in Theme has no control either. It is always this blue and rounded and can't be made to fit into themes. ![image](/attachments/c52a8847-ae08-4191-970f-3748ab6139f1)

25 KiB

Nika Kutsniashvili added the

labels 2023-06-28 12:56:38 +02:00

Iliya Katushenock added the

Nodes & Physics

labels 2023-06-28 12:58:15 +02:00

Iliya Katushenock commented

2023-06-28 14:29:02 +02:00

Member

Can confirm but not sure...

Can confirm but not sure...

YimingWu commented

2023-06-28 15:02:20 +02:00

Member

It's probably taking some other existing color values, otherwise it won't be matching the blue there.

cc @pablovazquez Could you check on this? I couldn't find it either, in both Blender_Light.xml and _Dark.xml there's no separate entry to adjust this color.

It's probably taking some other existing color values, otherwise it won't be matching the blue there. cc @pablovazquez Could you check on this? I couldn't find it either, in both Blender_Light.xml and _Dark.xml there's no separate entry to adjust this color.

YimingWu added

and removed

labels 2023-06-28 15:02:32 +02:00

Pratik Borhade commented

2023-06-29 05:45:32 +02:00

Member

Similar bug has been reported previously, see: #99841 / #99842

(Perhaps we should move them under single thread)

Similar bug has been reported previously, see: #99841 / #99842 (Perhaps we should move them under single thread)

Nika Kutsniashvili commented

2023-06-29 12:43:29 +02:00

Author

Contributor

Similar bug has been reported previously, see: #99841 / #99842

(Perhaps we should move them under single thread)

Seems second one already has solution. But none of the reports recieved developers attentions. Wouldn't it be easier to fix it and close all reports instead?

> Similar bug has been reported previously, see: #99841 / #99842 > > (Perhaps we should move them under single thread) Seems second one already has solution. But none of the reports recieved developers attentions. Wouldn't it be easier to fix it and close all reports instead?

Pablo Vazquez commented

2023-07-05 11:22:44 +02:00

Member

It's probably taking some other existing color values, otherwise it won't be matching the blue there.

cc @pablovazquez Could you check on this? I couldn't find it either, in both Blender_Light.xml and _Dark.xml there's no separate entry to adjust this color.

This is a known issue. The spreadsheet list is using a new property called wcol_view_item, which is not exposed to the user in the Preferences.

A decision needs to be taken to either use wcol_list_item or expose the setting. I will talk with @JulianEisel about this. I personally think we should just use wcol_list_item since the word view is pretty vague and could mean anything.

To workaround the problem you can change the values using Python, in the console:

 bpy.context.preferences.themes['Default'].user_interface.wcol_view_item.text = (1, 0, 0)

Same with .text, .text_sel, .inner, .inner_sel, etc.

> It's probably taking some other existing color values, otherwise it won't be matching the blue there. > > cc @pablovazquez Could you check on this? I couldn't find it either, in both Blender_Light.xml and _Dark.xml there's no separate entry to adjust this color. This is a known issue. The spreadsheet list is using a new property called `wcol_view_item`, which is not exposed to the user in the Preferences. A decision needs to be taken to either use `wcol_list_item` or expose the setting. I will talk with @JulianEisel about this. I personally think we should just use `wcol_list_item` since the word `view` is pretty vague and could mean anything. ---- To workaround the problem you can change the values using Python, in the console: ``` bpy.context.preferences.themes['Default'].user_interface.wcol_view_item.text = (1, 0, 0) ``` Same with `.text`, `.text_sel`, `.inner`, `.inner_sel`, etc.

Julian Eisel commented

2023-07-06 18:33:02 +02:00

Member

Thing is that this color will be shared with other kinds of views, like list views or table views. So I'd rather stick to the corresponding theme color. But in the UI we can call it something like Data-set Item or so.

Thing is that this color will be shared with other kinds of views, like list views or table views. So I'd rather stick to the corresponding theme color. But in the UI we can call it something like _Data-set Item_ or so.

Pablo Vazquez commented

2023-07-07 11:03:08 +02:00

Member

Thing is that this color will be shared with other kinds of views, like list views or table views. So I'd rather stick to the corresponding theme color. But in the UI we can call it something like Data-set Item or so.

A table is a type of list anyway isn't it? So styling both as one would be okay if they were named wcol_list_item. We always wanted to unify parts of the theme that are similar and this is an opportunity to start doing that.

> Thing is that this color will be shared with other kinds of views, like list views or table views. So I'd rather stick to the corresponding theme color. But in the UI we can call it something like _Data-set Item_ or so. A table is a type of list anyway isn't it? So styling both as one would be okay if they were named `wcol_list_item`. We always wanted to unify parts of the theme that are similar and this is an opportunity to start doing that.

Julian Eisel commented

2023-07-17 11:57:25 +02:00

Member

To be clear I'm all for unifying these. It's just a matter of finding the right term, since this option would cover list views, tree views, table views, grid views (like used in the upcoming asset shelf) and all other kinds of views we might come up with. That's why I'm not sure about the term list.

To be clear I'm all for unifying these. It's just a matter of finding the right term, since this option would cover list views, tree views, table views, grid views (like used in the upcoming asset shelf) and all other kinds of views we might come up with. That's why I'm not sure about the term _list_.

Pablo Vazquez commented

2023-07-21 12:05:35 +02:00

Member

To be clear I'm all for unifying these. It's just a matter of finding the right term, since this option would cover list views, tree views, table views, grid views (like used in the upcoming asset shelf) and all other kinds of views we might come up with. That's why I'm not sure about the term list.

But a table, a tree, or a grid, they are all listing elements just with a different display type. So I think the term _list_ is appropriate to keep, and a small plus is that we would be supporting old themes out of the box.

> To be clear I'm all for unifying these. It's just a matter of finding the right term, since this option would cover list views, tree views, table views, grid views (like used in the upcoming asset shelf) and all other kinds of views we might come up with. That's why I'm not sure about the term _list_. But a table, a tree, or a grid, they are all listing elements just with a different display type. So I think the term `_list_` is appropriate to keep, and a small plus is that we would be supporting old themes out of the box.

Leon Schittek referenced a pull request that will close this issue

2023-08-25 13:28:38 +02:00

Fix #109439: Enable Data-View theme preference section #111281

Harley Acheson referenced this issue

2023-08-25 23:34:24 +02:00

Fix #109439: Enable Data-View theme preference section #111281

Pablo Vazquez referenced this issue

2023-08-26 02:00:39 +02:00

Fix #109439: Enable Data-View theme preference section #111281

Ludvik Koutny referenced this issue

2023-08-26 08:28:45 +02:00

Fix #109439: Enable Data-View theme preference section #111281

Harley Acheson referenced this issue

2023-08-26 20:55:47 +02:00

Fix #109439: Enable Data-View theme preference section #111281

Ludvik Koutny referenced a pull request that will close this issue

2023-08-27 12:11:56 +02:00

Fix #109439: Use List Item widget colors for View Item widgets #111584

Harley Acheson referenced this issue from a commit

2023-09-01 20:02:27 +02:00

Fix #109439: Use List Item widget colors for View Item widgets

Harley Acheson closed this issue

2023-09-01 20:02:29 +02:00

Blender Bot added

and removed

labels 2023-09-01 20:02:31 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

6 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109439

No description provided.