Fix #109439: Enable Data-View theme preference section #111281

Ludvik Koutny · 2023-08-18T20:05:26+02:00

Ludvik Koutny commented

2023-08-18 20:05:26 +02:00

It is now used in Spreadsheet and Asset Library editors. Hiding it made theme authors unable to make colors of Data-View panels consistent with the rest of the theme. For example selected item in Spreadsheet Data-View panel had always the default Blender's theme blue color, regardless of the theme selected.

👍 2

Ludvik Koutny added 1 commit 2023-08-18 20:05:35 +02:00

a7e131563e Fixes incorrectly hidden Data-View theme preference section.

It is now used in Spreadsheet and Asset Library editors.
Hiding it made theme authors unable to make colors
of Data-View panels consistent with the rest of the theme.

Ludvik Koutny changed title from ~~UI: Fix incorrectly hidden Data-View theme preference section.~~ to UI: Fix incorrectly hidden Data-View theme preference section

2023-08-18 20:08:11 +02:00

Jesse Yurkovich added the

Module

User Interface

label 2023-08-22 23:30:50 +02:00

Regnas commented

2023-08-25 12:18:53 +02:00

First-time contributor

Why such small things take ages to be reviewed?
That unchangeable blue color has bothering a lot of people in a long time. Nice fix.

Why such small things take ages to be reviewed? That unchangeable blue color has bothering a lot of people in a long time. Nice fix.

Leon Schittek changed title from ~~UI: Fix incorrectly hidden Data-View theme preference section~~ to Fix #109439: Enable Data-View theme preference section

2023-08-25 13:28:38 +02:00

Harley Acheson added this to the User Interface project 2023-08-25 22:30:38 +02:00

Harley Acheson removed the

Module

User Interface

label 2023-08-25 22:30:55 +02:00

Harley Acheson commented

2023-08-25 23:34:24 +02:00

Reviewing the thread in #109439 it is my understanding that the consensus between @JulianEisel and @pablovazquez was to not expose a theme section for wcol_view_item but to replace usages of wcol_view_item with wcol_list_item. So new views use the existing theme colors.

Am I reading this correct? If so this would be good time to do so.

Reviewing the thread in #109439 it is my understanding that the consensus between @JulianEisel and @pablovazquez was to not expose a theme section for `wcol_view_item` but to replace usages of `wcol_view_item` with `wcol_list_item`. So new views use the existing theme colors. Am I reading this correct? If so this would be good time to do so.

Pablo Vazquez commented

2023-08-26 02:00:39 +02:00

Reviewing the thread in #109439 it is my understanding that the consensus was to not expose a theme section for wcol_view_item but to replace usages of wcol_view_item with wcol_list_item.
Am I reading this correct?

Yes, this new theme setting was added as part of introducing the new list view, but this will eventually be used and replace the same purposes as a UIList so there's no point in adding a new setting (to an already bloated theme editor).

We can bring it up in the next UI meeting to confirm.

> Reviewing the thread in #109439 it is my understanding that the consensus was to not expose a theme section for `wcol_view_item` but to replace usages of `wcol_view_item` with `wcol_list_item`. > Am I reading this correct? Yes, this new theme setting was added as part of introducing the new list view, but this will eventually be used and replace the same purposes as a UIList so there's no point in adding a new setting (to an already bloated theme editor). We can bring it up in the next UI meeting to confirm.

Ludvik Koutny commented

2023-08-26 08:28:45 +02:00

But why did it take so long? It's over a month for fixing something as small as using the right widget properties for one UI element.

I don't understand this process. The debate under #109439 ends up in a "We probably should do X" tone, but then no one actually makes some plan to do it and follow through. It I didn't make this wrong patch, then the issue could have been rotting there for over a year, as usual.

But why did it take so long? It's over a month for fixing something as small as using the right widget properties for one UI element. I don't understand this process. The debate under #109439 ends up in a "We probably should do X" tone, but then no one actually makes some plan to do it and follow through. It I didn't make this wrong patch, then the issue could have been rotting there for over a year, as usual.

Harley Acheson commented

2023-08-26 20:55:47 +02:00

But why did it take so long? It's over a month for fixing something as small as using the right widget properties for one UI element.

Yes, sorry about that. Not making excuses because we have lots to improve.

The bug report #109439 has Normal priority and we just get a lot of those. High Priority tickets definitely make us jump, but the rest can get pushed back by other work. We are changing our processes and communication to improve this.

I don't understand this process. The debate under #109439 ends up in a "We probably should do X" tone, but then no one actually makes some plan to do it and follow through.

Not sure of the best course with these. At the point of "we probably should do it like this", we could have made a task with details for it. Although perhaps it would make more sense to have confirmed reports always assigned to someone. Currently self-assigning implies that the person is going to actively work on the solution, but it could instead just mean that person is the "go to" person for that issue, and can be done by someone else. There are some limitations in the tools that Gitea provides.

If I didn't make this wrong patch, then the issue could have been rotting there for over a year, as usual.

Possibly, although we are just starting to have regular bi-weekly meetings so that should make us more responsive.

Because of how Gitea (currently) works, and does not, I didn't notice your PR until you mentioned it yesterday in the "user-interface" chat. I added "User Interface" to its "Projects" list and this makes it show up in our "Workboard" - seen here: https://projects.blender.org/blender/blender/projects/16. That is why it got noticed and commented on yesterday. That Gitea didn't allow you to add the project tag adds to this frustration.

Note that this is how the PR sidebar looked to Ludvik, without means to set anything besides reviewers:

But sorry for the frustration and confusion. Your work and contributions are appreciated, despite how it might appear sometimes.

Cheers, Harley

> But why did it take so long? It's over a month for fixing something as small as using the right widget properties for one UI element. Yes, sorry about that. Not making excuses because we have lots to improve. The bug report #109439 has Normal priority and we just get a lot of those. High Priority tickets definitely make us jump, but the rest can get pushed back by other work. We are changing our processes and communication to improve this. > I don't understand this process. The debate under #109439 ends up in a "We probably should do X" tone, but then no one actually makes some plan to do it and follow through. Not sure of the best course with these. At the point of "we probably should do it like this", we could have made a task with details for it. Although perhaps it would make more sense to have confirmed reports always assigned to _someone_. Currently self-assigning implies that the person is going to actively work on the solution, but it could instead just mean that person is the "go to" person for that issue, and can be done by someone else. There are some limitations in the tools that Gitea provides. > If I didn't make this wrong patch, then the issue could have been rotting there for over a year, as usual. Possibly, although we are just starting to have regular bi-weekly meetings so that should make us more responsive. Because of how Gitea (currently) works, and does not, I didn't notice your PR until you mentioned it yesterday in the "user-interface" chat. I added "User Interface" to its "Projects" list and this makes it show up in our "Workboard" - seen here: https://projects.blender.org/blender/blender/projects/16. That is why it got noticed and commented on yesterday. That Gitea didn't allow you to add the project tag adds to this frustration. Note that this is how the PR sidebar looked to Ludvik, without means to set anything besides reviewers: ![image](/attachments/e3304658-b169-4c0c-b89a-0d422b46d9ea) But sorry for the frustration and confusion. Your work and contributions are appreciated, despite how it might appear sometimes. Cheers, Harley

image.png

40 KiB

❤️ 1

Ludvik Koutny closed this pull request

2023-09-02 11:57:40 +02:00

Ludvik Koutny deleted branch fix-hidden-dataview-themepref

2023-09-02 11:57:51 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #109439: Enable Data-View theme preference section #111281

Pull request closed