NLA Snap to Markers is broken #110108

New Issue

Christoph Lendenfeld · 2023-07-14T16:24:02+02:00

2023-07-14 16:24:02 +02:00

System Information
Operating system:
Graphics card:

Blender Version
Broken: latest main
Worked: 2.93

Caused by bd00324c26

Short description of error
When the NLA snapping mode is set to "Nearest Marker", dragging the strip collapses it to the marker position
Also right clicking then doesn't but it back to the starting position
In fact "Nearest Second" is also slightly broken. It seems the start and end of the strip snap individually

Exact steps for others to reproduce the error

Open attached .blend file (it is already set up with the NLA open and snapping set to "Nearest Marker")
Just drag the strip

Drag's behavior is already broken, but cancel the transform and notice that it's even more broken.

This is sort of the same in the DopeSheet and Graph Editor as well (keyframes get collapsed there -- which is probably undesired as well)

**System Information** Operating system: Graphics card: **Blender Version** Broken: latest main Worked: 2.93 Caused by bd00324c26 **Short description of error** When the NLA snapping mode is set to "Nearest Marker", dragging the strip collapses it to the marker position Also right clicking then doesn't but it back to the starting position In fact "Nearest Second" is also slightly broken. It seems the start and end of the strip snap individually **Exact steps for others to reproduce the error** - Open attached .blend file (it is already set up with the NLA open and snapping set to "Nearest Marker") - Just drag the strip Drag's behavior is already broken, but cancel the transform and notice that it's even more broken. This is sort of the same in the DopeSheet and Graph Editor as well (keyframes get collapsed there -- which is probably undesired as well)

snap_test.blend

889 KiB

👍 1

Christoph Lendenfeld added the

labels 2023-07-14 16:24:02 +02:00

Christoph Lendenfeld added this to the Animation & Rigging project 2023-07-14 16:24:05 +02:00

Germano Cavalcante commented

2023-07-14 22:47:01 +02:00

Thanks for the report, I can confirm.
I tested it on 2.97, it worked there, so it's a regression.

Thanks for the report, I can confirm. I tested it on 2.97, it worked there, so it's a regression.

Germano Cavalcante added

and removed

labels 2023-07-14 22:47:32 +02:00

~~Germano Cavalcante referenced this issue 2023-07-15 00:36:39 +02:00~~

Fix #113552: NLA Markers do not reset when length reaches 0.0 #110121

Germano Cavalcante added

and removed

labels 2023-07-15 00:37:33 +02:00

Philipp Oeser commented

2023-08-18 15:36:12 +02:00

I think the markers case was broken before?

I must say that snapping both start and end is pretty obscure, it looks like the system was set up with this in mind if I look at createTransNlaData.

I think the markers case was broken before? I must say that snapping both start and end is pretty obscure, it looks like the system was set up with this in mind if I look at `createTransNlaData`.

Philipp Oeser referenced this issue

2023-08-18 15:44:03 +02:00

Fix #113552: NLA Markers do not reset when length reaches 0.0 #110121

Germano Cavalcante commented

2023-08-18 15:50:55 +02:00

I agree that this is not ideal. The strip length changes in an unpredictable way.
For me, the ideal would be to snap one of the ends and move the others accordingly.
But it would still be necessary to define how to choose this end.
And this should also perhaps be reflected in the other NLA snap modes (and the snap in Action and Graph since they share the same code).

I agree that this is not ideal. The strip length changes in an unpredictable way. For me, the ideal would be to snap one of the ends and move the others accordingly. But it would still be necessary to define how to choose this end. And this should also perhaps be reflected in the other NLA snap modes (and the snap in Action and Graph since they share the same code).

Philipp Oeser commented

2023-08-18 20:40:03 +02:00

For the NLA markers/seconds, it would probably be best to check both ends for the closest marker/second and pick whatever end has the minimum distance.

Brad Clark commented

2023-08-22 01:12:06 +02:00

And make sure that the scale of the strip isn't what is changed, just the start/end

Christoph Lendenfeld self-assigned this 2023-09-05 10:23:51 +02:00

Christoph Lendenfeld commented

2023-09-05 10:24:00 +02:00

looking at this now

Philipp Oeser commented

2023-09-05 11:16:01 +02:00

Just noting that this is the same in the DopeSheet and Graph Editor as well

Christoph Lendenfeld referenced a pull request that will close this issue

2023-09-05 16:43:33 +02:00

Fix #110108: NLA absolute snapping #111984

Christoph Lendenfeld referenced this issue from a commit

2023-09-15 09:52:48 +02:00

Fix #110108: NLA absolute snapping

Christoph Lendenfeld closed this issue

2023-09-15 09:52:49 +02:00

Blender Bot added

and removed

labels 2023-09-15 09:52:51 +02:00

~~Christoph Lendenfeld referenced this issue 2023-09-15 09:55:08 +02:00~~

Blender LTS: Maintenance Task 3.6 #109399

Christoph Lendenfeld referenced this issue

2023-09-15 10:01:21 +02:00

Blender LTS: Maintenance Task 3.3 #100749

Philipp Oeser commented

2023-09-15 10:10:30 +02:00

Just noting that this is the same in the DopeSheet and Graph Editor as well

Just wanted to check if there has been thoughts / discussions about this? (So if you have a range of keyframes selected, snapping would only work on the leftmost/rightmost, the others get corresponding offset -- similar to what we have for the NLA now)

> Just noting that this is the same in the DopeSheet and Graph Editor as well Just wanted to check if there has been thoughts / discussions about this? (So if you have a range of keyframes selected, snapping would only work on the leftmost/rightmost, the others get corresponding offset -- similar to what we have for the NLA now)

Christoph Lendenfeld commented

2023-09-15 11:26:53 +02:00

Just noting that this is the same in the DopeSheet and Graph Editor as well

Just wanted to check if there has been thoughts / discussions about this? (So if you have a range of keyframes selected, snapping would only work on the leftmost/rightmost, the others get corresponding offset -- similar to what we have for the NLA now)

yes but this would be a separate patch. It's less of a bug than the NLA behavior
For 4.1 we plan to revisit and expand the whole snapping system. It will likely be addressed during that process

> > Just noting that this is the same in the DopeSheet and Graph Editor as well > > Just wanted to check if there has been thoughts / discussions about this? (So if you have a range of keyframes selected, snapping would only work on the leftmost/rightmost, the others get corresponding offset -- similar to what we have for the NLA now) yes but this would be a separate patch. It's less of a bug than the NLA behavior For 4.1 we plan to revisit and expand the whole snapping system. It will likely be addressed during that process

Sybren A. Stüvel referenced this issue

2023-09-19 17:19:58 +02:00

Fix #113552: NLA Markers do not reset when length reaches 0.0 #110121

Germano Cavalcante referenced a pull request that will close this issue

2023-10-11 17:15:16 +02:00

Fix #113552: NLA Markers do not reset when length reaches 0.0 #110121

Germano Cavalcante referenced this issue

2023-10-11 17:32:01 +02:00

Regression: NLA Markers do not reset when length reaches 0.0 #113552

Sign in to join this conversation.