EEVEE-Next: Irradiance Bake: Add validity based dilation #110386

Clément Foucault · 2023-07-22T19:13:59+02:00

Clément Foucault commented

2023-07-22 19:13:59 +02:00

Implement invalid sample points filling. Improves invalid regions
but introduce light leak.

Grid sample points are considered invalid if they have a ratio of
front-face ray hit under the given threshold. This is a post-processing
pass on the baked lighting that fills dark regions produced by
invalid sample location (e.g.: inside walls) with valid neighbor
samples data.

Two new parameters are added:

Dilation Threshold: Validity threshold under which grid samples are
considered invalid. Invalid samples will gather valid lighting data
from valid neighbors inside the dilation radius.
Dilation Radius: Radius of the dilation process. Expressed in grid
sample distance.

The validity of each point is progressively refined just like the
lighting data during the baking process.

The dilation process is implemented as a post-processing pass during
the loading of the grid data into the irradiance atlas. This allows
live tweaking the dilation parameters.

Implement invalid sample points filling. Improves invalid regions but introduce light leak. Grid sample points are considered invalid if they have a ratio of front-face ray hit under the given threshold. This is a post-processing pass on the baked lighting that fills dark regions produced by invalid sample location (e.g.: inside walls) with valid neighbor samples data. Two new parameters are added: - Dilation Threshold: Validity threshold under which grid samples are considered invalid. Invalid samples will gather valid lighting data from valid neighbors inside the dilation radius. - Dilation Radius: Radius of the dilation process. Expressed in grid sample distance. The validity of each point is progressively refined just like the lighting data during the baking process. The dilation process is implemented as a post-processing pass during the loading of the grid data into the irradiance atlas. This allows live tweaking the dilation parameters.

Capture d’écran du 2023-07-22 18-55-22.png

1.1 MiB

Capture d’écran du 2023-07-22 18-55-15.png

1.0 MiB

Capture d’écran du 2023-07-22 18-55-22.png

Capture d’écran du 2023-07-22 18-55-15.png

Clément Foucault added 1 commit 2023-07-22 19:14:11 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

8efa72625c EEVEE-Next: Irradiance Bake: Add validity based dilation

Implement invalid sample points filling. Improves invalid regions
but introduce light leak.

Grid sample points are considered invalid if they have a ratio of
front-face ray hit under the given threshold. This is a post-processing
pass on the baked lighting that fills dark regions produced by
invalid sample location (e.g.: inside walls) with valid neighbor
samples data.

Two new parameters are added:

- Dilation Threshold: Validity threshold under which grid samples are
considered invalid. Invalid samples will gather valid lighting data
from valid neighbors inside the dilation radius.
- Dilation Radius: Radius of the dilation process. Expressed in grid
sample distance.

The validity of each point is progressively refined just like the
lighting data during the baking process.

The dilation process is implemented as a post-processing pass during
the loading of the grid data into the irradiance atlas. This allows
live tweaking the dilation parameters.

Clément Foucault commented

2023-07-22 19:15:26 +02:00

@blender-bot build

Clément Foucault added this to the 4.0 milestone 2023-07-22 19:15:52 +02:00

Clément Foucault added this to the EEVEE & Viewport project 2023-07-22 19:15:55 +02:00

Clément Foucault requested review from Miguel Pozo 2023-07-22 19:16:18 +02:00

Clément Foucault added 1 commit 2023-07-23 13:56:07 +02:00

a0400c2cb8 Merge branch 'main' into eevee-next-irradiance-bake-validity

Miguel Pozo commented

2023-07-24 19:08:59 +02:00

I have not looked too much into the code, but I tested it and I get non-deterministic results:
https://drive.google.com/file/d/1cX0hhCE954cvzFb0YjsYhfBjtx88p-vH/view?usp=sharing

I have not looked too much into the code, but I tested it and I get non-deterministic results: https://drive.google.com/file/d/1cX0hhCE954cvzFb0YjsYhfBjtx88p-vH/view?usp=sharing

Clément Foucault added 2 commits 2023-08-01 19:52:28 +02:00

bd52df2d78 Fix non-deterministic result on nvidia

4ff70ac3d7 Fix crash when saving large grid

Miguel Pozo commented

2023-08-02 16:31:19 +02:00

Just confirming that the committed fix does, indeed, solve the issue on my end.

Clément Foucault merged commit 8e33b20de9 into main

2023-08-03 15:48:42 +02:00

Clément Foucault referenced this issue from a commit

2023-08-03 15:48:43 +02:00

EEVEE-Next: Irradiance Bake: Add validity based dilation

Clément Foucault deleted branch eevee-next-irradiance-bake-validity