GPv3 : Select circle/lasso grease pencil frames #110521

New Issue

Amélie Fondevilla · 2023-07-27T09:23:23+02:00

2023-07-27 09:23:23 +02:00

Adapt the ACTION_OT_select_circle and ACTION_OT_select_lasso operators to take into account grease pencil layer channels.

These operators are defined in /source/blender/editors/space_action/action_select.cc, and executed by the functions action_circle_select_exec and actkeys_lassoselect_exec, which both call region_select_action_keys. The latter function loops through all visible channels, to select the keys that are within the area defined by the circle/lasso using the region_select_elem function. This latter function is the one that should be adapted to take into account grease pencil channels.

Checklist :

In source/blender/editors/grease_pencil/intern/grease_pencil_frames.cc, create and implement the function select_frames_region so that it selects frames within a frame interval.
Note: the idea is to do the same thing than the legacy function ED_gpencil_layer_frames_select_region (source/blender/editors/gpencil_legacy/editaction_gpencil.c), but using the new data structure.
You can look at other functions in grease_pencil_frames.cc to see how to loop through frames in a layer and how to select a frame with the new data structure.
In the function region_select_elem, create a case for grease pencil channels (type ANIMTYPE_GREASE_PENCIL_LAYER), and call your newly created function. Similarly to the legacy case, don't forget to update dependencies after the function call.
Note: Hotkey for testing is C for circle mode (with the cursor inside the dopesheet). For lasso, you can find the operator in the menu (Select > Lasso Select).

Adapt the `ACTION_OT_select_circle` and `ACTION_OT_select_lasso` operators to take into account grease pencil layer channels. These operators are defined in `/source/blender/editors/space_action/action_select.cc`, and executed by the functions `action_circle_select_exec` and `actkeys_lassoselect_exec`, which both call `region_select_action_keys`. The latter function loops through all visible channels, to select the keys that are within the area defined by the circle/lasso using the `region_select_elem` function. This latter function is the one that should be adapted to take into account grease pencil channels. Checklist : - [ ] In `source/blender/editors/grease_pencil/intern/grease_pencil_frames.cc`, create and implement the function `select_frames_region` so that it selects frames within a frame interval. Note: the idea is to do the same thing than the legacy function `ED_gpencil_layer_frames_select_region` (`source/blender/editors/gpencil_legacy/editaction_gpencil.c`), but using the new data structure. You can look at other functions in `grease_pencil_frames.cc` to see how to loop through frames in a layer and how to select a frame with the new data structure. - [ ] In the function `region_select_elem`, create a case for grease pencil channels (type `ANIMTYPE_GREASE_PENCIL_LAYER`), and call your newly created function. Similarly to the legacy case, don't forget to update dependencies after the function call. Note: Hotkey for testing is C for circle mode (with the cursor inside the dopesheet). For lasso, you can find the operator in the menu (Select > Lasso Select).

Amélie Fondevilla added the

Type

To Do

label 2023-07-27 09:23:24 +02:00

Amélie Fondevilla added this to the Grease Pencil project 2023-07-27 09:26:36 +02:00

Amélie Fondevilla referenced this issue

2023-07-27 09:29:47 +02:00

GPv3: Integration in the Dopesheets #110056

Chao Li referenced a pull request that will close this issue

2023-07-28 05:40:22 +02:00

GPv3 : Select circle/lasso grease pencil frames #110558

Amélie Fondevilla referenced this issue from a commit