GPv3 : Integration in the Dopesheets #110056

Open
opened 2023-07-13 14:11:34 +02:00 by Amélie Fondevilla · 13 comments

We need the grease pencil objects to properly appear and behave in three animation containers : the grease pencil dopesheet, the main dopesheet, and the timeline.

Breaking the task in TODOs, note that this list may be edited as we move forward.

  • Include channels.
  • UI
  • Display properties in channel : Opacity/Use Mask/Onion Skinning (#110991) -> see 7f6196ccae
  • Layer UI template : add layer/remove layer/edit layers menu/move (#117628)
  • Channels operators
  • Keyframes Selection
  • Keyframes Editing
We need the grease pencil objects to properly appear and behave in three animation containers : the grease pencil dopesheet, the main dopesheet, and the timeline. Breaking the task in TODOs, note that this list may be edited as we move forward. * Include channels. - [x] Layer Channels. (#108807) -> see https://projects.blender.org/blender/blender/commit/09f8f4d0498129ce05abd31ef41f4317e3fbd701 - [x] Layer Groups (#111015) -> see https://projects.blender.org/blender/blender/commit/3dc93d6e3806d1dd567e5637ea76b221eae5073c - [x] Keyframes in Main/Data-block summary. (#110962) -> see https://projects.blender.org/blender/blender/commit/d5b2960a07c9073d675912ef64252e0da4ebf48e - [ ] Main Dopesheet. - [ ] Timeline. * UI - [x] Display properties in channel : Opacity/Use Mask/Onion Skinning (#110991) -> see https://projects.blender.org/blender/blender/commit/7f6196ccaef0713c8a115277ac354ce6b27fbc59 - [x] Layer UI template : add layer/remove layer/edit layers menu/move (#117628) * Channels operators - [x] Click selection. ( #110133) -> see https://projects.blender.org/blender/blender/commit/56832ed59aefa3bc4bd499d5302c953b0b99d050 - [x] Extend/Substract/All selection. (#110791) -> see https://projects.blender.org/blender/blender/commit/ffafc183bac4332da65bf7023f1333abcf2ff81f - [x] Search filter. (#110484) -> see https://projects.blender.org/blender/blender/commit/4c12988d5a4bd81d4306eec611884614c286e2d5 - [x] Move Up/Top/Down/To Bottom. (#111009) -> see b66c0676b4 - [x] Frame selected channels. (#111512) - [x] Delete channels. (#111426) - [x] Toggle/Enable/Disable channel settings. *(Note: now editing settings of all layer channels, should only edit selected channels.)* * Keyframes Selection - [x] Click/All/None/Invert. (#110492) -> see https://projects.blender.org/blender/blender/commit/0c07fb50c8b54e6db980b672bd64fbbc781bfdda - [x] Select Box. ~~[Community task #110522]~~ (#110939) -> see https://projects.blender.org/blender/blender/commit/27eb6d48d339363b7f41e3a3b64251696d0cc1eb - [x] Select Circle/Lasso. ~~[Community task #110521]~~ ( #110558) -> see https://projects.blender.org/blender/blender/commit/b40e8242ca9991aa3342477c999d54982e64d054 - [x] Column at current frame/current marker. (#110523) -> see https://projects.blender.org/blender/blender/commit/f7130d98c4f317de7c88705e4500b79a53e034d4 * Keyframes Editing - [x] Insert Keyframes. (#110649) -> see https://projects.blender.org/blender/blender/commit/fd75695bed2029f31966746986b79833b1cdafd4 - [x] Key transform : Move/Extend/Slide/Scale. (#110743) -> see https://projects.blender.org/blender/blender/commit/09d2108bf502f94ca30b468ccd5d21b35e4be25a - [x] Delete Keyframes. (#110746) -> see https://projects.blender.org/blender/blender/commit/655b2b6c2cf382bec527d2a65bfd71dc83a044f6 - [x] Duplicate Keyframes. (#111051) - [ ] Copy/Paste Keyframes. [Community Task #113110] (#117388) - [x] Keyframe type. (#111472) - [x] Jump to Next/Previous keyframe. (#111476) - [x] Frame All/Selected keyframes. (#111480) - [x] Snap selection to Current Frame/Nearest Second/Current Marker. (#111507) - [x] Mirror by Times over Current Frame/Value over Zero Value/Times over First Selected Marker. (#111511) -> see e5325b3ee1
Amélie Fondevilla added the
Type
To Do
label 2023-07-13 14:11:35 +02:00
Amélie Fondevilla added this to the Grease Pencil project 2023-07-13 14:11:36 +02:00
Member

Maybe I can start with displaying channels in other animation regions or basic selection support

Maybe I can start with displaying channels in other animation regions or basic selection support
Member

@PratikPB2123 Maybe a good start would be making the channel that is click-selected active? In general I would try and break down the bigger picture into smaller tasks.

@PratikPB2123 Maybe a good start would be making the channel that is click-selected active? In general I would try and break down the bigger picture into smaller tasks.
Member

Yes, I'm also thinking to start with that. Will submit the PR today/tomorrow

Yes, I'm also thinking to start with that. Will submit the PR today/tomorrow
Member
  • Extend/Substract/All selection.*
  • Move Up/Top/Down/To Bottom.

Can start with other channel operators if no one is working on it.

> - Extend/Substract/All selection.* > - Move Up/Top/Down/To Bottom. Can start with other channel operators if no one is working on it.
Author
Member

Hi @PratikPB2123 , yes that would be great !

Hi @PratikPB2123 , yes that would be great !
Member

Frame selected channels.

What is expected in this? :)

> Frame selected channels. What is expected in this? :)
Author
Member

@PratikPB2123 It's an operator that frames the view of the dopesheet to zoom on the frames of the selected channels.
Here is a video of its behavior in grease pencil 2 :

@PratikPB2123 It's an operator that frames the view of the dopesheet to zoom on the frames of the selected channels. Here is a video of its behavior in grease pencil 2 : <video src="/attachments/69d69824-6e86-41c8-901d-de3b229f4dbf" title="frame_selected_channels.mp4" controls></video>
Member

ok, thanks. Will check after "move" operator.

ok, thanks. Will check after "move" operator.
Member

Toggle/Enable/Disable channel settings. (Note: now editing settings of all layer channels, should only edit selected channels.)

It seems this is now working correctly.

> Toggle/Enable/Disable channel settings. (Note: now editing settings of all layer channels, should only edit selected channels.) It seems this is now working correctly.
Member

Copy/Paste Keyframes.

Created community task for it: #113110
Feel free to edit it

> Copy/Paste Keyframes. Created community task for it: https://projects.blender.org/blender/blender/issues/113110 Feel free to edit it
Member

Looking again at dopesheet operators after the recent "copy/paste keys" PR

Layer UI template : add layer/remove layer/edit layers menu/move

If UI is going to be same as GPv2 (image), I can quickly add that.

Looking again at dopesheet operators after the recent "copy/paste keys" PR > Layer UI template : add layer/remove layer/edit layers menu/move If UI is going to be same as GPv2 ([image](/attachments/2a55a16d-1354-4a5a-b98c-7d4913acc626)), I can quickly add that.
2.5 KiB
Author
Member

Looking again at dopesheet operators after the recent "copy/paste keys" PR

Layer UI template : add layer/remove layer/edit layers menu/move

If UI is going to be same as GPv2 (image), I can quickly add that.

Yes, I guess the goal is to replicate that with the corresponding GPv3 operators.
I wonder if this is linked to the UI of the layer's lists in the properties panel, it seems like they have the same layout of operators (cf image).
Thank you !

> Looking again at dopesheet operators after the recent "copy/paste keys" PR > > Layer UI template : add layer/remove layer/edit layers menu/move > > If UI is going to be same as GPv2 ([image](/attachments/2a55a16d-1354-4a5a-b98c-7d4913acc626)), I can quickly add that. Yes, I guess the goal is to replicate that with the corresponding GPv3 operators. I wonder if this is linked to the UI of the layer's lists in the properties panel, it seems like they have the same layout of operators (cf image). Thank you !
Member

UI Template and isolate layer is merged now. I'll take a look at them: image

UI Template and isolate layer is merged now. I'll take a look at them: [image](/attachments/53a1e769-aa68-4dce-acd9-7840fa1aebeb)
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110056
No description provided.