GPv3: Copy/Paste Keyframes #113110

New Issue

Pratik Borhade · 2023-10-01T11:48:22+02:00

Pratik Borhade commented

2023-10-01 11:48:22 +02:00

Copy keyframes:
Aim: Identify selected frames and store them in buffer.

Create a class having two members (BufferItem):
- Array of frame_number (stores frame_number of a selected keyframes per layer)
- Layer in which keyframe belong to
Create static buffer which will store list of selected keyframes i.e. BufferItem (see how this is done for action_keys: copy_animedit_keys() / tAnimCopybufItem / animcopybuf. File: keyframes_general.cc )
Create a new function grease_pencil_copy_keyframes() in grease_pencil_frames.cc
In actkeys_copy_exec(), call the above function. (as of now, animation data of GPv3 is only available in ANIMCONT_GPENCIL)
In grease_pencil_copy_keyframes():
- Iterate through all the visible channels
  - For every channel/layer, iterate through every frame: for (auto [frame_number, frame] : layer.frames().items()) {
  - if frame.is_selected() == true, store frame_number and layer pointer in BufferItem
- Add BufferItem to static list

Paste Keyframes
Aim: Use static list to get all the selected keyframes and create a copy of it at playhead

Create grease_pencil_paste_keyframes()
Call above function in actkeys_paste_exec
In grease_pencil_paste_keyframes(): Iterate through the static list of BufferItem
- Inside this, run for loop for frame_number array
  - Here we can get individual frame from frame_number:
    GreasePencilFrame &frame = layer.frames().lookup(frame_number[i])
  - To create a copy of this keyframe at playhead, we need to duplicate the keyframe and drawing
    Maybe we could use existing function GreasePencil::insert_duplicate_frame()

Some information about mapping of layer, drawings and frames:

Drawing done at each frame is stored at `drawing_array` in `GreasePencil` struct
These drawings and frames shares same `drawing_index`
Frames can be accessed from `Layer` class

Files to look at:

source\blender\editors\space_action\action_edit.cc
source\blender\editors\grease_pencil\intern\grease_pencil_frames.cc
source\blender\blenkernel\intern\grease_pencil.cc

Functions to look at:

actkeys_copy_exec()
ED_gpencil_anim_copybuf_copy()
copy_animedit_keys()
actkeys_paste_exec()
ED_gpencil_anim_copybuf_paste()
insert_duplicate_frame()

**Copy keyframes:** Aim: Identify selected frames and store them in buffer. - Create a class having two members (BufferItem): - Array of frame_number (stores frame_number of a selected keyframes per layer) - Layer in which keyframe belong to - Create static buffer which will store list of selected keyframes i.e. `BufferItem` (see how this is done for action_keys: `copy_animedit_keys() / tAnimCopybufItem / animcopybuf`. File: `keyframes_general.cc` ) - Create a new function `grease_pencil_copy_keyframes()` in `grease_pencil_frames.cc` - In `actkeys_copy_exec()`, call the above function. (as of now, animation data of GPv3 is only available in `ANIMCONT_GPENCIL`) - In `grease_pencil_copy_keyframes()`: - Iterate through all the visible channels - For every channel/layer, iterate through every frame: `for (auto [frame_number, frame] : layer.frames().items()) {` - if `frame.is_selected() == true`, store frame_number and layer pointer in `BufferItem` - Add `BufferItem` to static list **Paste Keyframes** Aim: Use static list to get all the selected keyframes and create a copy of it at playhead - Create `grease_pencil_paste_keyframes()` - Call above function in `actkeys_paste_exec` - In `grease_pencil_paste_keyframes()`: Iterate through the static list of `BufferItem` - Inside this, run for loop for frame_number array - Here we can get individual frame from frame_number: `GreasePencilFrame &frame = layer.frames().lookup(frame_number[i])` - To create a copy of this keyframe at playhead, we need to duplicate the keyframe and drawing Maybe we could use existing function `GreasePencil::insert_duplicate_frame()` - - - **Some information about mapping of layer, drawings and frames:** ``` Drawing done at each frame is stored at `drawing_array` in `GreasePencil` struct These drawings and frames shares same `drawing_index` Frames can be accessed from `Layer` class ``` <details> <summary> Files to look at: </summary> source\blender\editors\space_action\action_edit.cc source\blender\editors\grease_pencil\intern\grease_pencil_frames.cc source\blender\blenkernel\intern\grease_pencil.cc </details> <details> <summary> Functions to look at: </summary> actkeys_copy_exec() ED_gpencil_anim_copybuf_copy() copy_animedit_keys() actkeys_paste_exec() ED_gpencil_anim_copybuf_paste() insert_duplicate_frame() </details>

Pratik Borhade added the

labels 2023-10-01 11:48:23 +02:00

Pratik Borhade added

and removed

labels 2023-10-01 11:51:38 +02:00

Pratik Borhade removed the

Status

Needs Triage

label 2023-10-01 12:05:59 +02:00

Iliya Katushenock removed the

Priority

Normal

label 2023-10-01 14:05:28 +02:00

Iliya Katushenock added this to the Grease Pencil project 2023-10-01 14:05:33 +02:00

Pratik Borhade referenced this issue

2023-10-02 15:00:45 +02:00

GPv3: Integration in the Dopesheets #110056

Amélie Fondevilla referenced this issue

2023-10-02 16:37:20 +02:00

GPv3: Integration in the Dopesheets #110056

Chao Li commented

2023-10-07 01:37:54 +02:00

Hello. Can I take this task if it's not too emergent?

Pratik Borhade commented

2023-10-07 05:44:03 +02:00

Hi, feel free to work on this. If you stuck somewhere, ask in this thread or in #grease-pencil-module

Hi, feel free to work on this. If you stuck somewhere, ask in this thread or in [#grease-pencil-module](https://blender.chat/channel/grease-pencil-module)

👍 1

Falk David referenced this issue

2023-10-25 18:43:46 +02:00

GPv3: Community Tasks: Overview #114158

Chao Li commented

2023-11-01 05:01:22 +01:00

Hello. I tried to use GreasePencil::insert_duplicate_frame() but discovered a bug in this function. I opened #114352. In the meantime I would like to discuss how to store Layer info properly. My question is is it possible that the layers of a grease pencil can also be copied to elsewhere, making the layer pointer stored in copy buffer invalid? If so we cannot store the pointer directly. What is the better identifiers for layers?

Hello. I tried to use `GreasePencil::insert_duplicate_frame()` but discovered a bug in this function. I opened #114352. In the meantime I would like to discuss how to store Layer info properly. My question is is it possible that the layers of a grease pencil can also be copied to elsewhere, making the layer pointer stored in copy buffer invalid? If so we cannot store the pointer directly. What is the better identifiers for layers?

Chao Li referenced this issue

2024-01-21 21:05:37 +01:00

GPv3: Copy/Paste Keyframes #117388

Chao Li commented

2024-01-24 23:05:14 +01:00

GPv3: Copy/Paste Keyframes #117388

Falk David referenced this issue from a commit

2024-04-22 12:06:34 +02:00

GPv3: Copy/Paste Keyframes

Pratik Borhade commented

2024-04-22 12:08:14 +02:00

74b9c6a8a0
Thanks @Chao-Li 🎉