GPv3: Select box grease pencil frames #110522

New Issue

Amélie Fondevilla · 2023-07-27T09:23:26+02:00

2023-07-27 09:23:26 +02:00

Adapt the ACTION_OT_select_leftright, ACTION_OT_select_box and ACTION_OT_select_column (mode MARKERS_BETWEEN only) operators to take into account grease pencil layer channels.

These operators are defined in /source/blender/editors/space_action/action_select.cc, and call respectively actkeys_select_leftright, box_select_elem, and markers_selectkeys_between, which all eventually loop through all visible channels, to select the keys that are within a frame interval.

Checklist :

In source/blender/editors/grease_pencil/intern/grease_pencil_frames.cc, create and implement the function select_frames_box so that it selects frames within a frame interval.
Note: the idea is to do the same thing than the legacy function ED_gpencil_layer_frames_select_box (source/blender/editors/gpencil_legacy/editaction_gpencil.c), but using the new data structure.
You can look at other functions in grease_pencil_frames.cc to see how to loop through frames in a layer and how to select a frame with the new data structure.

Then, use this function to implement the following operators (grease pencil channels have type ANIMTYPE_GREASE_PENCIL_LAYER) :

ACTION_OT_select_leftright : in actkeys_select_leftright.
Note: Hotkey for testing is Ctrl+Shift+LeftClick (with the cursor inside the dopesheet).
ACTION_OT_select_box : in box_select_elem.
Note: Hotkey for testing is B (with the cursor inside the dopesheet).
ACTION_OT_select_column (mode MARKERS_BETWEEN only) : in markers_selectkeys_between.
Note: Hotkey for testing is Shift+K (with the cursor inside the dopesheet).

Adapt the `ACTION_OT_select_leftright`, `ACTION_OT_select_box` and `ACTION_OT_select_column` (mode `MARKERS_BETWEEN` only) operators to take into account grease pencil layer channels. These operators are defined in `/source/blender/editors/space_action/action_select.cc`, and call respectively `actkeys_select_leftright`, `box_select_elem`, and `markers_selectkeys_between`, which all eventually loop through all visible channels, to select the keys that are within a frame interval. Checklist : - [ ] In `source/blender/editors/grease_pencil/intern/grease_pencil_frames.cc`, create and implement the function `select_frames_box` so that it selects frames within a frame interval. Note: the idea is to do the same thing than the legacy function `ED_gpencil_layer_frames_select_box` (`source/blender/editors/gpencil_legacy/editaction_gpencil.c`), but using the new data structure. You can look at other functions in `grease_pencil_frames.cc` to see how to loop through frames in a layer and how to select a frame with the new data structure. Then, use this function to implement the following operators (grease pencil channels have type `ANIMTYPE_GREASE_PENCIL_LAYER`) : - [ ] `ACTION_OT_select_leftright` : in `actkeys_select_leftright`. Note: Hotkey for testing is Ctrl+Shift+LeftClick (with the cursor inside the dopesheet). - [ ] `ACTION_OT_select_box` : in `box_select_elem`. Note: Hotkey for testing is B (with the cursor inside the dopesheet). - [ ] `ACTION_OT_select_column` (mode `MARKERS_BETWEEN` only) : in `markers_selectkeys_between`. Note: Hotkey for testing is Shift+K (with the cursor inside the dopesheet).

Amélie Fondevilla added the

Type

To Do

label 2023-07-27 09:23:26 +02:00

Amélie Fondevilla added this to the Grease Pencil project 2023-07-27 09:23:28 +02:00

Amélie Fondevilla referenced this issue

2023-07-27 09:29:47 +02:00

GPv3: Integration in the Dopesheets #110056

Chao Li referenced a pull request that will close this issue

2023-08-09 03:05:44 +02:00

GPv3: Select box grease pencil frames #110939

Amélie Fondevilla referenced this issue from a commit