Cleanup: Sculpt: Remove duplicate visibility update function #110709

Merged
Hans Goudey merged 2 commits from HooglyBoogly/blender:cleanup-sculpt-remove-duplicate-visibility-update into main 2023-08-29 14:23:10 +02:00
Member

node_update_visibility_redraw and BKE_pbvh_update_visibility
do the same thing, and the latter is better specialized for the three
PBVH types, so remove the first.

The two update methods were added in:

`node_update_visibility_redraw` and `BKE_pbvh_update_visibility` do the same thing, and the latter is better specialized for the three PBVH types, so remove the first. The two update methods were added in: - f4411b58ade1d4d0921243756ecd3499e8d11cd2 - 38d6533f212bf9001cd5f70ed8757eccb9b39dad
Hans Goudey added 1 commit 2023-08-02 01:48:39 +02:00
c1a35e52d7 Cleanup: Sculpt: Remove duplicate visibility update function
`node_update_visibility_redraw` and `BKE_pbvh_update_visibility` seem to
do the same thing, and the latter is better specialized for the three
PBVH types, so remove the first.

The two update methods were added in:
- f4411b58ad
- 38d6533f21
Hans Goudey added this to the Sculpt, Paint & Texture project 2023-08-02 01:53:11 +02:00
Hans Goudey added 1 commit 2023-08-29 03:30:06 +02:00
Hans Goudey requested review from Sergey Sharybin 2023-08-29 03:30:25 +02:00
Author
Member

@blender-bot build

@blender-bot build
Sergey Sharybin approved these changes 2023-08-29 10:02:37 +02:00
Sergey Sharybin left a comment
Owner

Indeed we should not have two ways of doing the same thing.

In a bit longer term it would be nice to get rid of the BKE_pbvh_update_vertex_data, so that we do not mix "specialized" functions for certain things, and "general" function for the rest (but not including the specialized).

And in a slightly more distant future it feels like it should be handled by PBVH node specialization.

P.S. Thing which I dont think is good with the BKE_pbvh_update_visibility is that it does bke::pbvh::search_gather. It feels that it is more efficient to introduce bke::pbvh::search_foreach or something, to avoid temporary storage. But thats a separate story.

Indeed we should not have two ways of doing the same thing. In a bit longer term it would be nice to get rid of the `BKE_pbvh_update_vertex_data`, so that we do not mix "specialized" functions for certain things, and "general" function for the rest (but not including the specialized). And in a slightly more distant future it feels like it should be handled by PBVH node specialization. P.S. Thing which I dont think is good with the `BKE_pbvh_update_visibility` is that it does `bke::pbvh::search_gather`. It feels that it is more efficient to introduce `bke::pbvh::search_foreach` or something, to avoid temporary storage. But thats a separate story.
Hans Goudey merged commit c9621a002d into main 2023-08-29 14:23:10 +02:00
Hans Goudey deleted branch cleanup-sculpt-remove-duplicate-visibility-update 2023-08-29 14:23:19 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110709
No description provided.