blender/blender
142
451
Fork 651
Code Issues 6.5k Pull Requests 824 Projects 18 Wiki Activity

USD Hydra Render Engine #110765

New Issue
Open
opened 2023-08-03 16:41:23 +02:00 by Brecht Van Lommel · 8 comments
Brecht Van Lommel commented 2023-08-03 16:41:23 +02:00
Owner
Copy Link

This tasks lists remaining work for the Hydra render engine, as a follow up to #100892 and #104712.

High priority:

  • Solve OpenGL core profile warnings in console (#110474)
  • MaterialX export (#112864)

Missing features:

  • Material preview surface support in Hydra, sharing code with USD (#110836)
  • Meshes
    • Multiple UV maps
    • Per-vertex color attributes
    • Other attributes like velocity
    • Subdivision surface along with creases
  • Image caching
    • Properly update when image changes in Blender
    • For packed images, unpack instead of saving, is much faster (#110933)
    • Take into account multilayer, stereo, colorspace and other options
    • USD preview surface does not write packed or edited textures to disk
  • Hydra Storm is missing output sockets in compositor, registered Combined pass by default?
  • Hydra Storm seemingly can't read .tx files as in bistro/attic scenes
  • Create node parsing system for World light

Discrepancies between USD and Hydra (as seen in automated render tests):

  • Curves use as animation paths are incorrectly shown in USD
  • Legacy hair particles missing in Hydra (#114197)
  • For USD, child particles are missing
  • No transparent background with USD
  • Missing point clouds for both
  • No background to dome light export in USD
  • ... various other things not listed

Bugs:

  • Camera border in junkshop.blend is wrong in 3D viewport (#113376)
  • USD export has wrong transform for hair in junkshop
  • Blender OpenGL error in feature detection reported by USD (#110915)
  • Use PyC_UnicodeFromBytes should be used instead of PyUnicode_FromString for file paths.

Code cleanup (which should fix issues too):

  • Use BKE_camera_params API to simplify camera code and share more with rest of Blender (#114370)
  • Unify image writing code between USD and Hydra
  • Move _bpy_hydra implementation to python/ folder to avoid accessing private functions of that module?
This tasks lists remaining work for the Hydra render engine, as a follow up to #100892 and #104712. High priority: * [x] Solve OpenGL core profile warnings in console (#110474) * [x] MaterialX export (#112864) Missing features: * [x] Material preview surface support in Hydra, sharing code with USD (#110836) * [ ] Meshes * [ ] Multiple UV maps * [ ] Per-vertex color attributes * [ ] Other attributes like velocity * [ ] Subdivision surface along with creases * [ ] Image caching * [ ] Properly update when image changes in Blender * [x] For packed images, unpack instead of saving, is much faster (#110933) * [ ] Take into account multilayer, stereo, colorspace and other options * [ ] USD preview surface does not write packed or edited textures to disk * [x] Hydra Storm is missing output sockets in compositor, registered Combined pass by default? * [ ] Hydra Storm seemingly can't read .tx files as in bistro/attic scenes * [ ] Create node parsing system for World light Discrepancies between USD and Hydra (as seen in automated render tests): * [ ] Curves use as animation paths are incorrectly shown in USD * [x] Legacy hair particles missing in Hydra (#114197) * [ ] For USD, child particles are missing * [ ] No transparent background with USD * [ ] Missing point clouds for both * [ ] No background to dome light export in USD * [ ] ... various other things not listed Bugs: * [x] Camera border in junkshop.blend is wrong in 3D viewport (https://projects.blender.org/blender/blender/pulls/113376) * [ ] USD export has wrong transform for hair in junkshop * [ ] Blender OpenGL error in feature detection reported by USD (#110915) * [x] Use `PyC_UnicodeFromBytes` should be used instead of `PyUnicode_FromString` for file paths. Code cleanup (which should fix issues too): * [x] Use `BKE_camera_params` API to simplify camera code and share more with rest of Blender (https://projects.blender.org/blender/blender/pulls/114370) * [ ] Unify image writing code between USD and Hydra * [ ] Move `_bpy_hydra` implementation to `python/` folder to avoid accessing private functions of that module?
❤️ 6
Brecht Van Lommel added the
Type
To Do
Module
Render & Cycles
 labels 2023-08-03 16:41:23 +02:00
Brecht Van Lommel added this to the Render & Cycles project 2023-08-03 16:41:25 +02:00
Hans Goudey commented 2023-08-04 17:13:57 +02:00
Member
Copy Link

Is there a plan for sharing geometry export code between Hydra and USD export? I'm noticing some differences right now-- for example that we use the mesh triangulation for Hydra but N-sided faces for the USD exporter. I imagine some of those differences might persist, but a lot of the code would be the same.

Is there a plan for sharing geometry export code between Hydra and USD export? I'm noticing some differences right now-- for example that we use the mesh triangulation for Hydra but N-sided faces for the USD exporter. I imagine some of those differences might persist, but a lot of the code would be the same.
Brecht Van Lommel commented 2023-08-04 17:35:34 +02:00
Author
Owner
Copy Link

@HooglyBoogly that's what I asked for when reviewing this, but it seems difficult. See various comments in the code review.

Both the API and data are different. For example Hydra expects the mesh to be split into submeshes by material, and has an API that queries various attributes on demand rather than exporting everything. I think Hydra does not handle n-gons, except when using subdivision surfaces which is not implemented yet.

I think for geometry export specifically, the best we can probably do is to refactor the code to make its structure, names and behavior more consistent. There might be a bit of code that can be factored out and shared, but not much I think.

@HooglyBoogly that's what I asked for when reviewing this, but it seems difficult. See various comments in the code review. Both the API and data are different. For example Hydra expects the mesh to be split into submeshes by material, and has an API that queries various attributes on demand rather than exporting everything. I think Hydra does not handle n-gons, except when using subdivision surfaces which is not implemented yet. I think for geometry export specifically, the best we can probably do is to refactor the code to make its structure, names and behavior more consistent. There might be a bit of code that can be factored out and shared, but not much I think.
Georgiy Markelov commented 2023-08-08 09:49:54 +02:00
Member
Copy Link

@brecht please add this to the list #110915

@brecht please add this to the list https://projects.blender.org/blender/blender/issues/110915
Brecht Van Lommel commented 2023-08-08 12:34:58 +02:00
Author
Owner
Copy Link

@DagerD I added it now, and also gave you the permission required to edit the issue description yourself for future things.

@DagerD I added it now, and also gave you the permission required to edit the issue description yourself for future things.
❤️ 1
Elijah Nicol commented 2023-08-14 12:55:38 +02:00
Copy Link

Hey hey, I am new to the blender dev space, sorry if this is the wrong place to put my question.

Is there currently support for color attributes such as displayColor being translated to primvars or is that something this issue aims to cover? I imported Pixar's "Kitchen Set" scene into blender, and I noticed that the displayColor is being set as a vertex attribute; however, when using the Hydra Storm renderer, I don't see the colors set by displayColor when rendering (this is the same when using a custom render delegate).

Hey hey, I am new to the blender dev space, sorry if this is the wrong place to put my question. Is there currently support for color attributes such as `displayColor` being translated to primvars or is that something this issue aims to cover? I imported Pixar's "Kitchen Set" scene into blender, and I noticed that the `displayColor` is being set as a vertex attribute; however, when using the `Hydra Storm` renderer, I don't see the colors set by `displayColor` when rendering (this is the same when using a custom render delegate).
Brecht Van Lommel commented 2023-08-14 13:09:16 +02:00
Author
Owner
Copy Link

@Elijah-Nicol that's "Per-vertex color attributes" in the list of missing features. I'm not sure if some other changes will be needed to make Storm use those colors or if it being named displayColor will be enough.

@Elijah-Nicol that's "Per-vertex color attributes" in the list of missing features. I'm not sure if some other changes will be needed to make Storm use those colors or if it being named `displayColor` will be enough.
Elijah Nicol commented 2023-08-14 13:14:08 +02:00
Copy Link

@brecht I thought that was the case, just wanted to check! Do you know when the task of implementing "Per-vertex color attributes" will commence?

@brecht I thought that was the case, just wanted to check! Do you know when the task of implementing "Per-vertex color attributes" will commence?
Brecht Van Lommel commented 2023-08-14 14:53:53 +02:00
Author
Owner
Copy Link

I don't have a timeline, that one will be hopefully be solved before 4.0 is out.

I don't have a timeline, that one will be hopefully be solved before 4.0 is out.
❤️ 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Render & Cycles
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110765
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?