WIP: Hydra: Per-vertex color attributes #114585

Vasyl Pidhirskyi · 2023-11-07T17:15:14+01:00

Vasyl Pidhirskyi commented

2023-11-07 17:15:14 +01:00

Purpose

Add support for Per-vertex color attributes.

Technical steps

Added support for displayColor and displayOpacity.

Notes For Reviewers

Render Delegate uses default vertex Color Attributes if no material assign to material.

Ref: #110765

### Purpose Add support for Per-vertex color attributes. ### Technical steps Added support for displayColor and displayOpacity. ### Notes For Reviewers Render Delegate uses default vertex Color Attributes if no material assign to material. Ref: https://projects.blender.org/blender/blender/issues/110765

Vasyl Pidhirskyi added 2 commits 2023-11-07 17:15:29 +01:00

5c7915b0ec Added support for displayColor and displayOpacity.

9d78d52fb5 Make format.

Vasyl Pidhirskyi requested review from Bogdan Nagirniak 2023-11-07 17:38:24 +01:00

Vasyl Pidhirskyi requested review from Georgiy Markelov 2023-11-07 17:38:38 +01:00

Vasyl Pidhirskyi added 2 commits 2023-11-09 13:54:07 +01:00

1f8418afa1 Merge branch 'main' into per-vertex-color

986f74d967 Condition to use vertex color only if no material is assigned.

Make format.

Georgiy Markelov approved these changes 2023-11-09 15:19:59 +01:00

Georgiy Markelov left a comment

Works fine.

Bogdan Nagirniak added 1 commit 2023-11-09 17:46:37 +01:00

bbcb4bd0f4 Code simplifications and improvements

Bogdan Nagirniak approved these changes 2023-11-09 17:47:51 +01:00

Bogdan Nagirniak left a comment

Made some code simplification and improvement.
Tested - works good

Made some code simplification and improvement. Tested - works good

Vasyl Pidhirskyi requested review from Brecht Van Lommel 2023-11-09 19:28:00 +01:00

Vasyl Pidhirskyi requested review from Brian Savery (AMD) 2023-11-09 19:28:01 +01:00

Brecht Van Lommel requested changes 2023-11-09 19:39:09 +01:00

Brecht Van Lommel left a comment

For me the bullet point in #110765 meant adding support for vertex color attributes to be used by materials.

This makes it fall back to vertex colors if there is no material, but that's not consistent with how Blender works. Blender just uses the default material then, not vertex colors.

So I'm not really sure about the purpose of this PR as is. I can see the use if the Hydra renderer was used similar to workbench in Blender, for editing rather than final renders. But that's not what Hydra is used for at the moment.

For me the bullet point in #110765 meant adding support for vertex color attributes to be used by materials. This makes it fall back to vertex colors if there is no material, but that's not consistent with how Blender works. Blender just uses the default material then, not vertex colors. So I'm not really sure about the purpose of this PR as is. I can see the use if the Hydra renderer was used similar to workbench in Blender, for editing rather than final renders. But that's not what Hydra is used for at the moment.

Vasyl Pidhirskyi commented

2023-11-10 16:02:26 +01:00

I think we can utilize MaterialX nodedef <geompropvalue> for NodeShaderVertexColor to pass the vertex color attribute to Hydra. So Color Attribute node will work the same way as it works for Cycle and Eevee.

I think we can utilize MaterialX nodedef `<geompropvalue>` for `NodeShaderVertexColor` to pass the vertex color attribute to Hydra. So `Color Attribute` node will work the same way as it works for Cycle and Eevee.

Brecht Van Lommel commented

2023-11-13 10:37:07 +01:00

Yes, more generally it should be possible to export any type of attribute and use it this way. The code does not have to be vertex color specific.

There is a question about performance and memory usage. Many of the attributes may not actually be used by materials. For the best performance you'd need to analyze the materials and figure out which attributes they actually use.

Yes, more generally it should be possible to export any type of attribute and use it this way. The code does not have to be vertex color specific. There is a question about performance and memory usage. Many of the attributes may not actually be used by materials. For the best performance you'd need to analyze the materials and figure out which attributes they actually use.

Brian Savery (AMD) approved these changes 2023-11-15 00:47:22 +01:00

Vasyl Pidhirskyi changed title from ~~Hydra: Per-vertex color attributes~~ to WIP: Hydra: Per-vertex color attributes

2023-11-27 14:46:32 +01:00

This pull request has changes conflicting with the target branch.

source/blender/io/usd/hydra/mesh.cc
source/blender/io/usd/hydra/mesh.h

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u per-vertex-color:Vasyl-Pidhirskyi-per-vertex-color

git checkout Vasyl-Pidhirskyi-per-vertex-color

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Hydra: Per-vertex color attributes #114585

Purpose

Technical steps

Notes For Reviewers

Checkout