Projects
Docs
Blog
Forum
Builds

BLENDER.ORG
- Download
  
  Get the latest Blender, older versions, or experimental builds.
- What's New
  
  Stay up-to-date with the new features in the latest Blender releases.
LEARNING & RESOURCES
- Blender Studio
  
  Access production assets and knowledge from the open movies.
- Manual
  
  Documentation on the usage and features in Blender.
DEVELOPMENT
- Developers Blog
  
  Latest development updates, by Blender developers.
- Documentation
  
  Guidelines, release notes and development docs.
- Benchmark
  
  A platform to collect and share results of the Blender Benchmark.
- Blender Conference
  
  The yearly event that brings the community together.
DONATE
- Development Fund
  
  Support core development with a monthly contribution.
- One-time Donations
  
  Perform a single donation with more payment options available.

Explore

Modules

Animation & Rigging Asset System Core Grease Pencil Modeling Nodes & Physics Pipeline, Assets & I/O Platforms, Builds, Tests & Devices

Python & Add-ons

Python API & Text Editor Officially Maintained Add-ons Community Maintained Add-ons

Rendering

EEVEE & Viewport Render & Cycles

Sculpt, Paint & Texture Triaging User Interface VFX & Video

Report a Bug Help

blender

/

blender

134

398

You've already forked blender

Code Issues 6.3k Pull Requests 750 Projects 19 Wiki Activity

EEVEE-Next: Shadow Rendering Refactor #110979

Merged

Clément Foucault merged 34 commits from fclem/blender:eevee-next-shadow-opti into main

2023-08-17 17:35:25 +02:00

Conversation 1 Commits 34 Files Changed 25 +666 -445

Clément Foucault commented

2023-08-09 20:21:14 +02:00

Member

Copy Link

Split shadow rendering per LOD per tilemap and improve
fragment shader invocation rate by using multi-viewport.

Also changes the layout of the atlas to be 4 x 4 x Layers.
This allow to grow the atlas while keeping the content
and page indirection correct, but this isn't implemented
in this patch.

First attempt

Shadow rendering using atomic proved to be less than ideal
and performance were not quite to an acceptable level.

The previous method had issue with atomic contention when
a lot of triangle would overlap and too many fragment shader
invocations with quite complex indirection rules and biases
which made the technique costly.

The new implementation leverage multi viewport and
layered rendeing to effectively replace the need for atomic
and render directly to the shadow atlas. Using the well
supported extension these are free on modern hardware and
do not need a geometry shader.

One view per tile is needed since we use the viewport index
and the layer index as a way to index a specific tile in the
array.

Geometric Complexity Problem

The counterpart of this is that we need to draw one geometry
instance per tile which is 32x32 time more instances (at most)
than with the previous method.

This means that we will have to find a way to mitigate this
geometry cost by either reducing the number of tiles per
tilemaps (in other words, making the system less memory efficient)
or splitting complex objects' geometry into smaller, more
cull friendly chunks (for example, like the sculpt PBVH nodes).
The later seems to be a longer term solution as it requires
way too much engineering time we have right now.

Update Lag Problem

This also mean we can only update up to 64 tile per redraw
which is not enough even in the most basic cases. This leads
to missing or over shadowing when a light updates until there
is no updates and the shadow rendering can catch up.

One possible solution is to update a lower LODs first waiting
until there is no update to render. This would allow no artifact
during the transforms (unless there is too many light updates
even for lowest LOD, but that was an issue also for the
previous implementation). This could also help with the
geometric complexity.

Solution

In the end, we decided to have one view per lod. This limits
the complexity of the fragment shader (improve speed),
reduces the number of views per tilemap (fix update lag),
and reduces the number of instances.
This also mean we cannot render directly to the atlas anymore
and reverted to the atomic solution. Using the smallest
possible viewport, we assure that there isn't that much fragment
shader invocations which was one of the bottleneck. And also
reduces the amount of geometry instances that pass the
clipping test.

Change atlas to 2D Array
Change atomic to also use layers
Add viewport array support to main
Change the final code to output one view per page and set render resolution to page size
Setup viewport array in shadow render code, set render resolution to 4*4 pages.
Add non atomic rendering
Fix Directional shadows
Fix Adaptive Bias
Fix Update Lag
Fix Geometric Cost

Split shadow rendering per LOD per tilemap and improve fragment shader invocation rate by using multi-viewport. Also changes the layout of the atlas to be 4 x 4 x Layers. This allow to grow the atlas while keeping the content and page indirection correct, but this isn't implemented in this patch. # First attempt Shadow rendering using atomic proved to be less than ideal and performance were not quite to an acceptable level. The previous method had issue with atomic contention when a lot of triangle would overlap and too many fragment shader invocations with quite complex indirection rules and biases which made the technique costly. The new implementation leverage multi viewport and layered rendeing to effectively replace the need for atomic and render directly to the shadow atlas. Using the well supported extension these are free on modern hardware and do not need a geometry shader. One view per tile is needed since we use the viewport index and the layer index as a way to index a specific tile in the array. # Geometric Complexity Problem The counterpart of this is that we need to draw one geometry instance per tile which is 32x32 time more instances (at most) than with the previous method. This means that we will have to find a way to mitigate this geometry cost by either reducing the number of tiles per tilemaps (in other words, making the system less memory efficient) or splitting complex objects' geometry into smaller, more cull friendly chunks (for example, like the sculpt PBVH nodes). The later seems to be a longer term solution as it requires way too much engineering time we have right now. # Update Lag Problem This also mean we can only update up to 64 tile per redraw which is not enough even in the most basic cases. This leads to missing or over shadowing when a light updates until there is no updates and the shadow rendering can catch up. One possible solution is to update a lower LODs first waiting until there is no update to render. This would allow no artifact during the transforms (unless there is too many light updates even for lowest LOD, but that was an issue also for the previous implementation). This could also help with the geometric complexity. # Solution In the end, we decided to have one view per lod. This limits the complexity of the fragment shader (improve speed), reduces the number of views per tilemap (fix update lag), and reduces the number of instances. This also mean we cannot render directly to the atlas anymore and reverted to the atomic solution. Using the smallest possible viewport, we assure that there isn't that much fragment shader invocations which was one of the bottleneck. And also reduces the amount of geometry instances that pass the clipping test. - [x] Change atlas to 2D Array - [x] Change atomic to also use layers - [x] Add viewport array support to main - [x] Change the final code to output one view per page and set render resolution to page size - [x] Setup viewport array in shadow render code, set render resolution to 4*4 pages. - [x] Add non atomic rendering - [x] Fix Directional shadows - [x] Fix Adaptive Bias - [x] Fix Update Lag - [x] Fix Geometric Cost

Clément Foucault added 16 commits 2023-08-09 20:21:27 +02:00

abba9ab2c8 GPU: Framebuffer: Add multi viewport support

This add the possibility to define different
viewports inside a single framebuffer and
let the vertex shader decide which viewport
to render to.

This only contain the GL implementation.

00e517a5bd GPU: Add support for gpu_ViewportIndex

This follows the same emulation path as gpu_Layer.
Layer and ViewportIndex now use the same extension
`ARB_shader_viewport_layer_array`

buildbot/vexp-code-patch-coordinator Build done. Details

ee3f58cdc9 GPU: Add tests for multi viewport

0dc2bc1cfe Fix compilation warning and errors on mac

buildbot/vexp-code-patch-coordinator Build done. Details

58cf3ebcd7 Vulkan: Add support for multi viewports

buildbot/vexp-code-patch-coordinator Build done. Details

627ce1f8e4 Fix geometry workaround when extension is not present

585979ea00 Make shadow atlas layered

053993d00c Always use the array layout

044911de73 Fix test compilation

1044a65d41 Make shader view per tile instead of per tilemap

0c67996a54 Fix EEVEE-Next: Shadow: Missing shadow on first frame

This was caused by the free unused data pass in the
init phase that would reset the clip data of the first
tilemap.

Uploading and checking for an invalid index fixes the
issue.

5dc8679566 Merge branch 'main' into eevee-next-shadow-opti

# Conflicts:
#	source/blender/draw/engines/eevee_next/shaders/eevee_shadow_tilemap_init_comp.glsl

41e422ad89 Use multi viewport

56d26a564e Use fast depth rendering instead of atomics

c82b301f2e Merge branch 'main' into eevee-next-shadow-opti

899c3ecde2 Fix biases

Clément Foucault added this to the EEVEE & Viewport project 2023-08-09 20:24:27 +02:00

Clément Foucault requested review from Jeroen Bakker 2023-08-09 20:24:37 +02:00

Michael Parkin-White requested changes 2023-08-09 22:14:36 +02:00

source/blender/draw/engines/eevee_next/eevee_shader_shared.hh Outdated

						
				@ -861,3 +873,3 @@

				struct ShadowTileData {

				  /** Page inside the virtual shadow map atlas. */

				  uint2 page;

				  uint3 page;

Michael Parkin-White commented

2023-08-09 22:14:28 +02:00

First-time contributor

Copy Link

Possible uint3 alignment issue sneaking in. Not sure if these are also host-resident, in which case may need to use uint3_packed

Possible uint3 alignment issue sneaking in. Not sure if these are also host-resident, in which case may need to use uint3_packed

Clément Foucault commented

2023-08-10 10:52:05 +02:00

Author

Member

Copy Link

These are not part of a buffer, it is only decoded data that are stored as one uint in the SSBOs. So I think it is safe as is.

These are not part of a buffer, it is only decoded data that are stored as one uint in the SSBOs. So I think it is safe as is.

Michael Parkin-White commented

2023-08-10 12:04:20 +02:00

First-time contributor

Copy Link

Ah no worries then :) Thanks!

Ah no worries then :) Thanks!

Michael Parkin-White commented

2023-08-10 12:04:21 +02:00

First-time contributor

Copy Link

Ah no worries then :) Thanks!

Ah no worries then :) Thanks!

fclem marked this conversation as resolved

Clément Foucault added 1 commit 2023-08-10 15:04:36 +02:00

7b1852596b Fix directional near/far

Clément Foucault added 1 commit 2023-08-14 16:08:59 +02:00

5458541184 Revert back to atomic method with per LOD views

Clément Foucault added 5 commits 2023-08-14 21:57:12 +02:00

51c79b03f7 Rename view_lod_buf to viewport_index_buf for clarity

7339ca529f Small update rect optimization

Also fix update tagging issue

5d51fb13ae Simplify valid tile output out of the loop

ee8743f84a Add update view count overflow error message

bc38cb77b6 Fix some test errors

Clément Foucault added 4 commits 2023-08-15 17:50:45 +02:00

a7f83e0666 Merge branch 'main' into eevee-next-shadow-opti

29373daaa3 Update & fix tests

935f224d3f Avoid garbage data in the page free heap

0b27d80566 Only allow pages that are up-to-date to participate to shadowing

Clément Foucault added 5 commits 2023-08-16 15:58:10 +02:00

ec615d613e Use manual bitwise ops leads to improve frag shader codegen

9ee03ff0b3 Use SHADOW_PAGE_RES instead of uniform page size

2e582a2858 Fix out of tilemap tiles writing to invalid tiles

c6dbfe0633 Update test to catch viewport optimization issue

8814d15135 Fix caching issue with directionals

Clément Foucault added 1 commit 2023-08-17 16:12:16 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

aa71b2a1cd Introduce back the fragment shader biases

Clément Foucault referenced this pull request

2023-08-17 16:20:04 +02:00

EEVEE-Next Virtual Shadow Mapping #104472

Clément Foucault commented

2023-08-17 16:22:11 +02:00

Author

Member

Copy Link

@blender-bot build

@blender-bot build

Clément Foucault added 1 commit 2023-08-17 17:19:49 +02:00

b411452e5f Merge branch 'main' into eevee-next-shadow-opti

# Conflicts:
#	source/blender/draw/engines/eevee_next/shaders/infos/eevee_material_info.hh

Clément Foucault requested review from Michael Parkin-White 2023-08-17 17:34:43 +02:00

Clément Foucault merged commit 672d25b02d into main

2023-08-17 17:35:25 +02:00

Clément Foucault referenced this issue from a commit

2023-08-17 17:35:25 +02:00

EEVEE-Next: Shadow Rendering Refactor

Clément Foucault deleted branch eevee-next-shadow-opti

2023-08-17 17:35:26 +02:00

Sign in to join this conversation.

No reviewers

Jeroen Bakker

Michael Parkin-White

Labels

Clear labels

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

This issue affects/is about backward or forward compatibility

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Issues relating to Wayland windowing support.

Issues relating to Xorg/X11 support.

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

Clear milestone

No items

No Milestone

Clear projects

No project

EEVEE & Viewport

Clear assignees

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110979

Reference in New Issue

Repository

blender/blender

Title

Body

No description provided.

Delete Branch "fclem/blender:eevee-next-shadow-opti"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Powered by Gitea Page: 747ms Template: 98ms

English

Bahasa Indonesia Deutsch English Español Français Italiano Latviešu Magyar nyelv Nederlands Polski Português de Portugal Português do Brasil Suomi Svenska Türkçe Čeština Ελληνικά Български Русский Українська فارسی മലയാളം 日本語简体中文繁體中文（台灣）繁體中文（香港） 한국어

Licenses API