Better Baking in the Graph Editor #111050

New Issue

Christoph Lendenfeld · 2023-08-11T16:01:36+02:00

2023-08-11 16:01:36 +02:00

Summary

The existing "Bake Curve" operator has been confusing people for a long time because it leaves your curves in an un-editable state.
Additionally the feature set is very limited only allowing to add a key every frame etc.
In order to alleviate the confusion, rename the existing operator and update the manual to indicate its purpose. Then add a better operator that has more options for baking keys.

Manual

Update manual to indicate that the "Bake Curve" operator is meant to safe disk space

Refactor

Features

#111263: Animation: Bake Channel operator
- Add sample step property. e.g. to add a key every n-th frame
- Bake F-Curve modifiers to keys
- Remove or keep existing frames

Future Work

Bake operator for switching rotation mode
Bake operator for switching spaces

## Summary The existing "Bake Curve" operator has been confusing people for a long time because it leaves your curves in an un-editable state. Additionally the feature set is very limited only allowing to add a key every frame etc. In order to alleviate the confusion, rename the existing operator and update the manual to indicate its purpose. Then add a better operator that has more options for baking keys. ## Manual - [x] Update manual to indicate that the "Bake Curve" operator is meant to safe disk space ## Refactor - [x] [#111049: Animation: Rename "Bake Curve" to "Keys to Samples"](https://projects.blender.org/blender/blender/pulls/111049) - [x] [#112148: Animation: Rename Graph_OT_sample](https://projects.blender.org/blender/blender/pulls/112148) - [x] [#112151: Animation: Rename ACTION_OT_sample](https://projects.blender.org/blender/blender/pulls/112151) ## Features - [x] [#111263: Animation: Bake Channel operator](https://projects.blender.org/blender/blender/pulls/111263) * Add sample step property. e.g. to add a key every n-th frame * Bake F-Curve modifiers to keys * Remove or keep existing frames ## Future Work - Bake operator for switching rotation mode - Bake operator for switching spaces

👀 1

Christoph Lendenfeld added this to the 4.0 milestone 2023-08-11 16:01:36 +02:00

Christoph Lendenfeld added the

Type

To Do

label 2023-08-11 16:01:36 +02:00

Brad Clark was assigned by Christoph Lendenfeld

2023-08-11 16:01:36 +02:00

Christoph Lendenfeld added this to the Animation & Rigging project 2023-08-11 16:01:38 +02:00

Brad Clark commented

2023-08-11 18:22:25 +02:00

It would be nice if it could work on preview range or set time range, scene range and either remove everything outside that range or keep it

Christoph Lendenfeld added the

Module

Animation & Rigging

label 2023-09-08 14:20:28 +02:00

Christoph Lendenfeld referenced this issue

2023-09-08 14:36:08 +02:00

Anim: Bake Channel operator #111263

Christoph Lendenfeld referenced this issue

2023-09-08 16:26:16 +02:00

Animation: Rename Graph_OT_sample #112148

Christoph Lendenfeld referenced this issue

2023-09-08 16:51:07 +02:00

Animation: Rename ACTION_OT_sample #112151

Sybren A. Stüvel commented

2023-09-11 11:29:26 +02:00

It would be nice if it could work on preview range or set time range, scene range and either remove everything outside that range or keep it

Since this design task is about disambiguating "baking" and "sampling", please clarify what you mean with "if it could work".

> It would be nice if it could work on preview range or set time range, scene range and either remove everything outside that range or keep it Since this design task is about disambiguating "baking" and "sampling", please clarify what you mean with "if it could work".

Brad Clark commented

2023-09-11 21:38:43 +02:00

Right...I meant to come back to this.
it could work means.

If I have the time preview on and set to frame 20-30 out of 1-100, the bake resulting in new keys would bake the preview range

Or I could bake the channel and set it to a frame range to bake 20-30 without having the preview enabled.

Or I could bake the current scene range start/end for selected curves/channels.

and choose with a toggle what happens to anything outside the range of keys - leaving keys on the curve outside of the range untouched or remove them so that the only keys I am left with are in the range of time I choose.

Right...I meant to come back to this. it could work means. If I have the time preview on and set to frame 20-30 out of 1-100, the bake resulting in new keys would bake the preview range Or I could bake the channel and set it to a frame range to bake 20-30 without having the preview enabled. Or I could bake the current scene range start/end for selected curves/channels. and choose with a toggle what happens to anything outside the range of keys - leaving keys on the curve outside of the range untouched or remove them so that the only keys I am left with are in the range of time I choose.

Christoph Lendenfeld commented

2023-09-12 14:47:51 +02:00

@BClark what's the use case for having such a functionality within the bake operator?
I want to avoid overcomplicating the operator if possible. For me this feels like a separate operator "Trim Channels" or similar

@BClark what's the use case for having such a functionality within the bake operator? I want to avoid overcomplicating the operator if possible. For me this feels like a separate operator "Trim Channels" or similar

Brad Clark commented

2023-09-12 15:38:33 +02:00

.. right, I wasn't sure/didn't know if it is easier to have time range as part of it or just keep this clean and manage the time in a separate operator. I just wanted to mention it since that was the use case for my hacky python script to do the same thing for an animator .. to bake a range.

How best to add that extra functionality is better left to others, I just wanted to mention it.

.. right, I wasn't sure/didn't know if it is easier to have time range as part of it or just keep this clean and manage the time in a separate operator. I just wanted to mention it since that was the use case for my hacky python script to do the same thing for an animator .. to bake a range. How best to add that extra functionality is better left to others, I just wanted to mention it.

Christoph Lendenfeld commented

2023-09-12 15:43:40 +02:00

.. right, I wasn't sure/didn't know if it is easier to have time range as part of it or just keep this clean and manage the time in a separate operator. I just wanted to mention it since that was the use case for my hacky python script to do the same thing for an animator .. to bake a range.

How best to add that extra functionality is better left to others, I just wanted to mention it.

Sorry I think my comment was lacking context. I was only talking about the feature to remove all keyframes outside the baking range.
Baking in a given range is absolutely a feature that is needed

> .. right, I wasn't sure/didn't know if it is easier to have time range as part of it or just keep this clean and manage the time in a separate operator. I just wanted to mention it since that was the use case for my hacky python script to do the same thing for an animator .. to bake a range. > > How best to add that extra functionality is better left to others, I just wanted to mention it. Sorry I think my comment was lacking context. I was only talking about the feature to remove all keyframes outside the baking range. Baking in a given range is absolutely a feature that is needed

Brad Clark commented

2023-09-12 17:21:09 +02:00

oh okay :O) either way... the remove outside of range is just more about being able to be left with only what was baked without having to then go reverse selection, delete etc.. but I will leave the how and where to you :) if it doesn't fit the scope of time range code for this pr.

Christoph Lendenfeld commented

2023-09-14 12:13:17 +02:00

@BClark I was overcomplicating things in my head
made you a new build on #111263 that has 4 options for removing keys

None
In Range
Outside Range
All

@BClark I was overcomplicating things in my head made you a new build on #111263 that has 4 options for removing keys * None * In Range * Outside Range * All

Christoph Lendenfeld modified the milestone from 4.0 to 4.1

2023-11-14 15:08:37 +01:00

Christoph Lendenfeld referenced this issue

2023-12-08 12:39:10 +01:00

Anim: Bake Channel operator #111263

Nathan Vegdahl referenced this issue

2023-12-08 15:45:05 +01:00

Anim: Bake Channel operator #111263

Christoph Lendenfeld referenced this issue from a commit

2023-12-14 11:35:33 +01:00

Anim: Bake Channel operator

Christoph Lendenfeld commented