Importing certain python packages gives Errors/Conflicts #111649

New Issue

domef · 2023-08-29T10:09:45+02:00

domef commented

2023-08-29 10:09:45 +02:00

System Information
Operating system: Ubuntu 22.04.3 LTS
Graphics card: GeForce RTX 2080 Ti

Blender Version
Broken: bpy 3.6.0
Worked: none

Short description of error

When in the same file bpy and other particular packages (e.g. pyvista, textual.widgets) are imported errors are raised at the end of the execution.

Exact steps for others to reproduce the error

For example, with textual.widgets:

import bpy
import textual.widgets

print("Hello, World!")

This error is raised:

Hello, World!
Exception ignored in atexit callback: <function disable_all at 0x7fd64b3e1c60>
Traceback (most recent call last):
  File "/home/federico/venv/lib/python3.10/site-packages/bpy/3.6/scripts/modules/addon_utils.py", line 478, in disable_all
    addon_modules = [
  File "/home/federico/venv/lib/python3.10/site-packages/bpy/3.6/scripts/modules/addon_utils.py", line 480, in <listcomp>
    if getattr(item[1], "__addon_enabled__", False)
  File "/home/federico/venv/lib/python3.10/site-packages/textual/widgets/__init__.py", line 94, in __getattr__
    raise ImportError(f"Package 'textual.widgets' has no class '{widget_class}'")
ImportError: Package 'textual.widgets' has no class '__addon_enabled__'

I managed to fixed it:

import importlib
import traceback
import typing as t
from types import ModuleType

import bpy
import textual.widgets


def monkeypatch_module_getattr(
    module: t.Union[str, t.Type[ModuleType]], debug: bool = False, default: t.Any = None
):
    if isinstance(module, str):
        module = importlib.import_module(module)
    old_getattr = module.__getattr__

    def new_getattr(key: str):
        try:
            return old_getattr(key)
        except Exception:
            if debug:
                traceback.print_exc()
            return default

    if module.__getattr__ is not new_getattr:
        module.__getattr__ = new_getattr


monkeypatch_module_getattr(textual.widgets)
print("Hello, World!")

The output is:

Hello, World!

But with pyvista

import bpy
import pyvista

print("Hello, World!")

This error is raised and my previous fix doesn't work anymore:

Hello, World!
Exception ignored in atexit callback: <function disable_all at 0x7f0c843e1c60>
Traceback (most recent call last):
  File "/home/federico/venv/lib/python3.10/site-packages/bpy/3.6/scripts/modules/addon_utils.py", line 478, in disable_all
    addon_modules = [
  File "/home/federico/venv/lib/python3.10/site-packages/bpy/3.6/scripts/modules/addon_utils.py", line 478, in <listcomp>
    addon_modules = [
RuntimeError: dictionary changed size during iteration

Inspecting the bpy code, this is the code for disable_all:

def disable_all():
    import sys
    # Collect modules to disable first because dict can be modified as we disable.
    addon_modules = [
        item for item in sys.modules.items()
        if getattr(item[1], "__addon_enabled__", False)
    ]
    # Check the enabled state again since it's possible the disable call
    # of one add-on disables others.
    for mod_name, mod in addon_modules:
        if getattr(mod, "__addon_enabled__", False):
            disable(mod_name)

Changing it fixes this last error but I don't know if it's correct:

def disable_all():
    import sys
    # Collect modules to disable first because dict can be modified as we disable.
    modules = {k:v for k,v in sys.modules.items()}
    addon_modules = [
        item for item in modules
        if getattr(item[1], "__addon_enabled__", False)
    ]
    # Check the enabled state again since it's possible the disable call
    # of one add-on disables others.
    for mod_name, mod in addon_modules:
        if getattr(mod, "__addon_enabled__", False):
            disable(mod_name)

I also paste here the __getattr__ of textual.widgets and pyvista for the sake of completeness:

def __getattr__(widget_class: str) -> type[Widget]:
    try:
        return _WIDGETS_LAZY_LOADING_CACHE[widget_class]
    except KeyError:
        pass

    if widget_class not in __all__:
        raise ImportError(f"Package 'textual.widgets' has no class '{widget_class}'")

    widget_module_path = f"._{camel_to_snake(widget_class)}"
    module = import_module(widget_module_path, package="textual.widgets")
    class_ = getattr(module, widget_class)

    _WIDGETS_LAZY_LOADING_CACHE[widget_class] = class_
    return class_

def __getattr__(name):
    """Fetch an attribute ``name`` from ``globals()`` or the ``pyvista.plotting`` module.

    This override is implemented to prevent importing all of the plotting module
    and GL-dependent VTK modules when importing PyVista.

    Raises
    ------
    AttributeError
        If the attribute is not found.

    """
    import importlib
    import inspect

    allow = {
        'demos',
        'examples',
        'ext',
        'trame',
        'utilities',
    }
    if name in allow:
        return importlib.import_module(f'pyvista.{name}')

    # avoid recursive import
    if 'pyvista.plotting' not in sys.modules:
        import pyvista.plotting

    try:
        feature = inspect.getattr_static(sys.modules['pyvista.plotting'], name)
    except AttributeError as e:
        raise AttributeError(f"module 'pyvista' has no attribute '{name}'") from None

    return feature

**System Information** Operating system: Ubuntu 22.04.3 LTS Graphics card: GeForce RTX 2080 Ti **Blender Version** Broken: bpy 3.6.0 Worked: none **Short description of error** When in the same file `bpy` and other particular packages (e.g. `pyvista`, `textual.widgets`) are imported errors are raised at the end of the execution. **Exact steps for others to reproduce the error** For example, with `textual.widgets`: ```python import bpy import textual.widgets print("Hello, World!") ``` This error is raised: ``` Hello, World! Exception ignored in atexit callback: <function disable_all at 0x7fd64b3e1c60> Traceback (most recent call last): File "/home/federico/venv/lib/python3.10/site-packages/bpy/3.6/scripts/modules/addon_utils.py", line 478, in disable_all addon_modules = [ File "/home/federico/venv/lib/python3.10/site-packages/bpy/3.6/scripts/modules/addon_utils.py", line 480, in <listcomp> if getattr(item[1], "__addon_enabled__", False) File "/home/federico/venv/lib/python3.10/site-packages/textual/widgets/__init__.py", line 94, in __getattr__ raise ImportError(f"Package 'textual.widgets' has no class '{widget_class}'") ImportError: Package 'textual.widgets' has no class '__addon_enabled__' ``` I managed to fixed it: ```python import importlib import traceback import typing as t from types import ModuleType import bpy import textual.widgets def monkeypatch_module_getattr( module: t.Union[str, t.Type[ModuleType]], debug: bool = False, default: t.Any = None ): if isinstance(module, str): module = importlib.import_module(module) old_getattr = module.__getattr__ def new_getattr(key: str): try: return old_getattr(key) except Exception: if debug: traceback.print_exc() return default if module.__getattr__ is not new_getattr: module.__getattr__ = new_getattr monkeypatch_module_getattr(textual.widgets) print("Hello, World!") ``` The output is: ``` Hello, World! ``` But with `pyvista` ```python import bpy import pyvista print("Hello, World!") ``` This error is raised and my previous fix doesn't work anymore: ``` Hello, World! Exception ignored in atexit callback: <function disable_all at 0x7f0c843e1c60> Traceback (most recent call last): File "/home/federico/venv/lib/python3.10/site-packages/bpy/3.6/scripts/modules/addon_utils.py", line 478, in disable_all addon_modules = [ File "/home/federico/venv/lib/python3.10/site-packages/bpy/3.6/scripts/modules/addon_utils.py", line 478, in <listcomp> addon_modules = [ RuntimeError: dictionary changed size during iteration ``` Inspecting the bpy code, this is the code for `disable_all`: ```python def disable_all(): import sys # Collect modules to disable first because dict can be modified as we disable. addon_modules = [ item for item in sys.modules.items() if getattr(item[1], "__addon_enabled__", False) ] # Check the enabled state again since it's possible the disable call # of one add-on disables others. for mod_name, mod in addon_modules: if getattr(mod, "__addon_enabled__", False): disable(mod_name) ``` Changing it fixes this last error but I don't know if it's correct: ```python def disable_all(): import sys # Collect modules to disable first because dict can be modified as we disable. modules = {k:v for k,v in sys.modules.items()} addon_modules = [ item for item in modules if getattr(item[1], "__addon_enabled__", False) ] # Check the enabled state again since it's possible the disable call # of one add-on disables others. for mod_name, mod in addon_modules: if getattr(mod, "__addon_enabled__", False): disable(mod_name) ``` I also paste here the `__getattr__` of `textual.widgets` and `pyvista` for the sake of completeness: ```python def __getattr__(widget_class: str) -> type[Widget]: try: return _WIDGETS_LAZY_LOADING_CACHE[widget_class] except KeyError: pass if widget_class not in __all__: raise ImportError(f"Package 'textual.widgets' has no class '{widget_class}'") widget_module_path = f"._{camel_to_snake(widget_class)}" module = import_module(widget_module_path, package="textual.widgets") class_ = getattr(module, widget_class) _WIDGETS_LAZY_LOADING_CACHE[widget_class] = class_ return class_ ``` ```python def __getattr__(name): """Fetch an attribute ``name`` from ``globals()`` or the ``pyvista.plotting`` module. This override is implemented to prevent importing all of the plotting module and GL-dependent VTK modules when importing PyVista. Raises ------ AttributeError If the attribute is not found. """ import importlib import inspect allow = { 'demos', 'examples', 'ext', 'trame', 'utilities', } if name in allow: return importlib.import_module(f'pyvista.{name}') # avoid recursive import if 'pyvista.plotting' not in sys.modules: import pyvista.plotting try: feature = inspect.getattr_static(sys.modules['pyvista.plotting'], name) except AttributeError as e: raise AttributeError(f"module 'pyvista' has no attribute '{name}'") from None return feature ```

domef added the

labels 2023-08-29 10:09:46 +02:00

Iliya Katushenock added the